From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Corentin Labbe <clabbe@baylibre.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Richard Weinberger <richard@nod.at>, Vignesh R <vigneshr@ti.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: partitions: redboot: fix style issues
Date: Thu, 20 May 2021 18:07:47 +0200 [thread overview]
Message-ID: <20210520180747.03fd60b8@xps13> (raw)
In-Reply-To: <CACRpkdZhhNQupN_4Oh759bKL7sEM9M=yOW1y-mT69ugEkjRMZw@mail.gmail.com>
Linus Walleij <linus.walleij@linaro.org> wrote on Thu, 20 May 2021
18:00:04 +0200:
> On Thu, May 20, 2021 at 5:36 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > Linus Walleij <linus.walleij@linaro.org> wrote on Thu, 20 May 2021
> > 17:24:26 +0200:
> > > On Thu, May 20, 2021 at 1:49 PM Corentin Labbe <clabbe@baylibre.com> wrote:
> > >
> > > > This patch fixes easy checkpatch issues.
> > > >
> > > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > > (...)
> > > > - uint32_t flash_base; // Address within FLASH of image
> > > (...)
> > > > + u32 flash_base; // Address within FLASH of image
> > >
> > > Does checkpatch complain about this? At one point the MTD maintainer
> > > disliked the u32/u16/u8 types and explicitly wanted to use the C
> > > standard library types, and it's the kind of eccentric maintainer
> > > deviations we accommodate for.
> >
> > I suppose this happened quite some time ago? :)
> >
> > I've never heard Richard nor Boris complaining about it, nor will I.
>
> Yes that was a specific David Woodhouse preference.
> I'm too old!
Don't be sad, the new trend is to be sleek. In the dark I worship
variables declaration in a reverse Christmas tree order ;-)
next prev parent reply other threads:[~2021-05-20 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 11:48 [PATCH 1/2] mtd: partitions: redboot: seek fis-index-block in the right node Corentin Labbe
2021-05-20 11:48 ` [PATCH 2/2] mtd: partitions: redboot: fix style issues Corentin Labbe
2021-05-20 15:24 ` Linus Walleij
2021-05-20 15:36 ` Miquel Raynal
2021-05-20 16:00 ` Linus Walleij
2021-05-20 16:07 ` Miquel Raynal [this message]
2021-05-26 9:02 ` Miquel Raynal
2021-05-20 15:21 ` [PATCH 1/2] mtd: partitions: redboot: seek fis-index-block in the right node Linus Walleij
2021-05-26 9:02 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520180747.03fd60b8@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=clabbe@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).