From: Daejun Park <daejun7.park@samsung.com>
To: Avri Altman <Avri.Altman@wdc.com>,
Daejun Park <daejun7.park@samsung.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"huobean@gmail.com" <huobean@gmail.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
JinHwan Park <jh.i.park@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>,
Sung-Jun Park <sungjun07.park@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
Dukhyun Kwon <d_hyun.kwon@samsung.com>,
Keoseong Park <keosung.park@samsung.com>,
Jaemyung Lee <jaemyung.lee@samsung.com>,
Jieon Seol <jieon.seol@samsung.com>
Subject: RE: RE: [PATCH v34 4/4] scsi: ufs: Add HPB 2.0 support
Date: Fri, 21 May 2021 17:13:02 +0900 [thread overview]
Message-ID: <20210521081302epcms2p45e2a734f7f14046d6caab2ab16a2d94c@epcms2p4> (raw)
In-Reply-To: <DM6PR04MB65755AE3D9217FA3C0C3455AFC2A9@DM6PR04MB6575.namprd04.prod.outlook.com>
Hi Avri,
>> + /* for pre_req */
>> + hpb->pre_req_min_tr_len = hpb_dev_info->max_hpb_single_cmd + 1;
>> +
>> + if (ufshpb_is_legacy(hba))
>> + hpb->pre_req_max_tr_len = HPB_LEGACY_CHUNK_HIGH;
>> + else
>> + hpb->pre_req_max_tr_len = max(HPB_MULTI_CHUNK_HIGH,
>> + hpb->pre_req_min_tr_len);
>I think this should only be
>else
> hpb->pre_req_max_tr_len = HPB_MULTI_CHUNK_HIGH;
>
>where HPB_MULTI_CHUNK_HIGH should fit into a single byte,
>regardless of bMAX_ DATA_SIZE_FOR_HPB_SINGLE_CMD,
>which being an attribute (u32) can be significantly larger.
I will fix it as suggested.
Thank you.
>
>Thanks,
>Avri
>
>
>
>
>
next prev parent reply other threads:[~2021-05-21 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210428232257epcms2p8602b29d63529fca8a06010a21157d5cb@epcms2p8>
2021-04-28 23:22 ` [PATCH v34 0/4] scsi: ufs: Add Host Performance Booster Support Daejun Park
[not found] ` <CGME20210428232257epcms2p8602b29d63529fca8a06010a21157d5cb@epcms2p3>
2021-04-28 23:24 ` [PATCH v34 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
[not found] ` <CGME20210428232257epcms2p8602b29d63529fca8a06010a21157d5cb@epcms2p2>
2021-04-28 23:25 ` [PATCH v34 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
[not found] ` <CGME20210428232257epcms2p8602b29d63529fca8a06010a21157d5cb@epcms2p4>
2021-04-28 23:23 ` [PATCH v34 1/4] scsi: ufs: Introduce HPB feature Daejun Park
2021-05-17 9:40 ` Stanley Chu
2021-04-28 23:25 ` [PATCH v34 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-05-20 12:32 ` Avri Altman
2021-05-21 8:13 ` Daejun Park [this message]
2021-04-29 6:44 ` [PATCH v34 0/4] scsi: ufs: Add Host Performance Booster Support Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521081302epcms2p45e2a734f7f14046d6caab2ab16a2d94c@epcms2p4 \
--to=daejun7.park@samsung.com \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=d_hyun.kwon@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=huobean@gmail.com \
--cc=j-young.choi@samsung.com \
--cc=jaemyung.lee@samsung.com \
--cc=javier.gonz@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=jh.i.park@samsung.com \
--cc=jieon.seol@samsung.com \
--cc=keosung.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).