From: Herbert Xu <herbert@gondor.apana.org.au>
To: Hui Tang <tanghui20@huawei.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
xuzaibo@huawei.com, wangzhou1@hisilicon.com,
linux-kernel@vger.kernel.org,
Stephan Mueller <smueller@chronox.de>
Subject: Re: [PATCH 1/3] crypto: ecdh - fix 'ecdh_init'
Date: Fri, 21 May 2021 16:13:56 +0800 [thread overview]
Message-ID: <20210521081356.3bnytzdxhjkgzb7g@gondor.apana.org.au> (raw)
In-Reply-To: <2a5bcd22-455d-6348-9a72-dc5a7ab49ca6@huawei.com>
On Fri, May 21, 2021 at 04:08:10PM +0800, Hui Tang wrote:
>
> On 2021/5/21 15:45, Herbert Xu wrote:
> > On Wed, May 12, 2021 at 02:40:00PM +0800, Hui Tang wrote:
> > > NIST P192 is not unregistered if failed to register NIST P256,
> > > actually it need to unregister the algorithms already registered.
> > >
> > > Signed-off-by: Hui Tang <tanghui20@huawei.com>
> > > ---
> > > crypto/ecdh.c | 11 ++++++++++-
> > > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > Thanks for catching this. The variable ecdh_nist_p192_registered
> > is bogus. You should just make it so that if p192 fails to
> > register then the init function aborts. There would then be
> > no need to check for the registered state in the exit function.
>
> Okay, I will fix it in next version, and 'ecdsa_init' should
> do the same thing too?
Actually, it looks like it is needed for FIPS. We should add
a comment that p192 will fail to register in FIPS mode and that's
why there is a check for it.
Funnily enough, ecdsa has the FIPS comment but testmgr doesn't
set fips_allowed for any of them while ecdh is set but has no
comment.
Stephan, can you confirm that both ecdh-nist-p192 and ecdsa-nist-p192
should be disabled in FIPS mode?
Also, we should fix ecdh-nist-p192's entry in testmgr by removing
the ifdefs and not setting fips_allowed.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-05-21 8:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 6:39 [PATCH 0/3] crypto: ecdh - register NIST P384 Hui Tang
2021-05-12 6:40 ` [PATCH 1/3] crypto: ecdh - fix 'ecdh_init' Hui Tang
2021-05-21 7:45 ` Herbert Xu
2021-05-21 8:08 ` Hui Tang
2021-05-21 8:13 ` Herbert Xu [this message]
2021-05-21 9:36 ` Stephan Mueller
2021-05-12 6:40 ` [PATCH 2/3] crypto: ecdh - register NIST P384 tfm Hui Tang
2021-05-12 6:40 ` [PATCH 3/3] crypto: ecdh - add test suite for NIST P384 Hui Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521081356.3bnytzdxhjkgzb7g@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smueller@chronox.de \
--cc=tanghui20@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).