From: kernel test robot <lkp@intel.com>
To: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
David Howells <dhowells@redhat.com>
Cc: kbuild-all@lists.01.org, Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Ben Boeckel <me@benboeckel.net>,
Randy Dunlap <rdunlap@infradead.org>,
Malte Gell <malte.gell@gmx.de>,
Varad Gautam <varad.gautam@suse.com>,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7,2/4] PKCS#7: Check codeSigning EKU for kernel module and kexec pe verification
Date: Sun, 23 May 2021 02:55:45 +0800 [thread overview]
Message-ID: <202105230248.tf7PLa0j-lkp@intel.com> (raw)
In-Reply-To: <20210521094220.1238-3-jlee@suse.com>
[-- Attachment #1: Type: text/plain, Size: 2678 bytes --]
Hi Chun-Yi",
I love your patch! Perhaps something to improve:
[auto build test WARNING on cryptodev/master]
[also build test WARNING on linus/master v5.13-rc2 next-20210521]
[cannot apply to crypto/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lee-Chun-Yi/Check-codeSigning-extended-key-usage-extension/20210522-220349
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: openrisc-randconfig-r015-20210522 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/928555596c9cd62caabf8777ed8152ddac2609ef
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Lee-Chun-Yi/Check-codeSigning-extended-key-usage-extension/20210522-220349
git checkout 928555596c9cd62caabf8777ed8152ddac2609ef
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from certs/system_keyring.c:17:
include/keys/system_keyring.h:72:1: error: expected identifier or '(' before '{' token
72 | {
| ^
>> include/keys/system_keyring.h:70:19: warning: 'is_key_on_revocation_list' used but never defined
70 | static inline int is_key_on_revocation_list(struct pkcs7_message *pkcs7,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/is_key_on_revocation_list +70 include/keys/system_keyring.h
60
61 #ifdef CONFIG_SYSTEM_REVOCATION_LIST
62 extern int add_key_to_revocation_list(const char *data, size_t size);
63 extern int is_key_on_revocation_list(struct pkcs7_message *pkcs7,
64 enum key_being_used_for usage);
65 #else
66 static inline int add_key_to_revocation_list(const char *data, size_t size)
67 {
68 return 0;
69 }
> 70 static inline int is_key_on_revocation_list(struct pkcs7_message *pkcs7,
71 enum key_being_used_for usage);
72 {
73 return -ENOKEY;
74 }
75 #endif
76
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25079 bytes --]
next prev parent reply other threads:[~2021-05-22 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 9:42 [PATCH v7 0/4] Check codeSigning extended key usage extension Lee, Chun-Yi
2021-05-21 9:42 ` [PATCH v7,1/4] X.509: Add CodeSigning extended key usage parsing Lee, Chun-Yi
2021-05-21 9:42 ` [PATCH v7,2/4] PKCS#7: Check codeSigning EKU for kernel module and kexec pe verification Lee, Chun-Yi
2021-05-22 17:26 ` kernel test robot
2021-05-22 18:55 ` kernel test robot [this message]
2021-05-21 9:42 ` [PATCH v7,3/4] modsign: Add codeSigning EKU when generating X.509 key generation config Lee, Chun-Yi
2021-05-21 9:42 ` [PATCH v7,4/4] Documentation/admin-guide/module-signing.rst: add openssl command option example for CodeSign EKU Lee, Chun-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202105230248.tf7PLa0j-lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=joeyli.kernel@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malte.gell@gmx.de \
--cc=me@benboeckel.net \
--cc=rdunlap@infradead.org \
--cc=varad.gautam@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).