From: Will Deacon <will@kernel.org>
To: Rui Wang <wangrui@loongson.cn>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>, Guo Ren <guoren@kernel.org>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Rui Wang <r@hev.cc>, Xuefeng Li <lixuefeng@loongson.cn>,
Huacai Chen <chenhuacai@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@loongson.cn>,
kernel test robot <lkp@intel.com>
Subject: Re: [RFC PATCH v3] locking/atomic: Implement atomic{,64,_long}_{fetch_,}{andnot_or}{,_relaxed,_acquire,_release}()
Date: Thu, 29 Jul 2021 10:55:52 +0100 [thread overview]
Message-ID: <20210729095551.GE21151@willie-the-truck> (raw)
In-Reply-To: <20210729093003.146166-1-wangrui@loongson.cn>
On Thu, Jul 29, 2021 at 05:30:03PM +0800, Rui Wang wrote:
> This patch introduce a new atomic primitive andnot_or:
>
> * atomic_andnot_or
> * atomic_fetch_andnot_or
> * atomic_fetch_andnot_or_relaxed
> * atomic_fetch_andnot_or_acquire
> * atomic_fetch_andnot_or_release
> * atomic64_andnot_or
> * atomic64_fetch_andnot_or
> * atomic64_fetch_andnot_or_relaxed
> * atomic64_fetch_andnot_or_acquire
> * atomic64_fetch_andnot_or_release
> * atomic_long_andnot_or
> * atomic_long_fetch_andnot_or
> * atomic_long_fetch_andnot_or_relaxed
> * atomic_long_fetch_andnot_or_acquire
> * atomic_long_fetch_andnot_or_release
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Rui Wang <wangrui@loongson.cn>
> ---
> include/asm-generic/atomic-instrumented.h | 72 +++++-
> include/asm-generic/atomic-long.h | 62 ++++-
> include/linux/atomic-arch-fallback.h | 262 +++++++++++++++++++++-
> lib/atomic64_test.c | 92 ++++----
> scripts/atomic/atomics.tbl | 1 +
> scripts/atomic/fallbacks/andnot_or | 25 +++
> 6 files changed, 471 insertions(+), 43 deletions(-)
> create mode 100755 scripts/atomic/fallbacks/andnot_or
Please see my other comments on the other patches you posted:
https://lore.kernel.org/r/20210729093923.GD21151@willie-the-truck
Overall, I'm not thrilled to bits by extending the atomics API with
operations that cannot be implemented efficiently on any (?) architectures
and are only used by the qspinlock slowpath on machines with more than 16K
CPUs.
I also think we're lacking documentation justifying when you would use this
new primitive over e.g. a sub-word WRITE_ONCE() on architectures that
support those, especially for the non-returning variants.
Will
next prev parent reply other threads:[~2021-07-29 9:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 9:30 [RFC PATCH v3] locking/atomic: Implement atomic{,64,_long}_{fetch_,}{andnot_or}{,_relaxed,_acquire,_release}() Rui Wang
2021-07-29 9:55 ` Will Deacon [this message]
2021-07-29 10:58 ` hev
2021-07-29 11:15 ` Peter Zijlstra
2021-07-29 12:34 ` Will Deacon
2021-07-29 11:43 ` Arnd Bergmann
2021-07-29 12:35 ` Will Deacon
2021-07-30 2:50 ` hev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729095551.GE21151@willie-the-truck \
--to=will@kernel.org \
--cc=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=guoren@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=lkp@intel.com \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=r@hev.cc \
--cc=wangrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).