From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <live-patching@vger.kernel.org>
Cc: <jpoimboe@redhat.com>, <jikos@kernel.org>, <mbenes@suse.cz>,
<pmladek@suse.com>, <void@manifault.com>
Subject: [PATCH -next] livepatch: Fix missing unlock on error in klp_enable_patch()
Date: Sat, 25 Dec 2021 10:51:15 +0800 [thread overview]
Message-ID: <20211225025115.475348-1-yangyingliang@huawei.com> (raw)
Add missing unlock when try_module_get() fails in klp_enable_patch().
Fixes: bf01c2975925 ("livepatch: Fix kobject refcount bug on klp_init_patch_early failure path")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
kernel/livepatch/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 23cf444091a8..01bfab7fe7c0 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -1047,8 +1047,10 @@ int klp_enable_patch(struct klp_patch *patch)
return -EINVAL;
}
- if (!try_module_get(patch->mod))
+ if (!try_module_get(patch->mod)) {
+ mutex_unlock(&klp_mutex);
return -ENODEV;
+ }
klp_init_patch_early(patch);
--
2.25.1
next reply other threads:[~2021-12-25 2:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 2:51 Yang Yingliang [this message]
2021-12-27 16:31 ` [PATCH -next] livepatch: Fix missing unlock on error in klp_enable_patch() David Vernet
2022-01-03 10:49 ` Petr Mladek
2022-01-03 13:46 ` Petr Mladek
2022-01-04 13:09 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211225025115.475348-1-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).