* [PATCH] ARM: dts: qcom: msm8226: add clocks and clock-names to gcc node
@ 2023-01-18 18:08 Rayyan Ansari
2023-01-19 2:33 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Rayyan Ansari @ 2023-01-18 18:08 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, Rayyan Ansari, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
Add the XO and Sleep Clock sources to the GCC node.
Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
---
arch/arm/boot/dts/qcom-msm8226.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
index 4cba25dad8d6..c261fdfbe116 100644
--- a/arch/arm/boot/dts/qcom-msm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
@@ -370,6 +370,11 @@ gcc: clock-controller@fc400000 {
#clock-cells = <1>;
#reset-cells = <1>;
#power-domain-cells = <1>;
+
+ clocks = <&xo_board>,
+ <&sleep_clk>;
+ clock-names = "xo",
+ "sleep_clk";
};
mmcc: clock-controller@fd8c0000 {
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: dts: qcom: msm8226: add clocks and clock-names to gcc node
2023-01-18 18:08 [PATCH] ARM: dts: qcom: msm8226: add clocks and clock-names to gcc node Rayyan Ansari
@ 2023-01-19 2:33 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2023-01-19 2:33 UTC (permalink / raw)
To: Rayyan Ansari
Cc: linux-arm-msm, ~postmarketos/upstreaming, Andy Gross,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On Wed, Jan 18, 2023 at 06:08:52PM +0000, Rayyan Ansari wrote:
> Add the XO and Sleep Clock sources to the GCC node.
>
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
> ---
> arch/arm/boot/dts/qcom-msm8226.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
> index 4cba25dad8d6..c261fdfbe116 100644
> --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> @@ -370,6 +370,11 @@ gcc: clock-controller@fc400000 {
> #clock-cells = <1>;
> #reset-cells = <1>;
> #power-domain-cells = <1>;
> +
> + clocks = <&xo_board>,
If I read the downstream sources [1] correctly, we're missing XO_CLK_SRC
among the 8974 rpm clocks. But that's what "xo" in &gcc should refer to.
Can you please define this clock and use it instead?
[1] https://source.codeaurora.org/quic/la/kernel/msm/tree/arch/arm/mach-msm/clock-8974.c?h=msm-3.4#n715
Regards,
Bjorn
> + <&sleep_clk>;
> + clock-names = "xo",
> + "sleep_clk";
> };
>
> mmcc: clock-controller@fd8c0000 {
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-19 2:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-18 18:08 [PATCH] ARM: dts: qcom: msm8226: add clocks and clock-names to gcc node Rayyan Ansari
2023-01-19 2:33 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).