* [PATCH 1/3] thermal: core: introduce governor .reboot_prepare()
[not found] <20230525211655.627415-1-evalenti@kernel.org>
@ 2023-05-25 21:16 ` Eduardo Valentin
2023-05-25 21:16 ` [PATCH 2/3] thermal: core: register reboot nb Eduardo Valentin
2023-05-25 21:16 ` [PATCH 3/3] thermal: core: register a crash callback Eduardo Valentin
2 siblings, 0 replies; 3+ messages in thread
From: Eduardo Valentin @ 2023-05-25 21:16 UTC (permalink / raw
To: daniel.lezcano, rafael, linux-pm
Cc: Eduardo Valentin, Amit Kucheria, Zhang Rui, Jonathan Corbet,
linux-doc, linux-kernel
From: Eduardo Valentin <eduval@amazon.com>
This callback is used to notify the governors that
reboot is coming up. Upon this event, this callback
gives governors the opportunity to leave the thermal
zones in a sane state prior to reboot.
Cc: "Rafael J. Wysocki" <rafael@kernel.org> (supporter:THERMAL)
Cc: Daniel Lezcano <daniel.lezcano@linaro.org> (supporter:THERMAL)
Cc: Amit Kucheria <amitk@kernel.org> (reviewer:THERMAL)
Cc: Zhang Rui <rui.zhang@intel.com> (reviewer:THERMAL)
Cc: Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION)
Cc: linux-pm@vger.kernel.org (open list:THERMAL)
Cc: linux-doc@vger.kernel.org (open list:DOCUMENTATION)
Cc: linux-kernel@vger.kernel.org (open list)
Signed-off-by: Eduardo Valentin <eduval@amazon.com>
---
include/linux/thermal.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index 82c8e09a63e0..d3c8af928522 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -201,6 +201,9 @@ struct thermal_zone_device {
* below the trip point temperature
* @check_error: callback called whenever temperature updates fail.
* Opportunity for the governor to react on errors.
+ * @reboot_prepare: callback called upon system restart.
+ * Opportunity for the governor to tear down zones or at least
+ * leave them in a safe state.
* @governor_list: node in thermal_governor_list (in thermal_core.c)
*/
struct thermal_governor {
@@ -209,6 +212,7 @@ struct thermal_governor {
void (*unbind_from_tz)(struct thermal_zone_device *tz);
int (*throttle)(struct thermal_zone_device *tz, int trip);
void (*check_error)(struct thermal_zone_device *tz, int error);
+ void (*reboot_prepare)(struct thermal_zone_device *tz);
struct list_head governor_list;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/3] thermal: core: register reboot nb
[not found] <20230525211655.627415-1-evalenti@kernel.org>
2023-05-25 21:16 ` [PATCH 1/3] thermal: core: introduce governor .reboot_prepare() Eduardo Valentin
@ 2023-05-25 21:16 ` Eduardo Valentin
2023-05-25 21:16 ` [PATCH 3/3] thermal: core: register a crash callback Eduardo Valentin
2 siblings, 0 replies; 3+ messages in thread
From: Eduardo Valentin @ 2023-05-25 21:16 UTC (permalink / raw
To: daniel.lezcano, rafael, linux-pm
Cc: Eduardo Valentin, Amit Kucheria, Zhang Rui, Jonathan Corbet,
linux-doc, linux-kernel
From: Eduardo Valentin <eduval@amazon.com>
This commit will register a reboot notifier block
callback for giving opportunity tearing down
thermal zones, e.g. remove their workqueues, and
for giving the governors the opportunity to leave
the hardware in a known safe state.
Cc: "Rafael J. Wysocki" <rafael@kernel.org> (supporter:THERMAL)
Cc: Daniel Lezcano <daniel.lezcano@linaro.org> (supporter:THERMAL)
Cc: Amit Kucheria <amitk@kernel.org> (reviewer:THERMAL)
Cc: Zhang Rui <rui.zhang@intel.com> (reviewer:THERMAL)
Cc: Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION)
Cc: linux-pm@vger.kernel.org (open list:THERMAL)
Cc: linux-doc@vger.kernel.org (open list:DOCUMENTATION)
Cc: linux-kernel@vger.kernel.org (open list)
Signed-off-by: Eduardo Valentin <eduval@amazon.com>
---
drivers/thermal/thermal_core.c | 39 ++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 359e7b2ff0e3..66a255fb650b 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -319,6 +319,12 @@ static void handle_error_temperature(struct thermal_zone_device *tz, int error)
tz->governor->check_error(tz, error);
}
+static void handle_reboot_prepare(struct thermal_zone_device *tz)
+{
+ if (tz->governor && tz->governor->reboot_prepare)
+ tz->governor->reboot_prepare(tz);
+}
+
void thermal_zone_device_critical(struct thermal_zone_device *tz)
{
/*
@@ -1508,6 +1514,30 @@ struct thermal_zone_device *thermal_zone_get_zone_by_name(const char *name)
}
EXPORT_SYMBOL_GPL(thermal_zone_get_zone_by_name);
+/* Best effort attempt to leave thermal zones at a safe state across reboots */
+static void thermal_reboot_prepare(void)
+{
+ struct thermal_zone_device *tz;
+
+ list_for_each_entry(tz, &thermal_tz_list, node) {
+ cancel_delayed_work(&tz->poll_queue);
+ handle_reboot_prepare(tz);
+ }
+}
+
+static int thermal_reboot_notify(struct notifier_block *nb,
+ unsigned long mode, void *_unused)
+{
+ switch (mode) {
+ case SYS_RESTART:
+ thermal_reboot_prepare();
+ break;
+ default:
+ break;
+ }
+ return 0;
+}
+
static int thermal_pm_notify(struct notifier_block *nb,
unsigned long mode, void *_unused)
{
@@ -1539,6 +1569,10 @@ static struct notifier_block thermal_pm_nb = {
.notifier_call = thermal_pm_notify,
};
+static struct notifier_block thermal_reboot_nb = {
+ .notifier_call = thermal_reboot_notify,
+};
+
static int __init thermal_init(void)
{
int result;
@@ -1572,6 +1606,11 @@ static int __init thermal_init(void)
pr_warn("Thermal: Can not register suspend notifier, return %d\n",
result);
+ result = register_reboot_notifier(&thermal_reboot_nb);
+ if (result)
+ pr_warn("Thermal: Can not register reboot notifier, return %d\n",
+ result);
+
return 0;
unregister_governors:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/3] thermal: core: register a crash callback
[not found] <20230525211655.627415-1-evalenti@kernel.org>
2023-05-25 21:16 ` [PATCH 1/3] thermal: core: introduce governor .reboot_prepare() Eduardo Valentin
2023-05-25 21:16 ` [PATCH 2/3] thermal: core: register reboot nb Eduardo Valentin
@ 2023-05-25 21:16 ` Eduardo Valentin
2 siblings, 0 replies; 3+ messages in thread
From: Eduardo Valentin @ 2023-05-25 21:16 UTC (permalink / raw
To: daniel.lezcano, rafael, linux-pm
Cc: Eduardo Valentin, Amit Kucheria, Zhang Rui, Jonathan Corbet,
linux-doc, linux-kernel
From: Eduardo Valentin <eduval@amazon.com>
This commit will register a crash callback for
the thermal subsystem, this way the thermal
core can tear down the thermal zones and ask
governors to leave the hardware in a known
safe state prior upon the event of a crash.
Cc: "Rafael J. Wysocki" <rafael@kernel.org> (supporter:THERMAL)
Cc: Daniel Lezcano <daniel.lezcano@linaro.org> (supporter:THERMAL)
Cc: Amit Kucheria <amitk@kernel.org> (reviewer:THERMAL)
Cc: Zhang Rui <rui.zhang@intel.com> (reviewer:THERMAL)
Cc: Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION)
Cc: linux-pm@vger.kernel.org (open list:THERMAL)
Cc: linux-doc@vger.kernel.org (open list:DOCUMENTATION)
Cc: linux-kernel@vger.kernel.org (open list)
Signed-off-by: Eduardo Valentin <eduval@amazon.com>
---
drivers/thermal/thermal_core.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 66a255fb650b..38b168b9245e 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -20,6 +20,7 @@
#include <linux/string.h>
#include <linux/of.h>
#include <linux/suspend.h>
+#include <linux/panic_notifier.h>
#define CREATE_TRACE_POINTS
#include "thermal_trace.h"
@@ -1525,6 +1526,14 @@ static void thermal_reboot_prepare(void)
}
}
+static int thermal_crash_notify(struct notifier_block *nb,
+ unsigned long mode, void *_unused)
+{
+ thermal_reboot_prepare();
+
+ return 0;
+}
+
static int thermal_reboot_notify(struct notifier_block *nb,
unsigned long mode, void *_unused)
{
@@ -1569,6 +1578,10 @@ static struct notifier_block thermal_pm_nb = {
.notifier_call = thermal_pm_notify,
};
+static struct notifier_block thermal_crash_nb = {
+ .notifier_call = thermal_crash_notify,
+};
+
static struct notifier_block thermal_reboot_nb = {
.notifier_call = thermal_reboot_notify,
};
@@ -1611,6 +1624,8 @@ static int __init thermal_init(void)
pr_warn("Thermal: Can not register reboot notifier, return %d\n",
result);
+ atomic_notifier_chain_register(&panic_notifier_list,
+ &thermal_crash_nb);
return 0;
unregister_governors:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-25 21:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230525211655.627415-1-evalenti@kernel.org>
2023-05-25 21:16 ` [PATCH 1/3] thermal: core: introduce governor .reboot_prepare() Eduardo Valentin
2023-05-25 21:16 ` [PATCH 2/3] thermal: core: register reboot nb Eduardo Valentin
2023-05-25 21:16 ` [PATCH 3/3] thermal: core: register a crash callback Eduardo Valentin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).