From: Steven Rostedt <rostedt@goodmis.org>
To: Zheng Yejian <zhengyejian1@huawei.com>
Cc: <mhiramat@kernel.org>, <shuah@kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/ftrace: Test toplevel-enable for instance
Date: Fri, 9 Jun 2023 17:46:26 -0400 [thread overview]
Message-ID: <20230609174626.66659892@gandalf.local.home> (raw)
In-Reply-To: <20230509203659.1173917-1-zhengyejian1@huawei.com>
On Wed, 10 May 2023 04:36:59 +0800
Zheng Yejian <zhengyejian1@huawei.com> wrote:
> 'available_events' is actually not required by
> 'test.d/event/toplevel-enable.tc' and its Existence has been tested in
> 'test.d/00basic/basic4.tc'.
>
> So the require of 'available_events' can be dropped and then we can add
> 'instance' flag to test 'test.d/event/toplevel-enable.tc' for instance.
>
> Test result show as below:
> # ./ftracetest test.d/event/toplevel-enable.tc
> === Ftrace unit tests ===
> [1] event tracing - enable/disable with top level files [PASS]
> [2] (instance) event tracing - enable/disable with top level files [PASS]
>
> # of passed: 2
> # of failed: 0
> # of unresolved: 0
> # of untested: 0
> # of unsupported: 0
> # of xfailed: 0
> # of undefined(test bug): 0
>
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
> ---
> tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> index 93c10ea42a68..8b8e1aea985b 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> @@ -1,7 +1,8 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> # description: event tracing - enable/disable with top level files
> -# requires: available_events set_event events/enable
> +# requires: set_event events/enable
> +# flags: instance
>
> do_reset() {
> echo > set_event
next prev parent reply other threads:[~2023-06-09 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 20:36 [PATCH] selftests/ftrace: Test toplevel-enable for instance Zheng Yejian
2023-06-09 21:46 ` Steven Rostedt [this message]
2023-07-10 21:54 ` Steven Rostedt
2023-09-08 1:40 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609174626.66659892@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=zhengyejian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).