From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7A12C83003 for ; Fri, 9 Jun 2023 13:11:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240650AbjFINLD (ORCPT ); Fri, 9 Jun 2023 09:11:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240568AbjFINKx (ORCPT ); Fri, 9 Jun 2023 09:10:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAE4BBF; Fri, 9 Jun 2023 06:10:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 69A1F6125E; Fri, 9 Jun 2023 13:10:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BD84C433EF; Fri, 9 Jun 2023 13:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686316250; bh=20eZk8bTN2/b1Z3qUyGe3nCyzXZWXRuVMW5ABvA38Mw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uE6bq2E5O2sg28rWqjSlxmlOB4NMF5xAXptBceQzX69Dupew9yaCWvU3FCguEur8A +9NpupQoY7+wgD5fQs/q3fzwG4zdCv+Ez4rQxy/zB1FlNDwvGuaVF1/P8qTGmNz9ui aVOtYv8fJAKz6xJ0BKUIvbONldSV0Po6kvml4i54= Date: Fri, 9 Jun 2023 15:10:48 +0200 From: Greg Kroah-Hartman To: Jeff Layton Cc: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Bob Peterson , Andreas Gruenbacher , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Ruihan Li , Suren Baghdasaryan , Sebastian Reichel , Wolfram Sang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org Subject: Re: [PATCH 0/9] fs: add some missing ctime updates Message-ID: <2023060931-magazine-nickname-f386@gregkh> References: <20230609125023.399942-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609125023.399942-1-jlayton@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 09, 2023 at 08:50:14AM -0400, Jeff Layton wrote: > While working on a patch series to change how we handle the ctime, I > found a number of places that update the mtime without a corresponding > ctime update. POSIX requires that when the mtime is updated that the > ctime also be updated. > > Note that these are largely untested other than for compilation, so > please review carefully. These are a preliminary set for the upcoming > rework of how we handle the ctime. > > None of these seem to be very crucial, but it would be nice if > various maintainers could pick these up for v6.5. Please let me know if > you do. > > Jeff Layton (9): > ibmvmc: update ctime in conjunction with mtime on write > usb: update the ctime as well when updating mtime after an ioctl > autofs: set ctime as well when mtime changes on a dir > bfs: update ctime in addition to mtime when adding entries > efivarfs: update ctime when mtime changes on a write > exfat: ensure that ctime is updated whenever the mtime is > gfs2: update ctime when quota is updated > apparmor: update ctime whenever the mtime changes on an inode > cifs: update the ctime on a partial page write > > drivers/misc/ibmvmc.c | 2 +- > drivers/usb/core/devio.c | 16 ++++++++-------- > fs/autofs/root.c | 6 +++--- > fs/bfs/dir.c | 2 +- > fs/efivarfs/file.c | 2 +- > fs/exfat/namei.c | 8 ++++---- > fs/gfs2/quota.c | 2 +- > fs/smb/client/file.c | 2 +- > security/apparmor/apparmorfs.c | 7 +++++-- > security/apparmor/policy_unpack.c | 11 +++++++---- > 10 files changed, 32 insertions(+), 26 deletions(-) > > -- > 2.40.1 > All of these need commit log messages, didn't checkpatch warn you about that? thanks, greg k-h