From: Andi Shyti <andi.shyti@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: mpc: Use of_property_read_reg() to parse "reg"
Date: Sat, 10 Jun 2023 11:36:25 +0200 [thread overview]
Message-ID: <20230610093625.gvgbt7g4xvnuuog6@intel.intel> (raw)
In-Reply-To: <20230609183044.1764951-1-robh@kernel.org>
Hi Rob,
On Fri, Jun 09, 2023 at 12:30:44PM -0600, Rob Herring wrote:
> Use the recently added of_property_read_reg() helper to get the
> untranslated "reg" address value.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/i2c/busses/i2c-mpc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> index cfd074ee6d54..595dce9218ad 100644
> --- a/drivers/i2c/busses/i2c-mpc.c
> +++ b/drivers/i2c/busses/i2c-mpc.c
> @@ -316,9 +316,10 @@ static void mpc_i2c_setup_512x(struct device_node *node,
> if (node_ctrl) {
> ctrl = of_iomap(node_ctrl, 0);
> if (ctrl) {
> + u64 addr;
> /* Interrupt enable bits for i2c-0/1/2: bit 24/26/28 */
> - pval = of_get_property(node, "reg", NULL);
> - idx = (*pval & 0xff) / 0x20;
> + of_property_read_reg(node, 0, &addr, NULL);
because of_property_read_reg() can return error, can we check
also the error value here?
Thanks,
Andi
> + idx = (addr & 0xff) / 0x20;
> setbits32(ctrl, 1 << (24 + idx * 2));
> iounmap(ctrl);
> }
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-06-10 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 18:30 [PATCH] i2c: mpc: Use of_property_read_reg() to parse "reg" Rob Herring
2023-06-10 9:36 ` Andi Shyti [this message]
2023-06-12 19:27 ` Rob Herring
2023-06-12 21:08 ` Andi Shyti
2023-06-12 21:26 ` Rob Herring
2023-06-14 8:36 ` Wolfram Sang
2023-06-21 16:44 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230610093625.gvgbt7g4xvnuuog6@intel.intel \
--to=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).