* [PATCH v2] firmware: arm_ffa: fix ffa_notification_info_get()
@ 2024-03-11 11:07 Jens Wiklander
2024-03-11 14:45 ` Sudeep Holla
2024-03-26 14:50 ` Sudeep Holla
0 siblings, 2 replies; 3+ messages in thread
From: Jens Wiklander @ 2024-03-11 11:07 UTC (permalink / raw
To: linux-kernel, linux-arm-kernel, Sudeep Holla
Cc: Marc Bonnici, Olivier Deprez, Lorenzo Pieralisi, Jens Wiklander
FFA_NOTIFICATION_INFO_GET retrieves information about pending
notifications. Notifications can be either global or per VCPU. Global
notifications are reported with the partition ID only in the list of
endpoints with pending notifications. ffa_notification_info_get()
incorrectly expect no ID at all for global notifications. Fix this by
checking for 1 ID instead of 0.
Fixes: 3522be48d82b ("firmware: arm_ffa: Implement the NOTIFICATION_INFO_GET interface")
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
---
drivers/firmware/arm_ffa/driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c
index f2556a8e9401..9bc2e10381af 100644
--- a/drivers/firmware/arm_ffa/driver.c
+++ b/drivers/firmware/arm_ffa/driver.c
@@ -790,7 +790,7 @@ static void ffa_notification_info_get(void)
part_id = packed_id_list[ids_processed++];
- if (!ids_count[list]) { /* Global Notification */
+ if (ids_count[list] == 1) { /* Global Notification */
__do_sched_recv_cb(part_id, 0, false);
continue;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] firmware: arm_ffa: fix ffa_notification_info_get()
2024-03-11 11:07 [PATCH v2] firmware: arm_ffa: fix ffa_notification_info_get() Jens Wiklander
@ 2024-03-11 14:45 ` Sudeep Holla
2024-03-26 14:50 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2024-03-11 14:45 UTC (permalink / raw
To: Jens Wiklander
Cc: linux-kernel, linux-arm-kernel, Sudeep Holla, Marc Bonnici,
Olivier Deprez, Lorenzo Pieralisi
On Mon, Mar 11, 2024 at 12:07:00PM +0100, Jens Wiklander wrote:
> FFA_NOTIFICATION_INFO_GET retrieves information about pending
> notifications. Notifications can be either global or per VCPU. Global
> notifications are reported with the partition ID only in the list of
> endpoints with pending notifications. ffa_notification_info_get()
> incorrectly expect no ID at all for global notifications. Fix this by
> checking for 1 ID instead of 0.
>
LGTM, will queue it at -rc1 as fix.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] firmware: arm_ffa: fix ffa_notification_info_get()
2024-03-11 11:07 [PATCH v2] firmware: arm_ffa: fix ffa_notification_info_get() Jens Wiklander
2024-03-11 14:45 ` Sudeep Holla
@ 2024-03-26 14:50 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2024-03-26 14:50 UTC (permalink / raw
To: linux-kernel, linux-arm-kernel, Jens Wiklander
Cc: Sudeep Holla, Marc Bonnici, Olivier Deprez, Lorenzo Pieralisi
On Mon, 11 Mar 2024 12:07:00 +0100, Jens Wiklander wrote:
> FFA_NOTIFICATION_INFO_GET retrieves information about pending
> notifications. Notifications can be either global or per VCPU. Global
> notifications are reported with the partition ID only in the list of
> endpoints with pending notifications. ffa_notification_info_get()
> incorrectly expect no ID at all for global notifications. Fix this by
> checking for 1 ID instead of 0.
>
> [...]
Applied to sudeep.holla/linux (for-next/ffa/fixes), thanks!
[1/1] firmware: arm_ffa: fix ffa_notification_info_get()
https://git.kernel.org/sudeep.holla/c/1a4bd2b128fb
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-26 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-11 11:07 [PATCH v2] firmware: arm_ffa: fix ffa_notification_info_get() Jens Wiklander
2024-03-11 14:45 ` Sudeep Holla
2024-03-26 14:50 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).