From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org,
"Ayush Sawal" <ayush.sawal@chelsio.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Mirko Lindner" <mlindner@marvell.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David Ahern" <dsahern@kernel.org>,
"Boris Pismenny" <borisp@nvidia.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Dragos Tatulea" <dtatulea@nvidia.com>,
"Maxim Mikityanskiy" <maxtram95@gmail.com>,
"Sabrina Dubroca" <sd@queasysnail.net>,
"Simon Horman" <horms@kernel.org>,
"Yunsheng Lin" <linyunsheng@huawei.com>,
"Ahelenia Ziemiańska" <nabijaczleweli@nabijaczleweli.xyz>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"David Howells" <dhowells@redhat.com>,
"Florian Westphal" <fw@strlen.de>,
"Aleksander Lobakin" <aleksander.lobakin@intel.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Johannes Berg" <johannes.berg@intel.com>,
"Liang Chen" <liangchen.linux@gmail.com>
Subject: Re: [PATCH net-next v3 0/3] Minor cleanups to skb frag ref/unref
Date: Tue, 2 Apr 2024 19:10:29 -0700 [thread overview]
Message-ID: <20240402191029.321b1609@kernel.org> (raw)
In-Reply-To: <20240401215042.1877541-1-almasrymina@google.com>
On Mon, 1 Apr 2024 14:50:36 -0700 Mina Almasry wrote:
> This series is largely motivated by a recent discussion where there was
> some confusion on how to properly ref/unref pp pages vs non pp pages:
>
> https://lore.kernel.org/netdev/CAHS8izOoO-EovwMwAm9tLYetwikNPxC0FKyVGu1TPJWSz4bGoA@mail.gmail.com/T/#t
>
> There is some subtely there because pp uses page->pp_ref_count for
> refcounting, while non-pp uses get_page()/put_page() for ref counting.
> Getting the refcounting pairs wrong can lead to kernel crash.
>
> Additionally currently it may not be obvious to skb users unaware of
> page pool internals how to properly acquire a ref on a pp frag. It
> requires checking of skb->pp_recycle & is_pp_page() to make the correct
> calls and may require some handling at the call site aware of arguable pp
> internals.
I concluded that Olek's series as good to go in, so you gotta rebase.
--
pw-bot: cr
prev parent reply other threads:[~2024-04-03 2:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 21:50 [PATCH net-next v3 0/3] Minor cleanups to skb frag ref/unref Mina Almasry
2024-04-01 21:50 ` [PATCH net-next v3 1/3] net: make napi_frag_unref reuse skb_page_unref Mina Almasry
2024-04-01 21:50 ` [PATCH net-next v3 2/3] net: mirror skb frag ref/unref helpers Mina Almasry
2024-04-01 21:50 ` [PATCH net-next v3 3/3] net: remove napi_frag_unref Mina Almasry
2024-04-03 2:10 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402191029.321b1609@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=ayush.sawal@chelsio.com \
--cc=borisp@nvidia.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dsahern@kernel.org \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=johannes.berg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=liangchen.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=lorenzo@kernel.org \
--cc=maxtram95@gmail.com \
--cc=mlindner@marvell.com \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=steffen.klassert@secunet.com \
--cc=stephen@networkplumber.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).