* [PATCH 0/2] phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180
@ 2024-04-01 18:22 Danila Tikhonov
2024-04-01 18:22 ` [PATCH 1/2] dt-bindings: phy: qmp-ufs: Fix PHY " Danila Tikhonov
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Danila Tikhonov @ 2024-04-01 18:22 UTC (permalink / raw
To: andersson, konrad.dybcio, vkoul, kishon, robh,
krzysztof.kozlowski+dt, conor+dt, cros-qcom-dts-watchers,
manivannan.sadhasivam, davidwronek
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel,
Danila Tikhonov
This series of patches is based on the series from Manivannan:
https://lore.kernel.org/all/20240131-ufs-phy-clock-v3-0-58a49d2f4605@linaro.org/
Patch from David adding a UFS nodes for SC7180(SM7125):
https://lore.kernel.org/all/20240121-sm7125-upstream-v4-6-f7d1212c8ebb@gmail.com/
The patch submitted by David and a series of patches submitted by Manivannan
were both applied at approximately the same time. As a result, David's patch
did not include this change.
To: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
To: Kishon Vijay Abraham I <kishon@kernel.org>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
To: Conor Dooley <conor+dt@kernel.org>
To: cros-qcom-dts-watchers@chromium.org
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: David Wronek <davidwronek@gmail.com>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-phy@lists.infradead.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Danila Tikhonov (2):
dt-bindings: phy: qmp-ufs: Fix PHY clocks for SC7180
arm64: dts: qcom: sc7180: Fix UFS PHY clocks
.../bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 1 +
arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++++++---
2 files changed, 7 insertions(+), 3 deletions(-)
--
2.44.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] dt-bindings: phy: qmp-ufs: Fix PHY clocks for SC7180
2024-04-01 18:22 [PATCH 0/2] phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180 Danila Tikhonov
@ 2024-04-01 18:22 ` Danila Tikhonov
2024-04-02 16:15 ` Rob Herring
2024-04-03 13:53 ` Manivannan Sadhasivam
2024-04-01 18:22 ` [PATCH 2/2] arm64: dts: qcom: sc7180: Fix UFS PHY clocks Danila Tikhonov
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Danila Tikhonov @ 2024-04-01 18:22 UTC (permalink / raw
To: andersson, konrad.dybcio, vkoul, kishon, robh,
krzysztof.kozlowski+dt, conor+dt, cros-qcom-dts-watchers,
manivannan.sadhasivam, davidwronek
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel,
Danila Tikhonov
QMP UFS PHY used in SC7180 requires 3 clocks:
* ref - 19.2MHz reference clock from RPMh
* ref_aux - Auxiliary reference clock from GCC
* qref - QREF clock from GCC
This change obviously breaks the ABI, but it is inevitable since the
clock topology needs to be accurately described in the binding.
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
---
.../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
index 91a6cc38ff7f..a79fde9a8cdf 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
@@ -86,6 +86,7 @@ allOf:
enum:
- qcom,msm8998-qmp-ufs-phy
- qcom,sa8775p-qmp-ufs-phy
+ - qcom,sc7180-qmp-ufs-phy
- qcom,sc7280-qmp-ufs-phy
- qcom,sc8180x-qmp-ufs-phy
- qcom,sc8280xp-qmp-ufs-phy
--
2.44.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: sc7180: Fix UFS PHY clocks
2024-04-01 18:22 [PATCH 0/2] phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180 Danila Tikhonov
2024-04-01 18:22 ` [PATCH 1/2] dt-bindings: phy: qmp-ufs: Fix PHY " Danila Tikhonov
@ 2024-04-01 18:22 ` Danila Tikhonov
2024-04-01 19:28 ` Dmitry Baryshkov
2024-04-03 13:54 ` Manivannan Sadhasivam
2024-04-06 9:19 ` (subset) [PATCH 0/2] phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180 Vinod Koul
2024-04-08 2:17 ` Bjorn Andersson
3 siblings, 2 replies; 9+ messages in thread
From: Danila Tikhonov @ 2024-04-01 18:22 UTC (permalink / raw
To: andersson, konrad.dybcio, vkoul, kishon, robh,
krzysztof.kozlowski+dt, conor+dt, cros-qcom-dts-watchers,
manivannan.sadhasivam, davidwronek
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel,
Danila Tikhonov
QMP PHY used in SC7180 requires 3 clocks:
* ref - 19.2MHz reference clock from RPMh
* ref_aux - Auxiliary reference clock from GCC
* qref - QREF clock from GCC
While at it, let's move 'clocks' property before 'clock-names' to match
the style used commonly.
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 2b481e20ae38..5c9ec8047f00 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1585,9 +1585,12 @@ ufs_mem_phy: phy@1d87000 {
compatible = "qcom,sc7180-qmp-ufs-phy",
"qcom,sm7150-qmp-ufs-phy";
reg = <0 0x01d87000 0 0x1000>;
- clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
- <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
- clock-names = "ref", "ref_aux";
+ clocks = <&rpmhcc RPMH_CXO_CLK>,
+ <&gcc GCC_UFS_PHY_PHY_AUX_CLK>,
+ <&gcc GCC_UFS_MEM_CLKREF_CLK>;
+ clock-names = "ref",
+ "ref_aux",
+ "qref";
power-domains = <&gcc UFS_PHY_GDSC>;
resets = <&ufs_mem_hc 0>;
reset-names = "ufsphy";
--
2.44.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sc7180: Fix UFS PHY clocks
2024-04-01 18:22 ` [PATCH 2/2] arm64: dts: qcom: sc7180: Fix UFS PHY clocks Danila Tikhonov
@ 2024-04-01 19:28 ` Dmitry Baryshkov
2024-04-03 13:54 ` Manivannan Sadhasivam
1 sibling, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2024-04-01 19:28 UTC (permalink / raw
To: Danila Tikhonov
Cc: andersson, konrad.dybcio, vkoul, kishon, robh,
krzysztof.kozlowski+dt, conor+dt, cros-qcom-dts-watchers,
manivannan.sadhasivam, davidwronek, linux-arm-msm, linux-phy,
devicetree, linux-kernel
On Mon, 1 Apr 2024 at 21:23, Danila Tikhonov <danila@jiaxyga.com> wrote:
>
> QMP PHY used in SC7180 requires 3 clocks:
>
> * ref - 19.2MHz reference clock from RPMh
> * ref_aux - Auxiliary reference clock from GCC
> * qref - QREF clock from GCC
>
> While at it, let's move 'clocks' property before 'clock-names' to match
> the style used commonly.
>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: qmp-ufs: Fix PHY clocks for SC7180
2024-04-01 18:22 ` [PATCH 1/2] dt-bindings: phy: qmp-ufs: Fix PHY " Danila Tikhonov
@ 2024-04-02 16:15 ` Rob Herring
2024-04-03 13:53 ` Manivannan Sadhasivam
1 sibling, 0 replies; 9+ messages in thread
From: Rob Herring @ 2024-04-02 16:15 UTC (permalink / raw
To: Danila Tikhonov
Cc: davidwronek, manivannan.sadhasivam, krzysztof.kozlowski+dt,
linux-arm-msm, konrad.dybcio, linux-phy, conor+dt, kishon,
devicetree, andersson, vkoul, linux-kernel,
cros-qcom-dts-watchers
On Mon, 01 Apr 2024 21:22:39 +0300, Danila Tikhonov wrote:
> QMP UFS PHY used in SC7180 requires 3 clocks:
>
> * ref - 19.2MHz reference clock from RPMh
> * ref_aux - Auxiliary reference clock from GCC
> * qref - QREF clock from GCC
>
> This change obviously breaks the ABI, but it is inevitable since the
> clock topology needs to be accurately described in the binding.
>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---
> .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: qmp-ufs: Fix PHY clocks for SC7180
2024-04-01 18:22 ` [PATCH 1/2] dt-bindings: phy: qmp-ufs: Fix PHY " Danila Tikhonov
2024-04-02 16:15 ` Rob Herring
@ 2024-04-03 13:53 ` Manivannan Sadhasivam
1 sibling, 0 replies; 9+ messages in thread
From: Manivannan Sadhasivam @ 2024-04-03 13:53 UTC (permalink / raw
To: Danila Tikhonov
Cc: andersson, konrad.dybcio, vkoul, kishon, robh,
krzysztof.kozlowski+dt, conor+dt, cros-qcom-dts-watchers,
davidwronek, linux-arm-msm, linux-phy, devicetree, linux-kernel
On Mon, Apr 01, 2024 at 09:22:39PM +0300, Danila Tikhonov wrote:
> QMP UFS PHY used in SC7180 requires 3 clocks:
>
> * ref - 19.2MHz reference clock from RPMh
> * ref_aux - Auxiliary reference clock from GCC
> * qref - QREF clock from GCC
>
> This change obviously breaks the ABI, but it is inevitable since the
> clock topology needs to be accurately described in the binding.
>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> index 91a6cc38ff7f..a79fde9a8cdf 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> @@ -86,6 +86,7 @@ allOf:
> enum:
> - qcom,msm8998-qmp-ufs-phy
> - qcom,sa8775p-qmp-ufs-phy
> + - qcom,sc7180-qmp-ufs-phy
> - qcom,sc7280-qmp-ufs-phy
> - qcom,sc8180x-qmp-ufs-phy
> - qcom,sc8280xp-qmp-ufs-phy
> --
> 2.44.0
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sc7180: Fix UFS PHY clocks
2024-04-01 18:22 ` [PATCH 2/2] arm64: dts: qcom: sc7180: Fix UFS PHY clocks Danila Tikhonov
2024-04-01 19:28 ` Dmitry Baryshkov
@ 2024-04-03 13:54 ` Manivannan Sadhasivam
1 sibling, 0 replies; 9+ messages in thread
From: Manivannan Sadhasivam @ 2024-04-03 13:54 UTC (permalink / raw
To: Danila Tikhonov
Cc: andersson, konrad.dybcio, vkoul, kishon, robh,
krzysztof.kozlowski+dt, conor+dt, cros-qcom-dts-watchers,
davidwronek, linux-arm-msm, linux-phy, devicetree, linux-kernel
On Mon, Apr 01, 2024 at 09:22:40PM +0300, Danila Tikhonov wrote:
> QMP PHY used in SC7180 requires 3 clocks:
>
> * ref - 19.2MHz reference clock from RPMh
> * ref_aux - Auxiliary reference clock from GCC
> * qref - QREF clock from GCC
>
> While at it, let's move 'clocks' property before 'clock-names' to match
> the style used commonly.
>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 2b481e20ae38..5c9ec8047f00 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1585,9 +1585,12 @@ ufs_mem_phy: phy@1d87000 {
> compatible = "qcom,sc7180-qmp-ufs-phy",
> "qcom,sm7150-qmp-ufs-phy";
> reg = <0 0x01d87000 0 0x1000>;
> - clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
> - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
> - clock-names = "ref", "ref_aux";
> + clocks = <&rpmhcc RPMH_CXO_CLK>,
> + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>,
> + <&gcc GCC_UFS_MEM_CLKREF_CLK>;
> + clock-names = "ref",
> + "ref_aux",
> + "qref";
> power-domains = <&gcc UFS_PHY_GDSC>;
> resets = <&ufs_mem_hc 0>;
> reset-names = "ufsphy";
> --
> 2.44.0
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH 0/2] phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180
2024-04-01 18:22 [PATCH 0/2] phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180 Danila Tikhonov
2024-04-01 18:22 ` [PATCH 1/2] dt-bindings: phy: qmp-ufs: Fix PHY " Danila Tikhonov
2024-04-01 18:22 ` [PATCH 2/2] arm64: dts: qcom: sc7180: Fix UFS PHY clocks Danila Tikhonov
@ 2024-04-06 9:19 ` Vinod Koul
2024-04-08 2:17 ` Bjorn Andersson
3 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2024-04-06 9:19 UTC (permalink / raw
To: andersson, konrad.dybcio, kishon, robh, krzysztof.kozlowski+dt,
conor+dt, cros-qcom-dts-watchers, manivannan.sadhasivam,
davidwronek, Danila Tikhonov
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel
On Mon, 01 Apr 2024 21:22:38 +0300, Danila Tikhonov wrote:
> This series of patches is based on the series from Manivannan:
> https://lore.kernel.org/all/20240131-ufs-phy-clock-v3-0-58a49d2f4605@linaro.org/
>
> Patch from David adding a UFS nodes for SC7180(SM7125):
> https://lore.kernel.org/all/20240121-sm7125-upstream-v4-6-f7d1212c8ebb@gmail.com/
>
> The patch submitted by David and a series of patches submitted by Manivannan
> were both applied at approximately the same time. As a result, David's patch
> did not include this change.
>
> [...]
Applied, thanks!
[1/2] dt-bindings: phy: qmp-ufs: Fix PHY clocks for SC7180
commit: 7c1f42967b75bdcd0640c52d37d58d8dd122989b
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH 0/2] phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180
2024-04-01 18:22 [PATCH 0/2] phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180 Danila Tikhonov
` (2 preceding siblings ...)
2024-04-06 9:19 ` (subset) [PATCH 0/2] phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180 Vinod Koul
@ 2024-04-08 2:17 ` Bjorn Andersson
3 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2024-04-08 2:17 UTC (permalink / raw
To: konrad.dybcio, vkoul, kishon, robh, krzysztof.kozlowski+dt,
conor+dt, cros-qcom-dts-watchers, manivannan.sadhasivam,
davidwronek, Danila Tikhonov
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel
On Mon, 01 Apr 2024 21:22:38 +0300, Danila Tikhonov wrote:
> This series of patches is based on the series from Manivannan:
> https://lore.kernel.org/all/20240131-ufs-phy-clock-v3-0-58a49d2f4605@linaro.org/
>
> Patch from David adding a UFS nodes for SC7180(SM7125):
> https://lore.kernel.org/all/20240121-sm7125-upstream-v4-6-f7d1212c8ebb@gmail.com/
>
> The patch submitted by David and a series of patches submitted by Manivannan
> were both applied at approximately the same time. As a result, David's patch
> did not include this change.
>
> [...]
Applied, thanks!
[2/2] arm64: dts: qcom: sc7180: Fix UFS PHY clocks
commit: 32198408f825a8ca3da4784d4c280847075990e9
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-04-08 2:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-01 18:22 [PATCH 0/2] phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180 Danila Tikhonov
2024-04-01 18:22 ` [PATCH 1/2] dt-bindings: phy: qmp-ufs: Fix PHY " Danila Tikhonov
2024-04-02 16:15 ` Rob Herring
2024-04-03 13:53 ` Manivannan Sadhasivam
2024-04-01 18:22 ` [PATCH 2/2] arm64: dts: qcom: sc7180: Fix UFS PHY clocks Danila Tikhonov
2024-04-01 19:28 ` Dmitry Baryshkov
2024-04-03 13:54 ` Manivannan Sadhasivam
2024-04-06 9:19 ` (subset) [PATCH 0/2] phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180 Vinod Koul
2024-04-08 2:17 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).