From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Margolin, Michael" <mrgolin@amazon.com>
Cc: Tao Liu <ltao@redhat.com>, Gal Pressman <gal.pressman@linux.dev>,
sleybo@amazon.com, leon@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: Implementing .shutdown method for efa module
Date: Wed, 3 Apr 2024 12:44:14 -0300 [thread overview]
Message-ID: <20240403154414.GD1363414@ziepe.ca> (raw)
In-Reply-To: <0e7dddff-d7f3-4617-83e6-f255449a282b@amazon.com>
On Mon, Apr 01, 2024 at 04:23:32PM +0300, Margolin, Michael wrote:
> Jason
>
> Thanks for your response, efa_remove() is performing reset to the device
> which should stop all DMA from the device.
>
> Except skipping cleanups that are unnecessary for shutdown flow are there
> any other reasons to prefer a separate function for shutdown?
Yes you should skip "cleanups" like removing the IB device and
otherwise as there is a risk of system hang/deadlock in a shutdown
handler context.
Jason
next prev parent reply other threads:[~2024-04-03 15:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 2:10 Implementing .shutdown method for efa module Tao Liu
2024-03-25 8:06 ` Gal Pressman
2024-03-26 1:38 ` Tao Liu
2024-03-26 12:34 ` Margolin, Michael
2024-03-26 15:32 ` Jason Gunthorpe
2024-04-01 13:23 ` Margolin, Michael
2024-04-03 15:44 ` Jason Gunthorpe [this message]
2024-04-04 6:54 ` Margolin, Michael
2024-04-25 3:27 ` Tao Liu
2024-03-29 11:58 ` Tao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403154414.GD1363414@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=gal.pressman@linux.dev \
--cc=kexec@lists.infradead.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ltao@redhat.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).