* [PATCH] fs/dcache: Re-use value stored to dentry->d_flags instead of re-reading
@ 2024-04-03 2:10 linke li
2024-04-03 11:01 ` Jan Kara
2024-04-09 10:29 ` Christian Brauner
0 siblings, 2 replies; 3+ messages in thread
From: linke li @ 2024-04-03 2:10 UTC (permalink / raw
Cc: xujianhao01, linke li, Alexander Viro, Christian Brauner,
Jan Kara, linux-fsdevel, linux-kernel
Currently, the __d_clear_type_and_inode() writes the value flags to
dentry->d_flags, then immediately re-reads it in order to use it in a if
statement. This re-read is useless because no other update to
dentry->d_flags can occur at this point.
This commit therefore re-use flags in the if statement instead of
re-reading dentry->d_flags.
Signed-off-by: linke li <lilinke99@qq.com>
---
fs/dcache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index b813528fb147..79da415d7995 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -355,7 +355,7 @@ static inline void __d_clear_type_and_inode(struct dentry *dentry)
flags &= ~DCACHE_ENTRY_TYPE;
WRITE_ONCE(dentry->d_flags, flags);
dentry->d_inode = NULL;
- if (dentry->d_flags & DCACHE_LRU_LIST)
+ if (flags & DCACHE_LRU_LIST)
this_cpu_inc(nr_dentry_negative);
}
--
2.39.3 (Apple Git-146)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/dcache: Re-use value stored to dentry->d_flags instead of re-reading
2024-04-03 2:10 [PATCH] fs/dcache: Re-use value stored to dentry->d_flags instead of re-reading linke li
@ 2024-04-03 11:01 ` Jan Kara
2024-04-09 10:29 ` Christian Brauner
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2024-04-03 11:01 UTC (permalink / raw
To: linke li
Cc: xujianhao01, Alexander Viro, Christian Brauner, Jan Kara,
linux-fsdevel, linux-kernel
On Wed 03-04-24 10:10:08, linke li wrote:
> Currently, the __d_clear_type_and_inode() writes the value flags to
> dentry->d_flags, then immediately re-reads it in order to use it in a if
> statement. This re-read is useless because no other update to
> dentry->d_flags can occur at this point.
>
> This commit therefore re-use flags in the if statement instead of
> re-reading dentry->d_flags.
>
> Signed-off-by: linke li <lilinke99@qq.com>
Indeed, this seems pointless and actually a bit confusing. Feel free to
add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/dcache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/dcache.c b/fs/dcache.c
> index b813528fb147..79da415d7995 100644
> --- a/fs/dcache.c
> +++ b/fs/dcache.c
> @@ -355,7 +355,7 @@ static inline void __d_clear_type_and_inode(struct dentry *dentry)
> flags &= ~DCACHE_ENTRY_TYPE;
> WRITE_ONCE(dentry->d_flags, flags);
> dentry->d_inode = NULL;
> - if (dentry->d_flags & DCACHE_LRU_LIST)
> + if (flags & DCACHE_LRU_LIST)
> this_cpu_inc(nr_dentry_negative);
> }
>
> --
> 2.39.3 (Apple Git-146)
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/dcache: Re-use value stored to dentry->d_flags instead of re-reading
2024-04-03 2:10 [PATCH] fs/dcache: Re-use value stored to dentry->d_flags instead of re-reading linke li
2024-04-03 11:01 ` Jan Kara
@ 2024-04-09 10:29 ` Christian Brauner
1 sibling, 0 replies; 3+ messages in thread
From: Christian Brauner @ 2024-04-09 10:29 UTC (permalink / raw
To: linke li
Cc: Christian Brauner, xujianhao01, Alexander Viro, Jan Kara,
linux-fsdevel, linux-kernel
On Wed, 03 Apr 2024 10:10:08 +0800, linke li wrote:
> Currently, the __d_clear_type_and_inode() writes the value flags to
> dentry->d_flags, then immediately re-reads it in order to use it in a if
> statement. This re-read is useless because no other update to
> dentry->d_flags can occur at this point.
>
> This commit therefore re-use flags in the if statement instead of
> re-reading dentry->d_flags.
>
> [...]
Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc
[1/1] fs/dcache: Re-use value stored to dentry->d_flags instead of re-reading
https://git.kernel.org/vfs/vfs/c/8bfb40be31dd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-09 10:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-03 2:10 [PATCH] fs/dcache: Re-use value stored to dentry->d_flags instead of re-reading linke li
2024-04-03 11:01 ` Jan Kara
2024-04-09 10:29 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).