* [PATCH][next] ASoC: codecs: tas2780: remove redundant assignments to variable ret
@ 2024-04-11 8:33 Colin Ian King
2024-04-11 22:57 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-04-11 8:33 UTC (permalink / raw
To: Shenghao Ding, Kevin Lu, Baojun Xu, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-sound
Cc: kernel-janitors, linux-kernel
Variable ret is being assigned a value that is never read in a couple
of places. The variable is being re-assigned later on. The assignments
are redundant and can be removed.
Cleans up clang scan build warning:
sound/soc/codecs/tas2780.c:84:2: warning: Value stored to 'ret' is
never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
sound/soc/codecs/tas2780.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/codecs/tas2780.c b/sound/soc/codecs/tas2780.c
index 41076be23854..972e8ea5ebde 100644
--- a/sound/soc/codecs/tas2780.c
+++ b/sound/soc/codecs/tas2780.c
@@ -71,7 +71,7 @@ static int tas2780_codec_resume(struct snd_soc_component *component)
{
struct tas2780_priv *tas2780 =
snd_soc_component_get_drvdata(component);
- int ret = 0;
+ int ret;
ret = snd_soc_component_update_bits(component, TAS2780_PWR_CTRL,
TAS2780_PWR_CTRL_MASK, TAS2780_PWR_CTRL_ACTIVE);
@@ -81,7 +81,6 @@ static int tas2780_codec_resume(struct snd_soc_component *component)
__func__, ret);
goto err;
}
- ret = 0;
regcache_cache_only(tas2780->regmap, false);
ret = regcache_sync(tas2780->regmap);
err:
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] ASoC: codecs: tas2780: remove redundant assignments to variable ret
2024-04-11 8:33 [PATCH][next] ASoC: codecs: tas2780: remove redundant assignments to variable ret Colin Ian King
@ 2024-04-11 22:57 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2024-04-11 22:57 UTC (permalink / raw
To: Shenghao Ding, Kevin Lu, Baojun Xu, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-sound,
Colin Ian King
Cc: kernel-janitors, linux-kernel
On Thu, 11 Apr 2024 09:33:32 +0100, Colin Ian King wrote:
> Variable ret is being assigned a value that is never read in a couple
> of places. The variable is being re-assigned later on. The assignments
> are redundant and can be removed.
>
> Cleans up clang scan build warning:
> sound/soc/codecs/tas2780.c:84:2: warning: Value stored to 'ret' is
> never read [deadcode.DeadStores]
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: codecs: tas2780: remove redundant assignments to variable ret
commit: 1d165c5a1c85747bf48f37a80636a4a73e1576a1
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-11 22:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-11 8:33 [PATCH][next] ASoC: codecs: tas2780: remove redundant assignments to variable ret Colin Ian King
2024-04-11 22:57 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).