From: <shiju.jose@huawei.com>
To: <linux-cxl@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
<linux-mm@kvack.org>, <dan.j.williams@intel.com>,
<dave@stgolabs.net>, <jonathan.cameron@huawei.com>,
<dave.jiang@intel.com>, <alison.schofield@intel.com>,
<vishal.l.verma@intel.com>, <ira.weiny@intel.com>
Cc: <linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<david@redhat.com>, <Vilas.Sridharan@amd.com>,
<leo.duran@amd.com>, <Yazen.Ghannam@amd.com>,
<rientjes@google.com>, <jiaqiyan@google.com>,
<tony.luck@intel.com>, <Jon.Grimm@amd.com>,
<dave.hansen@linux.intel.com>, <rafael@kernel.org>,
<lenb@kernel.org>, <naoya.horiguchi@nec.com>,
<james.morse@arm.com>, <jthoughton@google.com>,
<somasundaram.a@hpe.com>, <erdemaktas@google.com>,
<pgonda@google.com>, <duenwen@google.com>,
<mike.malvestuto@intel.com>, <gthelen@google.com>,
<wschwartz@amperecomputing.com>, <dferguson@amperecomputing.com>,
<wbs@os.amperecomputing.com>, <nifan.cxl@gmail.com>,
<yazen.ghannam@amd.com>, <tanxiaofei@huawei.com>,
<prime.zeng@hisilicon.com>, <kangkang.shen@futurewei.com>,
<wanghuiqiang@huawei.com>, <linuxarm@huawei.com>,
<shiju.jose@huawei.com>
Subject: [RFC PATCH v8 09/10] ras: scrub: Add scrub control attributes for ACPI RAS2
Date: Sat, 20 Apr 2024 00:47:18 +0800 [thread overview]
Message-ID: <20240419164720.1765-10-shiju.jose@huawei.com> (raw)
In-Reply-To: <20240419164720.1765-1-shiju.jose@huawei.com>
From: Shiju Jose <shiju.jose@huawei.com>
Add scrub control attributes for ACPI RAS2 patrol scrub feature.
Co-developed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
---
.../ABI/testing/sysfs-class-scrub-configure | 28 +++-
drivers/ras/memory_scrub.c | 131 ++++++++++++++++++
include/linux/memory_scrub.h | 8 ++
3 files changed, 165 insertions(+), 2 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-class-scrub-configure b/Documentation/ABI/testing/sysfs-class-scrub-configure
index 3ed77dbb00ad..7178776249f8 100644
--- a/Documentation/ABI/testing/sysfs-class-scrub-configure
+++ b/Documentation/ABI/testing/sysfs-class-scrub-configure
@@ -15,12 +15,21 @@ Description:
correspond to each scrub device registered with the
scrub subsystem.
-What: /sys/class/ras/rasX/scrub/name
+What: /sys/class/ras/rasX/scrub/addr_range_base
Date: March 2024
KernelVersion: 6.9
Contact: linux-kernel@vger.kernel.org
Description:
- (RO) name of the memory scrubber
+ (RW) The base of the address range of the memory region
+ to be scrubbed (on-demand scrubbing).
+
+What: /sys/class/ras/rasX/scrub/addr_range_size
+Date: March 2024
+KernelVersion: 6.9
+Contact: linux-kernel@vger.kernel.org
+Description:
+ (RW) The size of the address range of the memory region
+ to be scrubbed (on-demand scrubbing).
What: /sys/class/ras/rasX/scrub/enable_background
Date: March 2024
@@ -29,6 +38,21 @@ Contact: linux-kernel@vger.kernel.org
Description:
(RW) Enable/Disable background(patrol) scrubbing if supported.
+What: /sys/class/ras/rasX/scrub/enable_on_demand
+Date: March 2024
+KernelVersion: 6.9
+Contact: linux-kernel@vger.kernel.org
+Description:
+ (RW) Enable/Disable on-demand scrubbing the memory region
+ if supported.
+
+What: /sys/class/ras/rasX/scrub/name
+Date: March 2024
+KernelVersion: 6.9
+Contact: linux-kernel@vger.kernel.org
+Description:
+ (RO) name of the memory scrubber
+
What: /sys/class/ras/rasX/scrub/rate_available
Date: March 2024
KernelVersion: 6.9
diff --git a/drivers/ras/memory_scrub.c b/drivers/ras/memory_scrub.c
index 7e995380ec3a..ace6c59b8993 100755
--- a/drivers/ras/memory_scrub.c
+++ b/drivers/ras/memory_scrub.c
@@ -29,6 +29,83 @@ struct scrub_device {
};
#define to_scrub_device(d) container_of(d, struct scrub_device, dev)
+static ssize_t addr_range_base_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct scrub_device *scrub_dev = to_scrub_device(dev);
+ u64 base, size;
+ int ret;
+
+ ret = scrub_dev->ops->read_range(dev, &base, &size);
+ if (ret)
+ return ret;
+
+ return sysfs_emit(buf, "0x%llx\n", base);
+}
+
+static ssize_t addr_range_size_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct scrub_device *scrub_dev = to_scrub_device(dev);
+ u64 base, size;
+ int ret;
+
+ ret = scrub_dev->ops->read_range(dev, &base, &size);
+ if (ret)
+ return ret;
+
+ return sysfs_emit(buf, "0x%llx\n", size);
+}
+
+static ssize_t addr_range_base_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t len)
+{
+ struct scrub_device *scrub_dev = to_scrub_device(dev);
+ u64 base, size;
+ int ret;
+
+ ret = scrub_dev->ops->read_range(dev, &base, &size);
+ if (ret)
+ return ret;
+
+ ret = kstrtou64(buf, 16, &base);
+ if (ret < 0)
+ return ret;
+
+ ret = scrub_dev->ops->write_range(dev, base, size);
+ if (ret)
+ return ret;
+
+ return len;
+}
+
+static ssize_t addr_range_size_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf,
+ size_t len)
+{
+ struct scrub_device *scrub_dev = to_scrub_device(dev);
+ u64 base, size;
+ int ret;
+
+ ret = scrub_dev->ops->read_range(dev, &base, &size);
+ if (ret)
+ return ret;
+
+ ret = kstrtou64(buf, 16, &size);
+ if (ret < 0)
+ return ret;
+
+ ret = scrub_dev->ops->write_range(dev, base, size);
+ if (ret)
+ return ret;
+
+ return len;
+}
+
static ssize_t enable_background_store(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t len)
@@ -62,6 +139,39 @@ static ssize_t enable_background_show(struct device *dev,
return sysfs_emit(buf, "%d\n", enable);
}
+static ssize_t enable_on_demand_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct scrub_device *scrub_dev = to_scrub_device(dev);
+ bool enable;
+ int ret;
+
+ ret = scrub_dev->ops->get_enabled_od(dev, &enable);
+ if (ret)
+ return ret;
+
+ return sysfs_emit(buf, "%d\n", enable);
+}
+
+static ssize_t enable_on_demand_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t len)
+{
+ struct scrub_device *scrub_dev = to_scrub_device(dev);
+ bool enable;
+ int ret;
+
+ ret = kstrtobool(buf, &enable);
+ if (ret < 0)
+ return ret;
+
+ ret = scrub_dev->ops->set_enabled_od(dev, enable);
+ if (ret)
+ return ret;
+
+ return len;
+}
+
static ssize_t name_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
@@ -122,13 +232,19 @@ static ssize_t rate_available_show(struct device *dev,
return sysfs_emit(buf, "0x%llx-0x%llx\n", min_sr, max_sr);
}
+DEVICE_ATTR_RW(addr_range_base);
+DEVICE_ATTR_RW(addr_range_size);
DEVICE_ATTR_RW(enable_background);
+DEVICE_ATTR_RW(enable_on_demand);
DEVICE_ATTR_RO(name);
DEVICE_ATTR_RW(rate);
DEVICE_ATTR_RO(rate_available);
static struct attribute *scrub_attrs[] = {
+ &dev_attr_addr_range_base.attr,
+ &dev_attr_addr_range_size.attr,
&dev_attr_enable_background.attr,
+ &dev_attr_enable_on_demand.attr,
&dev_attr_name.attr,
&dev_attr_rate.attr,
&dev_attr_rate_available.attr,
@@ -142,6 +258,14 @@ static umode_t scrub_attr_visible(struct kobject *kobj,
struct scrub_device *scrub_dev = to_scrub_device(dev);
const struct scrub_ops *ops = scrub_dev->ops;
+ if (a == &dev_attr_addr_range_base.attr ||
+ a == &dev_attr_addr_range_size.attr) {
+ if (ops->read_range && ops->write_range)
+ return a->mode;
+ if (ops->read_range)
+ return 0444;
+ return 0;
+ }
if (a == &dev_attr_enable_background.attr) {
if (ops->set_enabled_bg && ops->get_enabled_bg)
return a->mode;
@@ -149,6 +273,13 @@ static umode_t scrub_attr_visible(struct kobject *kobj,
return 0444;
return 0;
}
+ if (a == &dev_attr_enable_on_demand.attr) {
+ if (ops->set_enabled_od && ops->get_enabled_od)
+ return a->mode;
+ if (ops->get_enabled_od)
+ return 0444;
+ return 0;
+ }
if (a == &dev_attr_name.attr)
return ops->get_name ? a->mode : 0;
if (a == &dev_attr_rate_available.attr)
diff --git a/include/linux/memory_scrub.h b/include/linux/memory_scrub.h
index f0e1657a5072..d8edb48677c9 100755
--- a/include/linux/memory_scrub.h
+++ b/include/linux/memory_scrub.h
@@ -15,16 +15,24 @@ struct device;
/**
* struct scrub_ops - scrub device operations (all elements optional)
+ * @read_range: read base and offset of scrubbing range.
+ * @write_range: set the base and offset of the scrubbing range.
* @get_enabled_bg: check if currently performing background scrub.
* @set_enabled_bg: start or stop a bg-scrub.
+ * @get_enabled_od: check if currently performing on-demand scrub.
+ * @set_enabled_od: start or stop an on-demand scrub.
* @get_name: get the memory scrubber name.
* @rate_avail_range: retrieve limits on supported rates.
* @rate_read: read the scrub rate
* @rate_write: set the scrub rate
*/
struct scrub_ops {
+ int (*read_range)(struct device *dev, u64 *base, u64 *size);
+ int (*write_range)(struct device *dev, u64 base, u64 size);
int (*get_enabled_bg)(struct device *dev, bool *enable);
int (*set_enabled_bg)(struct device *dev, bool enable);
+ int (*get_enabled_od)(struct device *dev, bool *enable);
+ int (*set_enabled_od)(struct device *dev, bool enable);
int (*get_name)(struct device *dev, char *buf);
int (*rate_avail_range)(struct device *dev, u64 *min, u64 *max);
int (*rate_read)(struct device *dev, u64 *rate);
--
2.34.1
next prev parent reply other threads:[~2024-04-19 16:47 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 16:47 [RFC PATCH v8 00/10] ras: scrub: introduce subsystem + CXL/ACPI-RAS2 drivers shiju.jose
2024-04-19 16:47 ` [RFC PATCH v8 01/10] ras: scrub: Add scrub subsystem shiju.jose
2024-04-24 20:25 ` fan
2024-04-25 10:38 ` Shiju Jose
2024-04-25 10:15 ` Borislav Petkov
2024-04-25 18:11 ` Shiju Jose
2024-05-06 10:30 ` Borislav Petkov
2024-05-08 16:59 ` Shiju Jose
2024-05-08 17:20 ` Borislav Petkov
2024-05-08 17:44 ` Shiju Jose
2024-05-08 19:25 ` Borislav Petkov
2024-05-09 9:19 ` Jonathan Cameron
2024-05-09 15:52 ` Borislav Petkov
2024-05-09 20:03 ` Borislav Petkov
2024-05-09 21:21 ` Dan Williams
2024-05-09 21:51 ` Borislav Petkov
2024-05-09 22:59 ` Dan Williams
2024-05-10 9:25 ` Borislav Petkov
2024-05-10 17:13 ` Dan Williams
2024-05-11 10:17 ` Borislav Petkov
2024-05-17 11:15 ` Jonathan Cameron
2024-05-17 11:44 ` Jonathan Cameron
2024-05-21 8:06 ` Borislav Petkov
2024-05-22 9:40 ` Jonathan Cameron
2024-05-20 10:54 ` Shiju Jose
2024-05-20 11:58 ` Jonathan Cameron
2024-05-10 13:31 ` Jonathan Cameron
2024-05-09 21:47 ` Dan Williams
2024-05-10 9:03 ` Jonathan Cameron
2024-04-19 16:47 ` [RFC PATCH v8 02/10] cxl/mbox: Add GET_SUPPORTED_FEATURES mailbox command shiju.jose
2024-04-19 16:47 ` [RFC PATCH v8 03/10] cxl/mbox: Add GET_FEATURE " shiju.jose
2024-04-24 23:19 ` fan
2024-04-25 10:38 ` Shiju Jose
2024-04-19 16:47 ` [RFC PATCH v8 04/10] cxl/mbox: Add SET_FEATURE " shiju.jose
2024-04-25 17:26 ` fan
2024-04-19 16:47 ` [RFC PATCH v8 05/10] cxl/memscrub: Add CXL device patrol scrub control feature shiju.jose
2024-04-26 23:56 ` fan
2024-04-29 11:20 ` Shiju Jose
2024-04-29 12:21 ` Jonathan Cameron
2024-05-10 0:26 ` Dan Williams
2024-05-10 11:23 ` Jonathan Cameron
2024-04-19 16:47 ` [RFC PATCH v8 06/10] ACPICA: Add __free() based cleanup function for acpi_put_table shiju.jose
2024-04-19 18:06 ` Jonathan Cameron
2024-04-19 16:47 ` [RFC PATCH v8 07/10] platform: Add __free() based cleanup function for platform_device_put shiju.jose
2024-04-19 16:47 ` [RFC PATCH v8 08/10] ACPI:RAS2: Add ACPI RAS2 driver shiju.jose
2024-04-19 16:47 ` shiju.jose [this message]
2024-04-19 16:47 ` [RFC PATCH v8 10/10] ras: scrub: ACPI RAS2: Add memory " shiju.jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419164720.1765-10-shiju.jose@huawei.com \
--to=shiju.jose@huawei.com \
--cc=Jon.Grimm@amd.com \
--cc=Vilas.Sridharan@amd.com \
--cc=Yazen.Ghannam@amd.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=dferguson@amperecomputing.com \
--cc=duenwen@google.com \
--cc=erdemaktas@google.com \
--cc=gthelen@google.com \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=jiaqiyan@google.com \
--cc=jonathan.cameron@huawei.com \
--cc=jthoughton@google.com \
--cc=kangkang.shen@futurewei.com \
--cc=lenb@kernel.org \
--cc=leo.duran@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=mike.malvestuto@intel.com \
--cc=naoya.horiguchi@nec.com \
--cc=nifan.cxl@gmail.com \
--cc=pgonda@google.com \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
--cc=rientjes@google.com \
--cc=somasundaram.a@hpe.com \
--cc=tanxiaofei@huawei.com \
--cc=tony.luck@intel.com \
--cc=vishal.l.verma@intel.com \
--cc=wanghuiqiang@huawei.com \
--cc=wbs@os.amperecomputing.com \
--cc=wschwartz@amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).