LKML Archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 0/2] Add support for Lenovo Thinkbook 13X
@ 2024-04-23 16:23 Stefan Binding
  2024-04-23 16:23 ` [PATCH v1 1/2] ALSA: hda: cs35l41: Support Lenovo 13X laptop without _DSD Stefan Binding
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Stefan Binding @ 2024-04-23 16:23 UTC (permalink / raw
  To: Jaroslav Kysela, Takashi Iwai
  Cc: alsa-devel, linux-sound, linux-kernel, patches, Stefan Binding

This laptop does not contain _DSD required to support CS35L41 HDA.
To workaround this, add support for this laptop into the configuration
table in cs35l41_hda_property.c.
Also add the required entry into patch_realtek for this SSID.

Stefan Binding (2):
  ALSA: hda: cs35l41: Support Lenovo 13X laptop without _DSD
  ALSA: hda/realtek: Add quirks for Lenovo 13X

 sound/pci/hda/cs35l41_hda_property.c | 4 ++++
 sound/pci/hda/patch_realtek.c        | 2 ++
 2 files changed, 6 insertions(+)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v1 1/2] ALSA: hda: cs35l41: Support Lenovo 13X laptop without _DSD
  2024-04-23 16:23 [PATCH v1 0/2] Add support for Lenovo Thinkbook 13X Stefan Binding
@ 2024-04-23 16:23 ` Stefan Binding
  2024-04-23 16:23 ` [PATCH v1 2/2] ALSA: hda/realtek: Add quirks for Lenovo 13X Stefan Binding
  2024-04-24  8:35 ` [PATCH v1 0/2] Add support for Lenovo Thinkbook 13X Takashi Iwai
  2 siblings, 0 replies; 4+ messages in thread
From: Stefan Binding @ 2024-04-23 16:23 UTC (permalink / raw
  To: Jaroslav Kysela, Takashi Iwai
  Cc: alsa-devel, linux-sound, linux-kernel, patches, Stefan Binding

This laptop does not have the correct _DSD settings, so needs to
obtain its configuration from the configuration table.

Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
 sound/pci/hda/cs35l41_hda_property.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 6f82b28e26dd..be97e973accb 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -111,6 +111,8 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "10431F1F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 0, 0, 0 },
 	{ "10431F62", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "10433A60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
+	{ "17AA3865", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
+	{ "17AA3866", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
 	{ "17AA386F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
 	{ "17AA3877", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
 	{ "17AA3878", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
@@ -504,6 +506,8 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431F1F", generic_dsd_config },
 	{ "CSC3551", "10431F62", generic_dsd_config },
 	{ "CSC3551", "10433A60", generic_dsd_config },
+	{ "CSC3551", "17AA3865", generic_dsd_config },
+	{ "CSC3551", "17AA3866", generic_dsd_config },
 	{ "CSC3551", "17AA386F", generic_dsd_config },
 	{ "CSC3551", "17AA3877", generic_dsd_config },
 	{ "CSC3551", "17AA3878", generic_dsd_config },
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v1 2/2] ALSA: hda/realtek: Add quirks for Lenovo 13X
  2024-04-23 16:23 [PATCH v1 0/2] Add support for Lenovo Thinkbook 13X Stefan Binding
  2024-04-23 16:23 ` [PATCH v1 1/2] ALSA: hda: cs35l41: Support Lenovo 13X laptop without _DSD Stefan Binding
@ 2024-04-23 16:23 ` Stefan Binding
  2024-04-24  8:35 ` [PATCH v1 0/2] Add support for Lenovo Thinkbook 13X Takashi Iwai
  2 siblings, 0 replies; 4+ messages in thread
From: Stefan Binding @ 2024-04-23 16:23 UTC (permalink / raw
  To: Jaroslav Kysela, Takashi Iwai
  Cc: alsa-devel, linux-sound, linux-kernel, patches, Stefan Binding

Add laptop using CS35L41 HDA.
This laptop does not have _DSD, so require entries in property
configuration table for cs35l41_hda driver.

Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index d1c35cd5a776..38a9b4872f1e 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10425,6 +10425,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x3852, "Lenovo Yoga 7 14ITL5", ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),
 	SND_PCI_QUIRK(0x17aa, 0x3853, "Lenovo Yoga 7 15ITL5", ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),
 	SND_PCI_QUIRK(0x17aa, 0x3855, "Legion 7 16ITHG6", ALC287_FIXUP_LEGION_16ITHG6),
+	SND_PCI_QUIRK(0x17aa, 0x3865, "Lenovo 13X", ALC287_FIXUP_CS35L41_I2C_2),
+	SND_PCI_QUIRK(0x17aa, 0x3866, "Lenovo 13X", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x17aa, 0x3869, "Lenovo Yoga7 14IAL7", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
 	SND_PCI_QUIRK(0x17aa, 0x386f, "Legion 7i 16IAX7", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x17aa, 0x3870, "Lenovo Yoga 7 14ARB7", ALC287_FIXUP_YOGA7_14ARB7_I2C),
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 0/2] Add support for Lenovo Thinkbook 13X
  2024-04-23 16:23 [PATCH v1 0/2] Add support for Lenovo Thinkbook 13X Stefan Binding
  2024-04-23 16:23 ` [PATCH v1 1/2] ALSA: hda: cs35l41: Support Lenovo 13X laptop without _DSD Stefan Binding
  2024-04-23 16:23 ` [PATCH v1 2/2] ALSA: hda/realtek: Add quirks for Lenovo 13X Stefan Binding
@ 2024-04-24  8:35 ` Takashi Iwai
  2 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2024-04-24  8:35 UTC (permalink / raw
  To: Stefan Binding
  Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-sound,
	linux-kernel, patches

On Tue, 23 Apr 2024 18:23:01 +0200,
Stefan Binding wrote:
> 
> This laptop does not contain _DSD required to support CS35L41 HDA.
> To workaround this, add support for this laptop into the configuration
> table in cs35l41_hda_property.c.
> Also add the required entry into patch_realtek for this SSID.
> 
> Stefan Binding (2):
>   ALSA: hda: cs35l41: Support Lenovo 13X laptop without _DSD
>   ALSA: hda/realtek: Add quirks for Lenovo 13X

Applied both patches now to for-next branch.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-24  8:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-23 16:23 [PATCH v1 0/2] Add support for Lenovo Thinkbook 13X Stefan Binding
2024-04-23 16:23 ` [PATCH v1 1/2] ALSA: hda: cs35l41: Support Lenovo 13X laptop without _DSD Stefan Binding
2024-04-23 16:23 ` [PATCH v1 2/2] ALSA: hda/realtek: Add quirks for Lenovo 13X Stefan Binding
2024-04-24  8:35 ` [PATCH v1 0/2] Add support for Lenovo Thinkbook 13X Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).