From: Al Viro <viro@zeniv.linux.org.uk>
To: I Hsin Cheng <richard120310@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] tcp_bbr: replace lambda expression with bitwise operation for bit flip
Date: Fri, 26 Apr 2024 21:19:02 +0100 [thread overview]
Message-ID: <20240426201902.GQ2118490@ZenIV> (raw)
In-Reply-To: <Zivd4agQ8D6rUKvt@vaxr-BM6660-BM6360>
On Sat, Apr 27, 2024 at 01:01:21AM +0800, I Hsin Cheng wrote:
> I see, thanks for your explanation.
> I thought the compilers behavior might alters due to different
> architecture or different compilers.
> So would you recommend on the proposed changes or we should stick to
> the original implementation?
> Personally I think my version or your proposed change are both more
> understandable and elegant than the lambda expression.
Out of curiosity, where do you see any lambda expressions in the entire
thing?
next prev parent reply other threads:[~2024-04-26 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 15:20 [PATCH] tcp_bbr: replace lambda expression with bitwise operation for bit flip I Hsin Cheng
2024-04-26 15:32 ` Eric Dumazet
2024-04-26 17:01 ` I Hsin Cheng
2024-04-26 20:19 ` Al Viro [this message]
2024-04-27 8:31 ` I Hsin Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426201902.GQ2118490@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richard120310@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).