From: "Darrick J. Wong" <djwong@kernel.org>
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: Chandan Babu R <chandan.babu@oracle.com>,
Dave Chinner <dchinner@redhat.com>,
Colin Ian King <colin.i.king@gmail.com>,
Zhang Tianci <zhangtianci.1997@bytedance.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: Use kmemdup() instead of kmalloc() and memcpy()
Date: Fri, 26 Apr 2024 16:18:36 -0700 [thread overview]
Message-ID: <20240426231836.GS360919@frogsfrogsfrogs> (raw)
In-Reply-To: <20240426220046.181251-2-thorsten.blum@toblux.com>
On Sat, Apr 27, 2024 at 12:00:47AM +0200, Thorsten Blum wrote:
> Fixes the following two Coccinelle/coccicheck warnings reported by
> memdup.cocci:
>
> xfs_dir2.c:343:15-22: WARNING opportunity for kmemdup
> xfs_attr_leaf.c:1062:13-20: WARNING opportunity for kmemdup
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
> fs/xfs/libxfs/xfs_attr_leaf.c | 5 ++---
> fs/xfs/libxfs/xfs_dir2.c | 3 +--
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
> index ac904cc1a97b..7346ee9aa4ca 100644
> --- a/fs/xfs/libxfs/xfs_attr_leaf.c
> +++ b/fs/xfs/libxfs/xfs_attr_leaf.c
> @@ -1059,12 +1059,11 @@ xfs_attr3_leaf_to_shortform(
>
> trace_xfs_attr_leaf_to_sf(args);
>
> - tmpbuffer = kmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL);
> + tmpbuffer = kmemdup(bp->b_addr, args->geo->blksize,
> + GFP_KERNEL | __GFP_NOFAIL);
> if (!tmpbuffer)
> return -ENOMEM;
>
> - memcpy(tmpbuffer, bp->b_addr, args->geo->blksize);
> -
Please read the list before submitting a patch to a function that
already has a different change pending.
--D
> leaf = (xfs_attr_leafblock_t *)tmpbuffer;
> xfs_attr3_leaf_hdr_from_disk(args->geo, &ichdr, leaf);
> entry = xfs_attr3_leaf_entryp(leaf);
> diff --git a/fs/xfs/libxfs/xfs_dir2.c b/fs/xfs/libxfs/xfs_dir2.c
> index 4821519efad4..3ebb959cdaf0 100644
> --- a/fs/xfs/libxfs/xfs_dir2.c
> +++ b/fs/xfs/libxfs/xfs_dir2.c
> @@ -340,12 +340,11 @@ xfs_dir_cilookup_result(
> !(args->op_flags & XFS_DA_OP_CILOOKUP))
> return -EEXIST;
>
> - args->value = kmalloc(len,
> + args->value = kmemdup(name, len,
> GFP_KERNEL | __GFP_NOLOCKDEP | __GFP_RETRY_MAYFAIL);
> if (!args->value)
> return -ENOMEM;
>
> - memcpy(args->value, name, len);
> args->valuelen = len;
> return -EEXIST;
> }
> --
> 2.44.0
>
>
prev parent reply other threads:[~2024-04-26 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 22:00 [PATCH] xfs: Use kmemdup() instead of kmalloc() and memcpy() Thorsten Blum
2024-04-26 23:18 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426231836.GS360919@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=colin.i.king@gmail.com \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=thorsten.blum@toblux.com \
--cc=zhangtianci.1997@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).