From: ogustavo@usp.br
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org
Cc: Gustavo Rodrigues <ogustavo@usp.br>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bruna Lopes <brunaafl@usp.br>
Subject: [PATCH 3/3] iio: adc: ad799x: Prefer to use octal permission
Date: Sun, 28 Apr 2024 16:43:26 -0300 [thread overview]
Message-ID: <20240428194326.2836387-4-ogustavo@usp.br> (raw)
In-Reply-To: <20240428194326.2836387-1-ogustavo@usp.br>
From: Gustavo Rodrigues <ogustavo@usp.br>
Octal permissions are preferred over the symbolics ones
for readbility. This ceases warning message pointed by checkpatch.
Co-developed-by: Bruna Lopes <brunaafl@usp.br>
Signed-off-by: Bruna Lopes <brunaafl@usp.br>
Signed-off-by: Gustavo Rodrigues <ogustavo@usp.br>
---
drivers/iio/adc/ad799x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c
index 9a12e562c259..0f0dcd9ca6b6 100644
--- a/drivers/iio/adc/ad799x.c
+++ b/drivers/iio/adc/ad799x.c
@@ -524,7 +524,7 @@ static irqreturn_t ad799x_event_handler(int irq, void *private)
return IRQ_HANDLED;
}
-static IIO_DEV_ATTR_SAMP_FREQ(S_IWUSR | S_IRUGO,
+static IIO_DEV_ATTR_SAMP_FREQ(0644,
ad799x_read_frequency,
ad799x_write_frequency);
static IIO_CONST_ATTR_SAMP_FREQ_AVAIL("15625 7812 3906 1953 976 488 244 0");
--
2.34.1
next prev parent reply other threads:[~2024-04-28 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 19:43 [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch ogustavo
2024-04-28 19:43 ` [PATCH 1/3] iio: adc: ad799x: change 'unsigned' to 'unsigned int' declaration ogustavo
2024-04-28 19:43 ` [PATCH 2/3] iio: adc: ad799x: add blank line to avoid warning messages ogustavo
2024-04-28 19:43 ` ogustavo [this message]
2024-04-29 7:28 ` [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch Nuno Sá
2024-04-29 19:58 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240428194326.2836387-4-ogustavo@usp.br \
--to=ogustavo@usp.br \
--cc=Michael.Hennerich@analog.com \
--cc=brunaafl@usp.br \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).