From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: willy@infradead.org, brauner@kernel.org, david@fromorbit.com,
chandan.babu@oracle.com, akpm@linux-foundation.org,
linux-fsdevel@vger.kernel.org, hare@suse.de,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-xfs@vger.kernel.org, mcgrof@kernel.org,
gost.dev@samsung.com, p.raghav@samsung.com,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH v4 08/11] xfs: use kvmalloc for xattr buffers
Date: Sun, 28 Apr 2024 21:06:34 +0000 [thread overview]
Message-ID: <20240428210634.bkarwrwi6rdr6ywx@quentin> (raw)
In-Reply-To: <20240426151844.GH360919@frogsfrogsfrogs>
On Fri, Apr 26, 2024 at 08:18:44AM -0700, Darrick J. Wong wrote:
> On Thu, Apr 25, 2024 at 01:37:43PM +0200, Pankaj Raghav (Samsung) wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Pankaj Raghav reported that when filesystem block size is larger
> > than page size, the xattr code can use kmalloc() for high order
> > allocations. This triggers a useless warning in the allocator as it
> > is a __GFP_NOFAIL allocation here:
> >
> > static inline
> > struct page *rmqueue(struct zone *preferred_zone,
> > struct zone *zone, unsigned int order,
> > gfp_t gfp_flags, unsigned int alloc_flags,
> > int migratetype)
> > {
> > struct page *page;
> >
> > /*
> > * We most definitely don't want callers attempting to
> > * allocate greater than order-1 page units with __GFP_NOFAIL.
> > */
> > >>>> WARN_ON_ONCE((gfp_flags & __GFP_NOFAIL) && (order > 1));
> > ...
> >
> > Fix this by changing all these call sites to use kvmalloc(), which
> > will strip the NOFAIL from the kmalloc attempt and if that fails
> > will do a __GFP_NOFAIL vmalloc().
> >
> > This is not an issue that productions systems will see as
> > filesystems with block size > page size cannot be mounted by the
> > kernel; Pankaj is developing this functionality right now.
> >
> > Reported-by: Pankaj Raghav <kernel@pankajraghav.com>
> > Fixes: f078d4ea8276 ("xfs: convert kmem_alloc() to kmalloc()")
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> Didn't this already go in for-next?
I don't think so. I think Christoph suggested to have it in the LBS
series and see if MM folks can fix the issue upstream.[1]
[1] https://www.spinics.net/lists/linux-xfs/msg83130.html
>
> If not,
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>
> --D
>
> > ---
> > fs/xfs/libxfs/xfs_attr_leaf.c | 15 ++++++---------
> > 1 file changed, 6 insertions(+), 9 deletions(-)
> >
> > diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
> > index ac904cc1a97b..969abc6efd70 100644
> > --- a/fs/xfs/libxfs/xfs_attr_leaf.c
> > +++ b/fs/xfs/libxfs/xfs_attr_leaf.c
> > @@ -1059,10 +1059,7 @@ xfs_attr3_leaf_to_shortform(
> >
> > trace_xfs_attr_leaf_to_sf(args);
> >
> > - tmpbuffer = kmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL);
> > - if (!tmpbuffer)
> > - return -ENOMEM;
> > -
> > + tmpbuffer = kvmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL);
> > memcpy(tmpbuffer, bp->b_addr, args->geo->blksize);
> >
> > leaf = (xfs_attr_leafblock_t *)tmpbuffer;
> > @@ -1125,7 +1122,7 @@ xfs_attr3_leaf_to_shortform(
> > error = 0;
> >
> > out:
> > - kfree(tmpbuffer);
> > + kvfree(tmpbuffer);
> > return error;
> > }
> >
> > @@ -1533,7 +1530,7 @@ xfs_attr3_leaf_compact(
> >
> > trace_xfs_attr_leaf_compact(args);
> >
> > - tmpbuffer = kmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL);
> > + tmpbuffer = kvmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL);
> > memcpy(tmpbuffer, bp->b_addr, args->geo->blksize);
> > memset(bp->b_addr, 0, args->geo->blksize);
> > leaf_src = (xfs_attr_leafblock_t *)tmpbuffer;
> > @@ -1571,7 +1568,7 @@ xfs_attr3_leaf_compact(
> > */
> > xfs_trans_log_buf(trans, bp, 0, args->geo->blksize - 1);
> >
> > - kfree(tmpbuffer);
> > + kvfree(tmpbuffer);
> > }
> >
> > /*
> > @@ -2250,7 +2247,7 @@ xfs_attr3_leaf_unbalance(
> > struct xfs_attr_leafblock *tmp_leaf;
> > struct xfs_attr3_icleaf_hdr tmphdr;
> >
> > - tmp_leaf = kzalloc(state->args->geo->blksize,
> > + tmp_leaf = kvzalloc(state->args->geo->blksize,
> > GFP_KERNEL | __GFP_NOFAIL);
> >
> > /*
> > @@ -2291,7 +2288,7 @@ xfs_attr3_leaf_unbalance(
> > }
> > memcpy(save_leaf, tmp_leaf, state->args->geo->blksize);
> > savehdr = tmphdr; /* struct copy */
> > - kfree(tmp_leaf);
> > + kvfree(tmp_leaf);
> > }
> >
> > xfs_attr3_leaf_hdr_to_disk(state->args->geo, save_leaf, &savehdr);
> > --
> > 2.34.1
> >
> >
next prev parent reply other threads:[~2024-04-28 21:06 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 11:37 [PATCH v4 00/11] enable bs > ps in XFS Pankaj Raghav (Samsung)
2024-04-25 11:37 ` [PATCH v4 01/11] readahead: rework loop in page_cache_ra_unbounded() Pankaj Raghav (Samsung)
2024-04-25 11:37 ` [PATCH v4 02/11] fs: Allow fine-grained control of folio sizes Pankaj Raghav (Samsung)
2024-04-25 18:07 ` Hannes Reinecke
2024-04-26 15:09 ` Darrick J. Wong
2024-04-25 11:37 ` [PATCH v4 03/11] filemap: allocate mapping_min_order folios in the page cache Pankaj Raghav (Samsung)
2024-04-25 19:04 ` Hannes Reinecke
2024-04-26 15:12 ` Darrick J. Wong
2024-04-28 20:59 ` Pankaj Raghav (Samsung)
2024-04-25 11:37 ` [PATCH v4 04/11] readahead: allocate folios with mapping_min_order in readahead Pankaj Raghav (Samsung)
2024-04-25 18:53 ` Matthew Wilcox
2024-04-25 11:37 ` [PATCH v4 05/11] mm: do not split a folio if it has minimum folio order requirement Pankaj Raghav (Samsung)
2024-04-25 20:10 ` Matthew Wilcox
2024-04-26 0:47 ` Luis Chamberlain
2024-04-26 23:46 ` Luis Chamberlain
2024-04-28 0:57 ` Luis Chamberlain
2024-04-29 3:56 ` Luis Chamberlain
2024-04-29 14:29 ` Zi Yan
2024-04-30 0:31 ` Luis Chamberlain
2024-04-30 0:49 ` Luis Chamberlain
2024-04-30 2:43 ` Zi Yan
2024-04-30 19:27 ` Luis Chamberlain
2024-05-01 4:13 ` Matthew Wilcox
2024-05-01 14:28 ` Matthew Wilcox
2024-04-26 15:49 ` Pankaj Raghav (Samsung)
2024-04-25 11:37 ` [PATCH v4 06/11] filemap: cap PTE range to be created to i_size in folio_map_range() Pankaj Raghav (Samsung)
2024-04-25 20:24 ` Matthew Wilcox
2024-04-26 12:54 ` Pankaj Raghav (Samsung)
2024-04-25 11:37 ` [PATCH v4 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Pankaj Raghav (Samsung)
2024-04-26 6:22 ` Christoph Hellwig
2024-04-26 11:43 ` Pankaj Raghav (Samsung)
2024-04-27 5:12 ` Christoph Hellwig
2024-04-29 21:02 ` Pankaj Raghav (Samsung)
2024-04-27 3:26 ` Matthew Wilcox
2024-04-27 4:52 ` Christoph Hellwig
2024-04-25 11:37 ` [PATCH v4 08/11] xfs: use kvmalloc for xattr buffers Pankaj Raghav (Samsung)
2024-04-26 15:18 ` Darrick J. Wong
2024-04-28 21:06 ` Pankaj Raghav (Samsung) [this message]
2024-04-25 11:37 ` [PATCH v4 09/11] xfs: expose block size in stat Pankaj Raghav (Samsung)
2024-04-26 15:15 ` Darrick J. Wong
2024-04-25 11:37 ` [PATCH v4 10/11] xfs: make the calculation generic in xfs_sb_validate_fsb_count() Pankaj Raghav (Samsung)
2024-04-26 15:16 ` Darrick J. Wong
2024-04-25 11:37 ` [PATCH v4 11/11] xfs: enable block size larger than page size support Pankaj Raghav (Samsung)
2024-04-26 15:18 ` Darrick J. Wong
2024-04-27 4:42 ` [PATCH v4 00/11] enable bs > ps in XFS Ritesh Harjani
2024-04-27 5:05 ` Darrick J. Wong
2024-04-29 20:39 ` Pankaj Raghav (Samsung)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240428210634.bkarwrwi6rdr6ywx@quentin \
--to=kernel@pankajraghav.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).