From: Conor Dooley <conor@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] yamllint: Drop excluding quoted values with ',' from checks
Date: Tue, 30 Apr 2024 18:40:24 +0100 [thread overview]
Message-ID: <20240430-unsnap-eskimo-444052f98b7d@spud> (raw)
In-Reply-To: <20240426195438.2771968-1-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
On Fri, Apr 26, 2024 at 02:54:37PM -0500, Rob Herring (Arm) wrote:
> From: Rob Herring <robh@kernel.org>
>
> Strings with commas were excluded from checks because yamllint had false
> positives for flow style maps and sequences which need quotes when
> values contain commas. This issue has been fixed as of the 1.34 release,
> so drop the work-around.
Hmm, is this a bit aggressive of an upgrade? I only checked Debian since
it is what this machine uses, and it only seems to be shipping 1.33 in
testing & unstable.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/.yamllint | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/.yamllint b/Documentation/devicetree/bindings/.yamllint
> index 358c88813937..fadbc6ad3c76 100644
> --- a/Documentation/devicetree/bindings/.yamllint
> +++ b/Documentation/devicetree/bindings/.yamllint
> @@ -7,7 +7,7 @@ rules:
> quoted-strings:
> required: only-when-needed
> extra-allowed:
> - - '[$^,[]'
> + - '[$^[]'
> - '^/$'
> line-length:
> # 80 chars should be enough, but don't fail if a line is longer
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-04-30 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 19:54 [PATCH] yamllint: Drop excluding quoted values with ',' from checks Rob Herring (Arm)
2024-04-30 17:40 ` Conor Dooley [this message]
2024-04-30 17:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430-unsnap-eskimo-444052f98b7d@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).