From: Shradha Gupta <shradhagupta@linux.microsoft.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Randy Dunlap <rdunlap@infradead.org>,
Johannes Berg <johannes.berg@intel.com>,
Breno Leitao <leitao@debian.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Long Li <longli@microsoft.com>,
Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>,
Konstantin Taranov <kotaranov@microsoft.com>,
Yury Norov <yury.norov@gmail.com>,
linux-hyperv@vger.kernel.org, shradhagupta@microsoft.com
Subject: Re: [PATCH net-next v2 0/2] Add sysfs attributes for MANA
Date: Mon, 29 Apr 2024 22:31:38 -0700 [thread overview]
Message-ID: <20240430053138.GA6429@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <ZikbpoXWmcQrBP3V@nanopsycho>
On Wed, Apr 24, 2024 at 04:48:06PM +0200, Jiri Pirko wrote:
> Wed, Apr 24, 2024 at 12:32:54PM CEST, shradhagupta@linux.microsoft.com wrote:
> >These patches include adding sysfs attributes for improving
> >debuggability on MANA devices.
> >
> >The first patch consists on max_mtu, min_mtu attributes that are
> >implemented generically for all devices
> >
> >The second patch has mana specific attributes max_num_msix and num_ports
>
> 1) you implement only max, min is never implemented, no point
> introducing it.
Sure. I had added it for the sake of completeness.
> 2) having driver implement sysfs entry feels *very wrong*, don't do that
> 3) why DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MAX
> and DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MIN
> Are not what you want?
Thanks for pointing this out. We are still evaluating if this devlink param
could be used for our usecase where we only need a read-only msix value for VF.
We keep the thread updated.
>
> >
> >Shradha Gupta (2):
> > net: Add sysfs atttributes for max_mtu min_mtu
> > net: mana: Add new device attributes for mana
> >
> > Documentation/ABI/testing/sysfs-class-net | 16 ++++++++++
> > .../net/ethernet/microsoft/mana/gdma_main.c | 32 +++++++++++++++++++
> > net/core/net-sysfs.c | 4 +++
> > 3 files changed, 52 insertions(+)
> >
> >--
> >2.34.1
> >
> >
next prev parent reply other threads:[~2024-04-30 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 10:32 [PATCH net-next v2 0/2] Add sysfs attributes for MANA Shradha Gupta
2024-04-24 10:33 ` [PATCH net-next v2 1/2] net: Add sysfs atttributes for max_mtu min_mtu Shradha Gupta
2024-04-25 3:27 ` Jakub Kicinski
2024-04-26 11:06 ` Shradha Gupta
2024-04-24 10:34 ` [PATCH net-next v2 2/2] net: mana: Add new device attributes for mana Shradha Gupta
2024-04-24 14:48 ` [PATCH net-next v2 0/2] Add sysfs attributes for MANA Jiri Pirko
2024-04-30 5:31 ` Shradha Gupta [this message]
2024-05-03 8:48 ` Shradha Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430053138.GA6429@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=shradhagupta@linux.microsoft.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=jiri@resnulli.us \
--cc=johannes.berg@intel.com \
--cc=kotaranov@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leitao@debian.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=schakrabarti@linux.microsoft.com \
--cc=shradhagupta@microsoft.com \
--cc=wei.liu@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).