From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Haoyang Liu <tttturtleruss@hust.edu.cn>,
Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russ.weight@linux.dev>,
"Rafael J. Wysocki" <rafael@kernel.org>,
hust-os-kernel-patches@googlegroups.com,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware_loader: Replace simple_strtol() with kstrtoint()
Date: Sun, 5 May 2024 08:35:27 +0200 [thread overview]
Message-ID: <2024050505-clapping-preview-ebcc@gregkh> (raw)
In-Reply-To: <ZjZ80FAYcYtaeD8M@surfacebook.localdomain>
On Sat, May 04, 2024 at 09:22:08PM +0300, Andy Shevchenko wrote:
> Sat, Apr 27, 2024 at 04:25:32AM +0800, Haoyang Liu kirjoitti:
> > simple_strtol() is obsolete, use kstrtoint() instead.
>
> It's not, but kstrtox() is preferred.
>
> ...
>
>
> While I'm in support of this move, this might break userspace by making
> stricter requirement on the input.
Good point, I've dropped this so that others can test it better first.
thanks,
greg k-h
prev parent reply other threads:[~2024-05-05 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 20:25 [PATCH] firmware_loader: Replace simple_strtol() with kstrtoint() Haoyang Liu
2024-04-29 20:50 ` Russ Weight
2024-05-04 18:22 ` Andy Shevchenko
2024-05-05 6:35 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024050505-clapping-preview-ebcc@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=russ.weight@linux.dev \
--cc=tttturtleruss@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).