* [PATCH] objtool: builtin-check: Use "action" in opts_valid error message to be consistent with help
@ 2024-05-10 9:32 Siddh Raman Pant
2024-05-10 19:44 ` Josh Poimboeuf
0 siblings, 1 reply; 2+ messages in thread
From: Siddh Raman Pant @ 2024-05-10 9:32 UTC (permalink / raw
To: Josh Poimboeuf, Peter Zijlstra; +Cc: linux-kernel
The help message mentions the main options as "actions", which is
different from the optional "options". But the check error messages
outputs "option" or "command" for referring to actions.
Hence, make the error messages consistent with help.
Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
---
tools/objtool/builtin-check.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c
index 5e21cfb7661d..387d56a7f5fb 100644
--- a/tools/objtool/builtin-check.c
+++ b/tools/objtool/builtin-check.c
@@ -144,7 +144,7 @@ static bool opts_valid(void)
opts.static_call ||
opts.uaccess) {
if (opts.dump_orc) {
- ERROR("--dump can't be combined with other options");
+ ERROR("--dump can't be combined with other actions");
return false;
}
@@ -159,7 +159,7 @@ static bool opts_valid(void)
if (opts.dump_orc)
return true;
- ERROR("At least one command required");
+ ERROR("At least one action required");
return false;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] objtool: builtin-check: Use "action" in opts_valid error message to be consistent with help
2024-05-10 9:32 [PATCH] objtool: builtin-check: Use "action" in opts_valid error message to be consistent with help Siddh Raman Pant
@ 2024-05-10 19:44 ` Josh Poimboeuf
0 siblings, 0 replies; 2+ messages in thread
From: Josh Poimboeuf @ 2024-05-10 19:44 UTC (permalink / raw
To: Siddh Raman Pant; +Cc: Peter Zijlstra, linux-kernel
On Fri, May 10, 2024 at 03:02:57PM +0530, Siddh Raman Pant wrote:
> The help message mentions the main options as "actions", which is
> different from the optional "options". But the check error messages
> outputs "option" or "command" for referring to actions.
>
> Hence, make the error messages consistent with help.
>
> Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
Queued, thanks!
--
Josh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-10 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-10 9:32 [PATCH] objtool: builtin-check: Use "action" in opts_valid error message to be consistent with help Siddh Raman Pant
2024-05-10 19:44 ` Josh Poimboeuf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).