From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Andrew Hepp <andrew.hepp@ahepp.dev>,
Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] iio: temperature: mcp9600: add threshold events support
Date: Mon, 20 May 2024 13:18:50 +0100 [thread overview]
Message-ID: <20240520131850.00003430@Huawei.com> (raw)
In-Reply-To: <20240519210036.GB10322@debian>
On Sun, 19 May 2024 23:00:36 +0200
Dimitri Fedrau <dima.fedrau@gmail.com> wrote:
> Am Sun, May 19, 2024 at 05:42:48PM +0100 schrieb Jonathan Cameron:
> > On Fri, 17 May 2024 10:10:50 +0200
> > Dimitri Fedrau <dima.fedrau@gmail.com> wrote:
> >
> > > The device has four programmable temperature alert outputs which can be
> > > used to monitor hot or cold-junction temperatures and detect falling and
> > > rising temperatures. It supports up to 255 degree celsius programmable
> > > hysteresis. Each alert can be individually configured by setting following
> > > options in the associated alert configuration register:
> > > - monitor hot or cold junction temperature
> > > - monitor rising or falling temperature
> > > - set comparator or interrupt mode
> > > - set output polarity
> > > - enable alert
> > >
> > > This patch binds alert outputs to iio events:
> > > - alert1: hot junction, rising temperature
> > > - alert2: hot junction, falling temperature
> > > - alert3: cold junction, rising temperature
> > > - alert4: cold junction, falling temperature
> > >
> > > All outputs are set in comparator mode and polarity depends on interrupt
> > > configuration.
> > >
> > > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> > Hi Dmitri
>
> Hi Jonathan,
>
> > Please make sure to address all questions in earlier reviews, either by
> > changing the code, or directly answering the question.
> >
> I did, see: https://lore.kernel.org/linux-iio/20240509204559.GB3614@debian/T/#u
> or did I miss anything ? I'm a little bit confused.
I think some emails went astray :( Sorry I didn't check the archive.
Anyhow, thanks for providing the links.
Jonathan
next prev parent reply other threads:[~2024-05-20 12:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 8:10 [PATCH v2 0/2] Add threshold events support Dimitri Fedrau
2024-05-17 8:10 ` [PATCH v2 1/2] iio: temperature: mcp9600: Provide index for both channels Dimitri Fedrau
2024-05-17 15:30 ` Markus Elfring
2024-05-19 16:14 ` Jonathan Cameron
2024-05-19 20:32 ` Dimitri Fedrau
2024-05-20 12:17 ` Jonathan Cameron
2024-05-21 2:28 ` Andrew Hepp
2024-05-23 11:21 ` Dimitri Fedrau
2024-05-17 8:10 ` [PATCH v2 2/2] iio: temperature: mcp9600: add threshold events support Dimitri Fedrau
2024-05-19 16:42 ` Jonathan Cameron
2024-05-19 21:00 ` Dimitri Fedrau
2024-05-20 12:18 ` Jonathan Cameron [this message]
2024-05-23 11:14 ` Dimitri Fedrau
2024-05-17 13:28 ` [PATCH v2 0/2] Add " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240520131850.00003430@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andrew.hepp@ahepp.dev \
--cc=dima.fedrau@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).