From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759447AbcAULkU (ORCPT ); Thu, 21 Jan 2016 06:40:20 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:42545 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759402AbcAULkQ (ORCPT ); Thu, 21 Jan 2016 06:40:16 -0500 X-AuditID: cbfee68f-f793a6d000001364-eb-56a0c39e5761 Date: Thu, 21 Jan 2016 11:40:14 +0000 (GMT) From: Maninder Singh Subject: Re: [PATCH] af_packet: Raw socket destruction warning fix To: Daniel Borkmann , Vaneet Narang Cc: "davem@davemloft.net" , "willemb@google.com" , "edumazet@google.com" , "eyal.birger@gmail.com" , "tklauser@distanz.ch" , "fruggeri@aristanetworks.com" , "dwmw2@infradead.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , PANKAJ MISHRA , Geon-ho Kim , Hak-Bong Lee Reply-to: maninder1.s@samsung.com MIME-version: 1.0 X-MTR: 20160121113047891@maninder1.s Msgkey: 20160121113047891@maninder1.s X-EPLocale: en_US.windows-1252 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20160121113047891@maninder1.s X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=windows-1252 MIME-version: 1.0 Message-id: <2036003091.741801453376409338.JavaMail.weblogic@ep2mlwas01a> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWyRsSkVnfe4QVhBteO6lhc3jWHzYHR4/Mm uQDGKC6blNSczLLUIn27BK6Mvde+shR8Yq84uOgaawPjFfYuRk4OIQE1iUV7H7N1MXJwSAiY SPx6pQ4SlhAQk7hwbz1QmAuoZCmjxNTPU5ggEiYSDxu/QSXmMEpcWjWRGSTBIqAqsbR/GiuI zSagL3F27zqwuLCAk8Sb7h9gcRGBMIljh2cxgzQzC1xkkZj18z3UFYoS6288YQSxeQUEJU7O fMICcZGKxJQjDhBhVYmFfR+ZIY6Qk1gy9TLUQbwSM9qfssDEp31dA1UjLXF+1gZGmG8Wf38M FeeXOHZ7B1SvgMTUMwcZIVZpSpzYVAAR5pNYs/AtC0z5rlPLmWFW3d8yF6pVQmJryxOwt5iB rp/S/ZAdwjaQOLJoDiu6T3gFPCUuLOIC+VxCYCKHxKxn29kmMCrNQlI2C8moWUhGIatZwMiy ilE0tSC5oDgpvchYrzgxt7g0L10vOT93EyMwLZz+96x/B+PdA9aHGAU4GJV4eG9cmx8mxJpY VlyZe4jRFBhLE5mlRJPzgcknryTe0NjMyMLUxNTYyNzSTEmcd6HUz2AhgfTEktTs1NSC1KL4 otKc1OJDjEwcnFINjAzCF3fKpLTNMWD7/0tiYVL/L44nn1XeBSz1TG4/OH/Pgwszj6Wo6rEv /9TTr/7tpOqs9titS84rNE05uPtqU8eXWWVi0bsVX528fZd33rVzm3xuta0+Ev16xdwN7A1q 51TbFnFNnjT7FdsWIYOIGK4vevcna6TcLTzl4XXypLEVs9Gl2xz+7z8osRRnJBpqMRcVJwIA LORboQYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKKsWRmVeSWpSXmKPExsVy+t/tXt15hxeEGSw7ymhxedccNgdGj8+b 5AIYo9JsMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4CG KimUJeaUAoUCEouLlfTtbIryS0tSFTLyi0tslaINzY30jAz0TI30DE1jrQwNDIxMgWoS0jL2 XvvKUvCJveLgomusDYxX2LsYOTmEBNQkFu19zAZiSwiYSDxs/AZli0lcuLceyOYCqpnDKHFp 1URmkASLgKrE0v5prCA2m4C+xNm968DiwgJOEm+6f4DFRQTCJI4dnsUM0swscJFFYtbP91Db FCXW33jCCGLzCghKnJz5hKWLkQNom4rElCMOEGFViYV9H5khjpCTWDL1MhOEzSsxo/0pC0x8 2tc1UDXSEudnbWCEOXrx98dQcX6JY7d3QPUKSEw9c5ARYpWmxIlNBRBhPok1C9+ywJTvOrWc GWbV/S1zoVolJLa2PAF7ixno+indD9khbAOJI4vmsKL7hFfAU+LCIq4JjLKzkGRmIemehaQb Wc0CRpZVjKKpBckFxUnpFUZ6xYm5xaV56XrJ+bmbGMFJ6NmiHYz/zlsfYhTgYFTi4b1xbX6Y EGtiWXFl7iFGCQ5mJRHew7sWhAnxpiRWVqUW5ccXleakFh9iNAXG2URmKdHkfGCCzCuJNzQ2 MTc1NrUwMDQ3N1MS5729zy9MSCA9sSQ1OzW1ILUIpo+Jg1OqgbHHp/qKauop1vo/K1MLyqo2 m/dZdKz2u15/hfnWVTn71U9sbnyus8qY9LO+VlJiWou4yJbrXHMtJy07P5c39eik+Ekl177+ zHiRofvpT054woOVBpP2X499OG+hvkJxSnuZYUJVvvOZs+mv0mdV7P47PborpsPvmFpvm8tW d/M58dbm/w4btiixFGckGmoxFxUnAgBxGnl+WAMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u0LBePKo031614 Hi Daniel, >The other sock_put() in packet_release() to drop the final ref and call into >sk_free(), which drops the 1 ref on the sk_wmem_alloc from init time. Since you >got into __sk_free() via sock_wfree() destructor, your socket must have invoked >packet_release() prior to this (perhaps kernel destroying the process). > >What kernel do you use? Issue is coming for 3.10.58. >> Driver calls dev_kfree_skb_any->dev_kfree_skb_irq >> and it adds buffer in completion queue to free and raises softirq NET_TX_SOFTIRQ >> >> net_tx_action->__kfree_skb->skb_release_all->skb_release_head_state->sock_wfree-> >> __sk_free->packet_sock_destruct >> >> Also purging of receive queue has been taken care in other protocols.