* [PATCH v2] checkpatch: add "Reported-and-tested-by:" tag
@ 2024-04-19 22:28 Nam Cao
2024-04-20 16:22 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Nam Cao @ 2024-04-19 22:28 UTC (permalink / raw
To: apw, joe, dwaipayanray1, lukas.bulwahn, linux-kernel; +Cc: Nam Cao
The tag "Reported-and-tested-by:" is used all the time. Add this tag.
Signed-off-by: Nam Cao <namcao@linutronix.de>
---
v2: add missing colon
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9c4c4a61bc83..e2034da2aeb0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -618,6 +618,7 @@ our $signature_tags = qr{(?xi:
Tested-by:|
Reviewed-by:|
Reported-by:|
+ Reported-and-tested-by:|
Suggested-by:|
To:|
Cc:
@@ -712,7 +713,7 @@ sub find_standard_signature {
my ($sign_off) = @_;
my @standard_signature_tags = (
'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
- 'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
+ 'Reviewed-by:', 'Reported-by:', 'Suggested-by:', 'Reported-and-tested-by:'
);
foreach my $signature (@standard_signature_tags) {
return $signature if (get_edit_distance($sign_off, $signature) <= 2);
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] checkpatch: add "Reported-and-tested-by:" tag
2024-04-19 22:28 [PATCH v2] checkpatch: add "Reported-and-tested-by:" tag Nam Cao
@ 2024-04-20 16:22 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2024-04-20 16:22 UTC (permalink / raw
To: Nam Cao, apw, dwaipayanray1, lukas.bulwahn, linux-kernel
On Sat, 2024-04-20 at 00:28 +0200, Nam Cao wrote:
> The tag "Reported-and-tested-by:" is used all the time. Add this tag.
General nack:
I think that combined tags should be avoided
see:
Documentation/process/maintainer-tip.rst:Please do not use combined tags, e.g. ``Reported-and-tested-by``, as
Documentation/process/maintainer-tip.rst-they just complicate automated extraction of tags.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-20 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-19 22:28 [PATCH v2] checkpatch: add "Reported-and-tested-by:" tag Nam Cao
2024-04-20 16:22 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).