From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E975C433ED for ; Wed, 12 May 2021 14:16:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21B50613BE for ; Wed, 12 May 2021 14:16:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231279AbhELORb (ORCPT ); Wed, 12 May 2021 10:17:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:44978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231529AbhELORR (ORCPT ); Wed, 12 May 2021 10:17:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F3365613F7; Wed, 12 May 2021 14:16:00 +0000 (UTC) Subject: Re: [PATCH 20/33] locking/atomic: m68k: move to ARCH_ATOMIC To: Geert Uytterhoeven , Mark Rutland Cc: Linux Kernel Mailing List , Will Deacon , Boqun Feng , Peter Zijlstra , Albert Ou , Arnd Bergmann , Brian Cain , Benjamin Herrenschmidt , Chris Zankel , Rich Felker , "David S. Miller" , Vincent Chen , Helge Deller , Greentime Hu , Guo Ren , Ivan Kokshaysky , James Bottomley , Max Filippov , Jonas Bonn , Ley Foon Tan , Russell King , Matt Turner , Michal Simek , Michael Ellerman , Nick Hu , Palmer Dabbelt , Paul Mackerras , Paul Walmsley , Richard Henderson , Stafford Horne , Stefan Kristiansson , Thomas Bogendoerfer , Vineet Gupta , Yoshinori Sato References: <20210510093753.40683-1-mark.rutland@arm.com> <20210510093753.40683-21-mark.rutland@arm.com> <20210511100022.GD6152@C02TD0UTHF1T.local> From: Greg Ungerer Message-ID: <2501f556-1326-f09c-baa2-464057ea100c@linux-m68k.org> Date: Thu, 13 May 2021 00:15:58 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, Geert, On 11/5/21 8:27 pm, Geert Uytterhoeven wrote: > Hi Mark, > > CC Greg > > On Tue, May 11, 2021 at 12:00 PM Mark Rutland wrote: >> On Tue, May 11, 2021 at 11:27:45AM +0200, Geert Uytterhoeven wrote: >>> On Mon, May 10, 2021 at 11:42 AM Mark Rutland wrote: >>>> We'd like all architectures to convert to ARCH_ATOMIC, as once all >>>> architectures are converted it will be possible to make significant >>>> cleanups to the atomics headers, and this will make it much easier to >>>> generically enable atomic functionality (e.g. debug logic in the >>>> instrumented wrappers). >>>> >>>> As a step towards that, this patch migrates m68k to ARCH_ATOMIC. The >>>> arch code provides arch_{atomic,atomic64,xchg,cmpxchg}*(), and common >>>> code wraps these with optional instrumentation to provide the regular >>>> functions. >>>> >>>> Signed-off-by: Mark Rutland >>> >>> Reviewed-by: Geert Uytterhoeven >>> Acked-by: Geert Uytterhoeven >>> >>> I even gave this series a spin on ARAnyM and QEMU, and everything >>> seems to be fine. >> >> Thanks! That's much appreciated; I was able to build-test, but didn't >> have a suitable setup for boot testing. >> >> The Kbuild test robot noticed I broke one configuration by renaming >> atomic_dec_and_test_lt(), since it's not part of the common atomic API, >> and is used in get_mmu_context() in . > > Ah, that's in the part for Coldfire, so I (and my builds) didn't notice. > >> On the primciple of keeping the common atomic API separate from >> arch-specific bits, I've kept the `arch_` prefix and updated the caller. >> Does that sound good to you? > > That's fine for me, but as this is Coldfire, I'd like to defer to Greg. Looks fine to me too. Acked-by: Greg Ungerer Regards Greg