* [PATCH] thermal: brcmstb_thermal: Use devm_platform_get_and_ioremap_resource()
@ 2023-01-18 8:31 ye.xingchen
2023-01-18 18:06 ` Florian Fainelli
2023-01-18 21:17 ` Daniel Lezcano
0 siblings, 2 replies; 3+ messages in thread
From: ye.xingchen @ 2023-01-18 8:31 UTC (permalink / raw)
To: daniel.lezcano
Cc: mmayer, bcm-kernel-feedback-list, rafael, amitk, rui.zhang,
f.fainelli, linux-pm, linux-arm-kernel, linux-kernel
From: ye xingchen <ye.xingchen@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/thermal/broadcom/brcmstb_thermal.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
index c79c6cfdd74d..4d02c28331e3 100644
--- a/drivers/thermal/broadcom/brcmstb_thermal.c
+++ b/drivers/thermal/broadcom/brcmstb_thermal.c
@@ -321,7 +321,6 @@ static int brcmstb_thermal_probe(struct platform_device *pdev)
const struct thermal_zone_device_ops *of_ops;
struct thermal_zone_device *thermal;
struct brcmstb_thermal_priv *priv;
- struct resource *res;
int irq, ret;
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
@@ -332,8 +331,7 @@ static int brcmstb_thermal_probe(struct platform_device *pdev)
if (!priv->temp_params)
return -EINVAL;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->tmon_base = devm_ioremap_resource(&pdev->dev, res);
+ priv->tmon_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(priv->tmon_base))
return PTR_ERR(priv->tmon_base);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: brcmstb_thermal: Use devm_platform_get_and_ioremap_resource()
2023-01-18 8:31 [PATCH] thermal: brcmstb_thermal: Use devm_platform_get_and_ioremap_resource() ye.xingchen
@ 2023-01-18 18:06 ` Florian Fainelli
2023-01-18 21:17 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2023-01-18 18:06 UTC (permalink / raw)
To: ye.xingchen, daniel.lezcano
Cc: mmayer, bcm-kernel-feedback-list, rafael, amitk, rui.zhang,
linux-pm, linux-arm-kernel, linux-kernel
On 1/18/23 00:31, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: brcmstb_thermal: Use devm_platform_get_and_ioremap_resource()
2023-01-18 8:31 [PATCH] thermal: brcmstb_thermal: Use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-01-18 18:06 ` Florian Fainelli
@ 2023-01-18 21:17 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2023-01-18 21:17 UTC (permalink / raw)
To: ye.xingchen
Cc: mmayer, bcm-kernel-feedback-list, rafael, amitk, rui.zhang,
f.fainelli, linux-pm, linux-arm-kernel, linux-kernel
On 18/01/2023 09:31, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-18 21:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-18 8:31 [PATCH] thermal: brcmstb_thermal: Use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-01-18 18:06 ` Florian Fainelli
2023-01-18 21:17 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).