LKML Archive mirror
 help / color / mirror / Atom feed
* [ PATCH v2 0/3] Add Loongson I2S controller support
@ 2023-06-12  8:50 YingKun Meng
  2023-06-12 19:07 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: YingKun Meng @ 2023-06-12  8:50 UTC (permalink / raw
  To: broonie, lgirdwood
  Cc: krzysztof.kozlowski+dt, linux-kernel, alsa-devel, loongarch,
	loongson-kernel, YingKun Meng

Hi all,

This patchset adds support for Loongson I2S controller, and
introduce a ASoC machine driver for loongson platform.

The Loongson I2S controller is available on Loongson
7a2000/2k2000 chips, works as a PCI device. It has two
private DMA controllers used to playback and capture.
Each DMA controller has one channel.

The ASoC machine driver adds support for audio device which
using loongson I2S controller to tranfser the audio data.
The audio device uses "PRP0001" as its ACPI device ID, which
provides a means to use the existing DT-compatible device
identification in ACPI.


Thanks.

---
v2:
* Use ACPI bindings to reference I2S and codec nodes.
* Add 'required' restriction for sound-dai property in
  dt-bindings.
* Fix build errors from lkp@intel.com.
* Replace pci_xxx() APIs with pcim_xxx() APIs.
* mirror changes in log printing.

v1:
* Add support for Loongson I2S controller.

Yingkun Meng (3):
  ASoC: Add support for Loongson I2S controller
  ASoC: loongson: Add Loongson ASoC Sound Card Support
  ASoC: dt-bindings: Add support for Loongson audio card

 .../sound/loongson,ls-audio-card.yaml         |  70 +++
 sound/soc/Kconfig                             |   1 +
 sound/soc/Makefile                            |   1 +
 sound/soc/loongson/Kconfig                    |  26 +
 sound/soc/loongson/Makefile                   |   8 +
 sound/soc/loongson/loongson_card.c            | 237 +++++++++
 sound/soc/loongson/loongson_i2s.c             | 213 ++++++++
 sound/soc/loongson/loongson_i2s.h             |  70 +++
 sound/soc/loongson/loongson_i2s_pci.c         | 500 ++++++++++++++++++
 9 files changed, 1126 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml
 create mode 100644 sound/soc/loongson/Kconfig
 create mode 100644 sound/soc/loongson/Makefile
 create mode 100644 sound/soc/loongson/loongson_card.c
 create mode 100644 sound/soc/loongson/loongson_i2s.c
 create mode 100644 sound/soc/loongson/loongson_i2s.h
 create mode 100644 sound/soc/loongson/loongson_i2s_pci.c


base-commit: 62a97bea5cce5317d6d7630f7bcf0cdf5333e269
-- 
2.33.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ PATCH v2 0/3] Add Loongson I2S controller support
  2023-06-12  8:50 [ PATCH v2 0/3] Add Loongson I2S controller support YingKun Meng
@ 2023-06-12 19:07 ` Mark Brown
  2023-06-13 12:45   ` Yingkun Meng
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2023-06-12 19:07 UTC (permalink / raw
  To: YingKun Meng
  Cc: lgirdwood, krzysztof.kozlowski+dt, linux-kernel, alsa-devel,
	loongarch, loongson-kernel

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

On Mon, Jun 12, 2023 at 04:50:48PM +0800, YingKun Meng wrote:
> Hi all,
> 
> This patchset adds support for Loongson I2S controller, and
> introduce a ASoC machine driver for loongson platform.
> 
> The Loongson I2S controller is available on Loongson
> 7a2000/2k2000 chips, works as a PCI device. It has two
> private DMA controllers used to playback and capture.
> Each DMA controller has one channel.
> 
> The ASoC machine driver adds support for audio device which
> using loongson I2S controller to tranfser the audio data.
> The audio device uses "PRP0001" as its ACPI device ID, which
> provides a means to use the existing DT-compatible device
> identification in ACPI.

The code here all looks broadly good - I did have a few review comments
that I sent in reply to the individual patches but they're more
stylistic than anything too substantial.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ PATCH v2 0/3] Add Loongson I2S controller support
  2023-06-12 19:07 ` Mark Brown
@ 2023-06-13 12:45   ` Yingkun Meng
  0 siblings, 0 replies; 3+ messages in thread
From: Yingkun Meng @ 2023-06-13 12:45 UTC (permalink / raw
  To: Mark Brown
  Cc: lgirdwood, krzysztof.kozlowski+dt, linux-kernel, alsa-devel,
	loongarch, loongson-kernel


On 2023/6/13 03:07, Mark Brown wrote:
> On Mon, Jun 12, 2023 at 04:50:48PM +0800, YingKun Meng wrote:
>> Hi all,
>>
>> This patchset adds support for Loongson I2S controller, and
>> introduce a ASoC machine driver for loongson platform.
>>
>> The Loongson I2S controller is available on Loongson
>> 7a2000/2k2000 chips, works as a PCI device. It has two
>> private DMA controllers used to playback and capture.
>> Each DMA controller has one channel.
>>
>> The ASoC machine driver adds support for audio device which
>> using loongson I2S controller to tranfser the audio data.
>> The audio device uses "PRP0001" as its ACPI device ID, which
>> provides a means to use the existing DT-compatible device
>> identification in ACPI.
> The code here all looks broadly good - I did have a few review comments
> that I sent in reply to the individual patches but they're more
> stylistic than anything too substantial.


Thanks


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-13 12:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-12  8:50 [ PATCH v2 0/3] Add Loongson I2S controller support YingKun Meng
2023-06-12 19:07 ` Mark Brown
2023-06-13 12:45   ` Yingkun Meng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).