From: Neil Armstrong <narmstrong@baylibre.com>
To: Robert Foss <robert.foss@linaro.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
paul@crapouillou.net, Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Phong LE <ple@baylibre.com>
Subject: Re: [PATCH v3 2/3] drm: bridge: add it66121 driver
Date: Wed, 14 Apr 2021 08:13:08 +0200 [thread overview]
Message-ID: <3266977b-9d19-c81d-6fd7-b6fa0714b1ef@baylibre.com> (raw)
In-Reply-To: <CAG3jFysFb+y6ymXsBQatuwtPEYRTBnWTku0EpmNyR2gR5a=Y2w@mail.gmail.com>
Hi Rob,
Le 13/04/2021 à 22:21, Robert Foss a écrit :
> Hey Neil & Phong,
>
> Thanks for submitting this series!
>
>> +
>> +static const struct drm_bridge_funcs it66121_bridge_funcs = {
>> + .attach = it66121_bridge_attach,
>> + .enable = it66121_bridge_enable,
>> + .disable = it66121_bridge_disable,
>> + .mode_set = it66121_bridge_mode_set,
>> + .mode_valid = it66121_bridge_mode_valid,
>> + .detect = it66121_bridge_detect,
>> + .get_edid = it66121_bridge_get_edid,
>> + .atomic_get_output_bus_fmts = it66121_bridge_atomic_get_output_bus_fmts,
>> + .atomic_get_input_bus_fmts = it66121_bridge_atomic_get_input_bus_fmts,
>> +};
>
> I would like to see an implementation of HPD, since it is supported by
> the hardware[1] (and required by the documentation). IRQ status bit 0
> seems to be the responsible for notifying us about hot plug detection
> events.
It's implemented in the IRQ handler with the IT66121_INT_STATUS1_HPD_STATUS event.
Neil
>
> [1] https://rockchip.fr/radxa/IT66121_Programming_Guide.v1.05.pdf
>
>
> Rob.
>
next prev parent reply other threads:[~2021-04-14 6:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 15:46 [PATCH v3 0/3] drm/bridge: Add it66121 driver Neil Armstrong
2021-04-12 15:46 ` [PATCH v3 1/3] dt-bindings: display: bridge: add it66121 bindings Neil Armstrong
2021-04-13 15:11 ` Rob Herring
2021-04-13 16:03 ` Laurent Pinchart
2021-04-14 8:14 ` Neil Armstrong
2021-04-13 18:09 ` Paul Cercueil
2021-04-13 20:17 ` Laurent Pinchart
2021-04-12 15:46 ` [PATCH v3 2/3] drm: bridge: add it66121 driver Neil Armstrong
2021-04-13 20:21 ` Robert Foss
2021-04-14 6:13 ` Neil Armstrong [this message]
2021-04-14 8:06 ` Robert Foss
2021-04-14 8:08 ` Neil Armstrong
2021-04-14 8:16 ` Laurent Pinchart
2021-04-14 15:37 ` Neil Armstrong
2021-04-13 20:56 ` Paul Cercueil
2021-04-14 6:17 ` Neil Armstrong
2021-04-14 8:15 ` Paul Cercueil
2021-04-14 17:35 ` Paul Cercueil
2021-04-15 8:54 ` Neil Armstrong
2021-04-12 15:46 ` [PATCH v3 3/3] MAINTAINERS: add it66121 HDMI bridge driver entry Neil Armstrong
2021-04-12 15:47 ` Neil Armstrong
2021-04-13 17:53 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3266977b-9d19-c81d-6fd7-b6fa0714b1ef@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=ple@baylibre.com \
--cc=robert.foss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).