* [PATCH v3 1/2] arm64: dts: allwinner: pinephone: Retain LEDs state in suspend
@ 2024-03-17 0:39 Aren Moynihan
2024-03-17 0:39 ` [PATCH v3 2/2] arm64: dts: allwinner: pinephone: add multicolor LED node Aren Moynihan
0 siblings, 1 reply; 4+ messages in thread
From: Aren Moynihan @ 2024-03-17 0:39 UTC (permalink / raw
To: linux-kernel
Cc: Conor Dooley, Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai,
Pavel Machek, devicetree, linux-sunxi, Jernej Skrabec, Miles Alan,
Samuel Holland, linux-arm-kernel, Ondrej Jirman, Aren Moynihan
From: Miles Alan <m@milesalan.com>
Allows user to set a LED before entering suspend to know that
the phone is still on (or could be used for notifications etc).
Signed-off-by: Miles Alan <m@milesalan.com>
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Aren Moynihan <aren@peacevolution.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
The previous revision can be found at:
https://lore.kernel.org/lkml/20240206185400.596979-1-aren@peacevolution.org/
(no changes since v1)
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
index 87847116ab6d..ad2476ee01e4 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
@@ -43,18 +43,21 @@ led-0 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_BLUE>;
gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */
+ retain-state-suspended;
};
led-1 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_GREEN>;
gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */
+ retain-state-suspended;
};
led-2 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_RED>;
gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */
+ retain-state-suspended;
};
};
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 2/2] arm64: dts: allwinner: pinephone: add multicolor LED node
2024-03-17 0:39 [PATCH v3 1/2] arm64: dts: allwinner: pinephone: Retain LEDs state in suspend Aren Moynihan
@ 2024-03-17 0:39 ` Aren Moynihan
2024-03-26 22:44 ` Jernej Škrabec
0 siblings, 1 reply; 4+ messages in thread
From: Aren Moynihan @ 2024-03-17 0:39 UTC (permalink / raw
To: linux-kernel
Cc: Conor Dooley, Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai,
Pavel Machek, devicetree, linux-sunxi, Jernej Skrabec, Miles Alan,
Samuel Holland, linux-arm-kernel, Ondrej Jirman, Aren Moynihan
The red, green, and blue LEDs currently in the device tree represent a
single RGB LED on the front of the PinePhone.
Signed-off-by: Aren Moynihan <aren@peacevolution.org>
---
Changes in v3:
- add function property back to individual LED nodes to minimize
breaking changes
Changes in v2:
- remove function property from individual LED nodes
.../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
index ad2476ee01e4..6eab61a12cd8 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
@@ -39,21 +39,21 @@ chosen {
leds {
compatible = "gpio-leds";
- led-0 {
+ led0: led-0 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_BLUE>;
gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */
retain-state-suspended;
};
- led-1 {
+ led1: led-1 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_GREEN>;
gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */
retain-state-suspended;
};
- led-2 {
+ led2: led-2 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_RED>;
gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */
@@ -61,6 +61,13 @@ led-2 {
};
};
+ multi-led {
+ compatible = "leds-group-multicolor";
+ color = <LED_COLOR_ID_RGB>;
+ function = LED_FUNCTION_INDICATOR;
+ leds = <&led0>, <&led1>, <&led2>;
+ };
+
reg_ps: ps-regulator {
compatible = "regulator-fixed";
regulator-name = "ps";
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: allwinner: pinephone: add multicolor LED node
2024-03-17 0:39 ` [PATCH v3 2/2] arm64: dts: allwinner: pinephone: add multicolor LED node Aren Moynihan
@ 2024-03-26 22:44 ` Jernej Škrabec
2024-04-15 21:07 ` Jernej Škrabec
0 siblings, 1 reply; 4+ messages in thread
From: Jernej Škrabec @ 2024-03-26 22:44 UTC (permalink / raw
To: linux-kernel, Aren Moynihan
Cc: Conor Dooley, Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai,
Pavel Machek, devicetree, linux-sunxi, Miles Alan, Samuel Holland,
linux-arm-kernel, Ondrej Jirman, Aren Moynihan
Dne nedelja, 17. marec 2024 ob 01:39:29 CET je Aren Moynihan napisal(a):
> The red, green, and blue LEDs currently in the device tree represent a
> single RGB LED on the front of the PinePhone.
>
> Signed-off-by: Aren Moynihan <aren@peacevolution.org>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: allwinner: pinephone: add multicolor LED node
2024-03-26 22:44 ` Jernej Škrabec
@ 2024-04-15 21:07 ` Jernej Škrabec
0 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2024-04-15 21:07 UTC (permalink / raw
To: linux-kernel, Aren Moynihan
Cc: Conor Dooley, Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai,
Pavel Machek, devicetree, linux-sunxi, Miles Alan, Samuel Holland,
linux-arm-kernel, Ondrej Jirman, Aren Moynihan
Dne torek, 26. marec 2024 ob 23:44:39 GMT +2 je Jernej Škrabec napisal(a):
> Dne nedelja, 17. marec 2024 ob 01:39:29 CET je Aren Moynihan napisal(a):
> > The red, green, and blue LEDs currently in the device tree represent a
> > single RGB LED on the front of the PinePhone.
> >
> > Signed-off-by: Aren Moynihan <aren@peacevolution.org>
>
> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Applied both, thanks!
Best regards,
Jernej
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-15 21:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-17 0:39 [PATCH v3 1/2] arm64: dts: allwinner: pinephone: Retain LEDs state in suspend Aren Moynihan
2024-03-17 0:39 ` [PATCH v3 2/2] arm64: dts: allwinner: pinephone: add multicolor LED node Aren Moynihan
2024-03-26 22:44 ` Jernej Škrabec
2024-04-15 21:07 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).