From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80FF6C7EE25 for ; Fri, 9 Jun 2023 10:14:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241281AbjFIKOQ (ORCPT ); Fri, 9 Jun 2023 06:14:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240167AbjFIKNk (ORCPT ); Fri, 9 Jun 2023 06:13:40 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF3064490; Fri, 9 Jun 2023 03:03:16 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab] (unknown [IPv6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id B39A26606F2A; Fri, 9 Jun 2023 11:03:14 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686304995; bh=Wgiw9IDIUgq3grTnCDHIQrPGKksKz/AqHv9EJoBFhRQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DxclosCgyQHuEe1lK16qHh+kHD7U5qtLaVKsJpkQ9i4QyqE7toKpA0fMGHbTBj7n1 Uk53Ul4OOn0Q6MUaur1cZWmX6OKy8p7Gck/4dolYZCgtztNWEF6zZILGnSklYjrpVu J3duoaGgdCxiOdnQQxiSNUoOjc/H+/6aqDPh7hpRI9ZR2c2fvuCd2x1mLWq9sxrls0 k6NEBW7ZVbakWhR3iD9R0TLhv7+ozV0pcvteAJ1xF/vObld42lTN7vKHhJw/X/tni9 bMLHFjFDsvlB3q05u1MaE3sGcrbl88xcnUTA/NdIoOLa/rhfQ8U0b4VaBoLKImy9bv 6S7hqsc7Q+Aww== Message-ID: <33c2f13a-294c-fc69-55a3-2a7aef26f954@collabora.com> Date: Fri, 9 Jun 2023 12:03:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 8/9] regulator: mt6358: Add output voltage fine tuning to variable LDOs Content-Language: en-US To: Chen-Yu Tsai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Liam Girdwood , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230609083009.2822259-1-wenst@chromium.org> <20230609083009.2822259-9-wenst@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20230609083009.2822259-9-wenst@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 09/06/23 10:30, Chen-Yu Tsai ha scritto: > Some of the LDO regulators in the MT6358/MT6366 have sparsely populated > voltage tables, supported by custom get/set operators. While it works, > it requires more code and an extra field to store the lookup table. > These LDOs also have fine voltage calibration settings that can slightly > boost the output voltage from 0 mV to 100 mV, in 10 mV increments. > > These combined could be modeled as a pickable set of linear ranges. The > coarse voltage setting is modeled as the range selector, while each > range has 11 selectors, starting from the range's base voltage, up to > +100 mV, in 10mV increments. > Reviewed-by: AngeloGioacchino Del Regno