* [PATCH v2] test_firmware: Use kstrtobool() instead of strtobool()
@ 2023-01-14 9:22 Christophe JAILLET
2023-01-17 15:33 ` Luis Chamberlain
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2023-01-14 9:22 UTC (permalink / raw
To: gregkh, russell.h.weight, mcgrof, tianfei.zhang, shaozhengchao,
colin.i.king, error27
Cc: linux-kernel, kernel-janitors, Christophe JAILLET
strtobool() is the same as kstrtobool().
However, the latter is more used within the kernel.
In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.
While at it, include the corresponding header file (<linux/kstrtox.h>)
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
This patch was already sent as a part of a serie ([1]) that axed all usages
of strtobool().
Most of the patches have been merged in -next.
I synch'ed with latest -next and re-send the remaining ones as individual
patches.
Note that the first version was sent to no-one, only mailing lists,
because "get_maintainer.pl --nogit-fallback" returns an empty list.
Changes in v2:
- No change
[1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/
---
lib/test_firmware.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/test_firmware.c b/lib/test_firmware.c
index e207bc08820d..3632cf62c812 100644
--- a/lib/test_firmware.c
+++ b/lib/test_firmware.c
@@ -22,6 +22,7 @@
#include <linux/slab.h>
#include <linux/uaccess.h>
#include <linux/delay.h>
+#include <linux/kstrtox.h>
#include <linux/kthread.h>
#include <linux/vmalloc.h>
#include <linux/efi_embedded_fw.h>
@@ -358,7 +359,7 @@ static int test_dev_config_update_bool(const char *buf, size_t size,
int ret;
mutex_lock(&test_fw_mutex);
- if (strtobool(buf, cfg) < 0)
+ if (kstrtobool(buf, cfg) < 0)
ret = -EINVAL;
else
ret = size;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] test_firmware: Use kstrtobool() instead of strtobool()
2023-01-14 9:22 [PATCH v2] test_firmware: Use kstrtobool() instead of strtobool() Christophe JAILLET
@ 2023-01-17 15:33 ` Luis Chamberlain
0 siblings, 0 replies; 2+ messages in thread
From: Luis Chamberlain @ 2023-01-17 15:33 UTC (permalink / raw
To: Christophe JAILLET
Cc: gregkh, russell.h.weight, tianfei.zhang, shaozhengchao,
colin.i.king, error27, linux-kernel, kernel-janitors
On Sat, Jan 14, 2023 at 10:22:03AM +0100, Christophe JAILLET wrote:
> strtobool() is the same as kstrtobool().
> However, the latter is more used within the kernel.
>
> In order to remove strtobool() and slightly simplify kstrtox.h, switch to
> the other function name.
>
> While at it, include the corresponding header file (<linux/kstrtox.h>)
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-17 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-14 9:22 [PATCH v2] test_firmware: Use kstrtobool() instead of strtobool() Christophe JAILLET
2023-01-17 15:33 ` Luis Chamberlain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).