* [PATCH] ice: Unbind the workqueue
@ 2024-09-22 22:24 Frederic Weisbecker
2024-09-23 8:57 ` Przemek Kitszel
0 siblings, 1 reply; 5+ messages in thread
From: Frederic Weisbecker @ 2024-09-22 22:24 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel; +Cc: LKML, Frederic Weisbecker, Larysa Zaremba
The ice workqueue doesn't seem to rely on any CPU locality and should
therefore be able to run on any CPU. In practice this is already
happening through the unbound ice_service_timer that may fire anywhere
and queue the workqueue accordingly to any CPU.
Make this official so that the ice workqueue is only ever queued to
housekeeping CPUs on nohz_full.
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index ea780d468579..70990f42ac05 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -5924,7 +5924,7 @@ static int __init ice_module_init(void)
ice_adv_lnk_speed_maps_init();
- ice_wq = alloc_workqueue("%s", 0, 0, KBUILD_MODNAME);
+ ice_wq = alloc_workqueue("%s", WQ_UNBOUND, 0, KBUILD_MODNAME);
if (!ice_wq) {
pr_err("Failed to create workqueue\n");
return status;
--
2.46.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ice: Unbind the workqueue
2024-09-22 22:24 [PATCH] ice: Unbind the workqueue Frederic Weisbecker
@ 2024-09-23 8:57 ` Przemek Kitszel
2024-09-23 18:28 ` Tony Nguyen
0 siblings, 1 reply; 5+ messages in thread
From: Przemek Kitszel @ 2024-09-23 8:57 UTC (permalink / raw)
To: Frederic Weisbecker, Tony Nguyen
Cc: LKML, Larysa Zaremba, intel-wired-lan@lists.osuosl.org
On 9/23/24 00:24, Frederic Weisbecker wrote:
> The ice workqueue doesn't seem to rely on any CPU locality and should
> therefore be able to run on any CPU. In practice this is already
> happening through the unbound ice_service_timer that may fire anywhere
> and queue the workqueue accordingly to any CPU.
>
> Make this official so that the ice workqueue is only ever queued to
> housekeeping CPUs on nohz_full.
>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index ea780d468579..70990f42ac05 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5924,7 +5924,7 @@ static int __init ice_module_init(void)
>
> ice_adv_lnk_speed_maps_init();
>
> - ice_wq = alloc_workqueue("%s", 0, 0, KBUILD_MODNAME);
> + ice_wq = alloc_workqueue("%s", WQ_UNBOUND, 0, KBUILD_MODNAME);
> if (!ice_wq) {
> pr_err("Failed to create workqueue\n");
> return status;
Thank you for the patch, it would make sense for our iwl-next tree,
with such assumption:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
@Tony, do you want it resent with target tree in the subject?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ice: Unbind the workqueue
2024-09-23 8:57 ` Przemek Kitszel
@ 2024-09-23 18:28 ` Tony Nguyen
2024-10-07 10:29 ` Frederic Weisbecker
0 siblings, 1 reply; 5+ messages in thread
From: Tony Nguyen @ 2024-09-23 18:28 UTC (permalink / raw)
To: Przemek Kitszel, Frederic Weisbecker
Cc: LKML, Larysa Zaremba, intel-wired-lan@lists.osuosl.org
On 9/23/2024 1:57 AM, Przemek Kitszel wrote:
> On 9/23/24 00:24, Frederic Weisbecker wrote:
>> The ice workqueue doesn't seem to rely on any CPU locality and should
>> therefore be able to run on any CPU. In practice this is already
>> happening through the unbound ice_service_timer that may fire anywhere
>> and queue the workqueue accordingly to any CPU.
>>
>> Make this official so that the ice workqueue is only ever queued to
>> housekeeping CPUs on nohz_full.
>>
>> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
>> ---
>> drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
>> b/drivers/net/ethernet/intel/ice/ice_main.c
>> index ea780d468579..70990f42ac05 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_main.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
>> @@ -5924,7 +5924,7 @@ static int __init ice_module_init(void)
>> ice_adv_lnk_speed_maps_init();
>> - ice_wq = alloc_workqueue("%s", 0, 0, KBUILD_MODNAME);
>> + ice_wq = alloc_workqueue("%s", WQ_UNBOUND, 0, KBUILD_MODNAME);
>> if (!ice_wq) {
>> pr_err("Failed to create workqueue\n");
>> return status;
>
> Thank you for the patch, it would make sense for our iwl-next tree,
> with such assumption:
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>
> @Tony, do you want it resent with target tree in the subject?
No, I can apply this as-is but please remember to designate a tree for
future patches.
Thanks,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ice: Unbind the workqueue
2024-09-23 18:28 ` Tony Nguyen
@ 2024-10-07 10:29 ` Frederic Weisbecker
2024-10-07 21:42 ` Tony Nguyen
0 siblings, 1 reply; 5+ messages in thread
From: Frederic Weisbecker @ 2024-10-07 10:29 UTC (permalink / raw)
To: Tony Nguyen
Cc: Przemek Kitszel, LKML, Larysa Zaremba,
intel-wired-lan@lists.osuosl.org
Le Mon, Sep 23, 2024 at 11:28:20AM -0700, Tony Nguyen a écrit :
>
>
> On 9/23/2024 1:57 AM, Przemek Kitszel wrote:
> > On 9/23/24 00:24, Frederic Weisbecker wrote:
> > > The ice workqueue doesn't seem to rely on any CPU locality and should
> > > therefore be able to run on any CPU. In practice this is already
> > > happening through the unbound ice_service_timer that may fire anywhere
> > > and queue the workqueue accordingly to any CPU.
> > >
> > > Make this official so that the ice workqueue is only ever queued to
> > > housekeeping CPUs on nohz_full.
> > >
> > > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> > > ---
> > > drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
> > > b/drivers/net/ethernet/intel/ice/ice_main.c
> > > index ea780d468579..70990f42ac05 100644
> > > --- a/drivers/net/ethernet/intel/ice/ice_main.c
> > > +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> > > @@ -5924,7 +5924,7 @@ static int __init ice_module_init(void)
> > > ice_adv_lnk_speed_maps_init();
> > > - ice_wq = alloc_workqueue("%s", 0, 0, KBUILD_MODNAME);
> > > + ice_wq = alloc_workqueue("%s", WQ_UNBOUND, 0, KBUILD_MODNAME);
> > > if (!ice_wq) {
> > > pr_err("Failed to create workqueue\n");
> > > return status;
> >
> > Thank you for the patch, it would make sense for our iwl-next tree,
> > with such assumption:
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> >
> > @Tony, do you want it resent with target tree in the subject?
>
> No, I can apply this as-is but please remember to designate a tree for
> future patches.
Sorry I didn't know about any tree. I can't even find where iwl-next is
hosted.
Thanks.
> Thanks,
> Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ice: Unbind the workqueue
2024-10-07 10:29 ` Frederic Weisbecker
@ 2024-10-07 21:42 ` Tony Nguyen
0 siblings, 0 replies; 5+ messages in thread
From: Tony Nguyen @ 2024-10-07 21:42 UTC (permalink / raw)
To: Frederic Weisbecker
Cc: Przemek Kitszel, LKML, Larysa Zaremba,
intel-wired-lan@lists.osuosl.org
On 10/7/2024 3:29 AM, Frederic Weisbecker wrote:
> Le Mon, Sep 23, 2024 at 11:28:20AM -0700, Tony Nguyen a écrit :
...
>>> Thank you for the patch, it would make sense for our iwl-next tree,
>>> with such assumption:
>>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>>>
>>> @Tony, do you want it resent with target tree in the subject?
>>
>> No, I can apply this as-is but please remember to designate a tree for
>> future patches.
>
> Sorry I didn't know about any tree. I can't even find where iwl-next is
> hosted.
The information is here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/MAINTAINERS#n11413
For bug fixes, net-queue tree is used and next-queue for other content
(dev-queue branch for both).
I did find that I crossed this patch with another and found that the
initial send of this did not include the Intel Wired LAN list. I'll
resend the patch to include the proper list so that patchworks can pick
this up.
Thanks,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-07 21:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-22 22:24 [PATCH] ice: Unbind the workqueue Frederic Weisbecker
2024-09-23 8:57 ` Przemek Kitszel
2024-09-23 18:28 ` Tony Nguyen
2024-10-07 10:29 ` Frederic Weisbecker
2024-10-07 21:42 ` Tony Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).