From: Jijie Shao <shaojijie@huawei.com>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>, netdev@vger.kernel.org
Cc: <shaojijie@huawei.com>, <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>
Subject: Re: [PATCH net-next] net: hns3: flower: validate control flags
Date: Wed, 24 Apr 2024 21:04:17 +0800 [thread overview]
Message-ID: <3d245976-6509-4260-b232-04637c644350@huawei.com> (raw)
In-Reply-To: <20240422152717.175659-1-ast@fiberby.net>
on 2024/4/22 23:27, Asbjørn Sloth Tønnesen wrote:
> This driver currently doesn't support any control flags.
>
> Use flow_rule_has_control_flags() to check for control flags,
> such as can be set through `tc flower ... ip_flags frag`.
>
> In case any control flags are masked, flow_rule_has_control_flags()
> sets a NL extended error message, and we return -EOPNOTSUPP.
>
> Also propagate extack to hclge_get_cls_key_ip(), and convert it to
> return error code.
>
> Only compile-tested.
>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> ---
Thanks,
Tested-by: Jijie Shao<shaojijie@huawei.com>
next prev parent reply other threads:[~2024-04-24 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 15:27 [PATCH net-next] net: hns3: flower: validate control flags Asbjørn Sloth Tønnesen
2024-04-23 11:52 ` Jiri Pirko
2024-04-24 13:04 ` Jijie Shao [this message]
2024-04-25 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d245976-6509-4260-b232-04637c644350@huawei.com \
--to=shaojijie@huawei.com \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).