From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: amergnat@baylibre.com, broonie@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, djakov@kernel.org,
gustavoars@kernel.org, henryc.chen@mediatek.com,
keescook@chromium.org, kernel@collabora.com,
krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-pm@vger.kernel.org, matthias.bgg@gmail.com,
robh@kernel.org, wenst@chromium.org
Subject: Re: [PATCH v5 6/7] regulator: Add refactored mtk-dvfsrc-regulator driver
Date: Wed, 24 Apr 2024 14:54:37 +0200 [thread overview]
Message-ID: <44257461-b9df-4107-8684-2d9c1b7ad6ba@collabora.com> (raw)
In-Reply-To: <6bd66ba2-7fcc-4981-a2cd-d4500540da76@collabora.com>
Il 24/04/24 14:53, AngeloGioacchino Del Regno ha scritto:
> Il 24/04/24 12:35, Christophe JAILLET ha scritto:
>> Le 24/04/2024 à 11:54, AngeloGioacchino Del Regno a écrit :
>>> The previous driver never worked, and never got even compiled because
>>> it was missing the DVFSRC driver entirely, including needed neaders.
>>>
>>> This is a full (or nearly full) refactoring of the MediaTek DVFSRC
>>> controlled Regulators driver, retaining support for the MT6873, MT8183
>>> and MT8192 SoC, and adding MT8195.
>>>
>>> As part of the refactoring, this driver is now probed using its own
>>> devicetree compatible, as this is a child of the main DVFSRC driver
>>> and gets probed as a subnode of that.
>>>
>>> Reviewed-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>> Signed-off-by: AngeloGioacchino Del Regno
>>> <angelogioacchino.delregno-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
>>> ---
>>> drivers/regulator/mtk-dvfsrc-regulator.c | 196 +++++++++++++++++++++++
>>> 1 file changed, 196 insertions(+)
>>> create mode 100644 drivers/regulator/mtk-dvfsrc-regulator.c
>>>
>>
>> ...
>>
>>> +static int dvfsrc_vcore_regulator_probe(struct platform_device *pdev)
>>> +{
>>> + struct regulator_config config = { .dev = &pdev->dev };
>>> + const struct dvfsrc_regulator_pdata *pdata;
>>> + int i;
>>> +
>>> + pdata = device_get_match_data(&pdev->dev);
>>> + if (!pdata)
>>> + return -EINVAL;
>>> +
>>> + for (i = 0; i < pdata->size; i++) {
>>> + struct regulator_desc *vrdesc = &pdata->descs[i];
>>> + struct regulator_dev *rdev;
>>> +
>>> + rdev = devm_regulator_register(&pdev->dev, vrdesc, &config);
>>> + if (IS_ERR(rdev)) {
>>> + dev_err(&pdev->dev, "failed to register %s\n", vrdesc->name);
>>> + return PTR_ERR(rdev);
>>
>> Hi,
>>
>> Nit: (in case of v6)
>>
>> dev_err_probe()?
>>
>
> I don't think there's going to be any v6, as there's nothing else to do on
> this series.
>
> Mark, if you want to fix this up before applying, that should then be, exactly
>
> rdev = devm_regulator_register(&pdev->dev, vrdesc, &config);
> if (IS_ERR(rdev))
> dev_err_probe(&pdev->dev, PTR_ERR(rdev),
> "failed to register %s\n", vrdesc->name);
>
Uff! Forgot the return!
rdev = devm_regulator_register(&pdev->dev, vrdesc, &config);
if (IS_ERR(rdev))
return dev_err_probe(&pdev->dev, PTR_ERR(rdev),
"failed to register %s\n", vrdesc->name);
:)))
> Otherwise, nevermind I guess..?
>
> Cheers,
> Angelo
>
>
> _______________________________________________
> Kernel mailing list -- kernel@mailman.collabora.com
> To unsubscribe send an email to kernel-leave@mailman.collabora.com
> This list is managed by https://mailman.collabora.com
next prev parent reply other threads:[~2024-04-24 12:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 9:54 [PATCH v5 0/7] MediaTek DVFSRC Bus Bandwidth and Regulator knobs AngeloGioacchino Del Regno
2024-04-24 9:54 ` [PATCH v5 1/7] dt-bindings: regulator: Add bindings for MediaTek DVFSRC Regulators AngeloGioacchino Del Regno
2024-04-24 9:54 ` [PATCH v5 2/7] dt-bindings: interconnect: Add MediaTek EMI Interconnect bindings AngeloGioacchino Del Regno
2024-04-24 9:54 ` [PATCH v5 3/7] dt-bindings: soc: mediatek: Add DVFSRC bindings for MT8183 and MT8195 AngeloGioacchino Del Regno
2024-04-24 9:54 ` [PATCH v5 4/7] soc: mediatek: Add MediaTek DVFS Resource Collector (DVFSRC) driver AngeloGioacchino Del Regno
2024-04-24 19:04 ` Nathan Chancellor
2024-04-29 8:08 ` AngeloGioacchino Del Regno
2024-04-29 14:13 ` Georgi Djakov
2024-04-24 9:54 ` [PATCH v5 5/7] regulator: Remove mtk-dvfsrc-regulator.c AngeloGioacchino Del Regno
2024-04-24 9:54 ` [PATCH v5 6/7] regulator: Add refactored mtk-dvfsrc-regulator driver AngeloGioacchino Del Regno
2024-04-24 10:35 ` Christophe JAILLET
2024-04-24 12:53 ` AngeloGioacchino Del Regno
2024-04-24 12:54 ` AngeloGioacchino Del Regno [this message]
2024-04-24 9:54 ` [PATCH v5 7/7] interconnect: mediatek: Add MediaTek MT8183/8195 EMI Interconnect driver AngeloGioacchino Del Regno
2024-05-03 11:53 ` Georgi Djakov
2024-05-06 10:49 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44257461-b9df-4107-8684-2d9c1b7ad6ba@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=amergnat@baylibre.com \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=gustavoars@kernel.org \
--cc=henryc.chen@mediatek.com \
--cc=keescook@chromium.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).