From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752361AbcDROIv (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Apr 2016 10:08:51 -0400
Received: from mout.kundenserver.de ([212.227.126.133]:58407 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751497AbcDROIt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Apr 2016 10:08:49 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>, Denys Vlasenko <dvlasenk@redhat.com>,
        James Bottomley <James.Bottomley@hansenpartnership.com>,
        Thomas Graf <tgraf@suug.ch>, Peter Zijlstra <peterz@infradead.org>,
        David Rientjes <rientjes@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-scsi <linux-scsi@vger.kernel.org>,
        jamborm@gcc.gnu.org
Subject: Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)
Date: Mon, 18 Apr 2016 16:07:51 +0200
Message-ID: <4545519.Kr6IHPvbv3@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20160418133932.cnpxai32qn665un3@treble>
References: <20160413151500.tate3u6trg4agugo@treble> <20160416090332.GA30613@gmail.com> <20160418133932.cnpxai32qn665un3@treble>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:/PzzruSKGP39GCgHx+0NnWA9AlkxsrSY/8SUkj2mrRQLh11O3nK
 04g69+AA5gT/rhzvm+aDpzWOYSfcAlO2Ed9u9EyKUpb3g2FNLwq02PTYssfq9ZAaxxlfjVz
 A05nqf5GGO0SYQrdqDtaCxjTBdYC89HGK7Gav9xKBvPxwkVC9GtHpfPPlRICNGB5B+Y/zrJ
 +VleKnU1r6q9segD6NE4w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:PGqvCTYfH+g=:iRARxaMiN9Ol8uo+h3mnOz
 sDfQ2mFMr1HlU0ONLYSPrmKTHGzq8dApQ/tp+8XN71UGaQSNC/wyWRVRs+EPZ9G6mS+PnW7yV
 k0OrcFjiF9Ue95V8Cyv1luHxdIDExXpoI6IlIS4F/6hyWHahoiKFaGP/F+qyOTVT/Zbjl2n6i
 8rrvp1GhBvPkFnvvNuQxGoNRr21PvQpwenuJC3Dkco8peCnbAGvwYl8bw5w4kiL+mswd9MpJe
 wxVxWl9ujLyCKPQiBQAKJPdYo7yWsPsSzAfZPhsqIydHfmzEnWmL5IhajVnNN6plRoX8y+5Sb
 DyTKOj1prTqJdk3ZVVFgreyoRWw9zwsCt77nlvl65kk++rItDs8qoBlj7nbVLpOjxIhJPCiHk
 cL72Vnq+osrh86VXoxRQfpmxPC7Yoa3A26nOTKgcToL4TOsWX+42p0iXWKRrHP1fQT2dI22L3
 NVmLgB4/8ZOpdYkpJ4/ZSDulGmlaCJYG4hm//ihGRcNZXbyc2YLhRYXyKkMbypDfP2Zp+BxxA
 H49q6HKeBlgttbx1EgLnFqFi0NqAOud8G4B/HeB6GVIlzsHlEahIZjVJ/8t/c84h2sebxj7Qg
 0f129AlSXSfx5lWV88zZ7D7sYKOKf6c/tanoZpiLXs3aIt415poCsvTLIswlGFmrnV1WSJzEP
 oA190UZbjzQNQIsIfw4R36KnWqbiEFO6YvveL/M2NQUFxNG36hBAVLVD+GgrqM+DCH0YpNy2X
 uAkG33AwDrurzvGq
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 18 April 2016 08:39:32 Josh Poimboeuf wrote:
> 
> I agree.  So how should we work around the bug in this case?  There have
> been several suggestions:
> 
> - change wwn_to_u64() to __always_inline
> 
> - change qla2x00_get_host_fabric_name() to skip the unnecessary call to
>   wwn_to_u64()
> 
> - revert one of the two commits:
>   bc27fb68aaad ("include/uapi/linux/byteorder, swab: force inlining of some byteswap operations")
>   ef3fb2422ffe ("scsi: fc: use get/put_unaligned64 for wwn access")

What about the patch to change get_unaligned_be64() that I posted?

I think we want to merge that anyway, I just don't know if that helps
with this particular problem as well.

	Arnd