* [PATCH] get_maintainer: don't remind about no git repo when --nogit is used
@ 2022-01-02 3:14 Randy Dunlap
2022-01-02 5:28 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-01-02 3:14 UTC (permalink / raw
To: linux-kernel; +Cc: Randy Dunlap, Joe Perches, Andrew Morton
When --nogit is used with scripts/get_maintainer.pl, the script
spews 4 lines of unnecessary information (noise). Do not print those
lines when --nogit is specified.
This change removes the printing of these 4 lines:
./scripts/get_maintainer.pl: No supported VCS found. Add --nogit to options?
Using a git repository produces better results.
Try Linus Torvalds' latest git repository using:
git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
scripts/get_maintainer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20211224.orig/scripts/get_maintainer.pl
+++ linux-next-20211224/scripts/get_maintainer.pl
@@ -1718,7 +1718,7 @@ sub vcs_exists {
%VCS_cmds = %VCS_cmds_hg;
return 2 if eval $VCS_cmds{"available"};
%VCS_cmds = ();
- if (!$printed_novcs) {
+ if (!$printed_novcs && $email_git) {
warn("$P: No supported VCS found. Add --nogit to options?\n");
warn("Using a git repository produces better results.\n");
warn("Try Linus Torvalds' latest git repository using:\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] get_maintainer: don't remind about no git repo when --nogit is used
2022-01-02 3:14 [PATCH] get_maintainer: don't remind about no git repo when --nogit is used Randy Dunlap
@ 2022-01-02 5:28 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2022-01-02 5:28 UTC (permalink / raw
To: Randy Dunlap, linux-kernel; +Cc: Andrew Morton
On Sat, 2022-01-01 at 19:14 -0800, Randy Dunlap wrote:
> When --nogit is used with scripts/get_maintainer.pl, the script
> spews 4 lines of unnecessary information (noise). Do not print those
> lines when --nogit is specified.
Seems sensible, thanks.
>
> This change removes the printing of these 4 lines:
>
> ./scripts/get_maintainer.pl: No supported VCS found. Add --nogit to options?
> Using a git repository produces better results.
> Try Linus Torvalds' latest git repository using:
> git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Joe Perches <joe@perches.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> scripts/get_maintainer.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20211224.orig/scripts/get_maintainer.pl
> +++ linux-next-20211224/scripts/get_maintainer.pl
> @@ -1718,7 +1718,7 @@ sub vcs_exists {
> %VCS_cmds = %VCS_cmds_hg;
> return 2 if eval $VCS_cmds{"available"};
> %VCS_cmds = ();
> - if (!$printed_novcs) {
> + if (!$printed_novcs && $email_git) {
> warn("$P: No supported VCS found. Add --nogit to options?\n");
> warn("Using a git repository produces better results.\n");
> warn("Try Linus Torvalds' latest git repository using:\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-02 5:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-02 3:14 [PATCH] get_maintainer: don't remind about no git repo when --nogit is used Randy Dunlap
2022-01-02 5:28 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).