From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbcDROWg (ORCPT ); Mon, 18 Apr 2016 10:22:36 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:59235 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751706AbcDROWe (ORCPT ); Mon, 18 Apr 2016 10:22:34 -0400 From: Arnd Bergmann To: Josh Poimboeuf Cc: Ingo Molnar , Denys Vlasenko , James Bottomley , Thomas Graf , Peter Zijlstra , David Rientjes , Andrew Morton , linux-kernel@vger.kernel.org, linux-scsi , jamborm@gcc.gnu.org Subject: Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations) Date: Mon, 18 Apr 2016 16:21:42 +0200 Message-ID: <5175460.GbO2sgX9fL@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160418141241.gcgfawrtnmfamz6t@treble> References: <20160413151500.tate3u6trg4agugo@treble> <4545519.Kr6IHPvbv3@wuerfel> <20160418141241.gcgfawrtnmfamz6t@treble> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:igoTsQCy2bFvJSSnGwH2xEloi0FCy2oIAJo1uqdLm2lvVFgArUg hEP107h1nVo+vkW32f127SCxmDoLFWsLbMBs+HQc/60XfbCBXJAOeRt8O220pFbFnU+6Fjo 9A5zG/XzmCVjsAppKHfQbgHB+PpSQmi/vQ3fkxRZlWToB+KhquXetF7onl5BF44c5IViiyp 3Co3YSDNVOkCBx9s+dcqQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:QhLfQalwk6s=:hNH/2OHD5hj0vqKicz5+1n J3V6ZuoYQokt7ISMp1D2n7zQszLLpxniI8qQX8UcJx66LNoKrK+6l+y8XcnRlMCeEFyYU5x/m JmiYA5gPz1LviuNjttpIWiX9EtRRymHb2dN6Mln+SUprVwtgWIjUVRQ3dIbsFqkWqoTWREMYt vXlCm9QSTl5nRd7ocmzfdXlt54UluNjw8eT8BNxCSFZIyaTMafPrSMajZZPpRzne5blGaha5K UjleEfTmRePa0ygkhYjC/pY+9DdSMneU4dAeQVFhQDgkx5XhWfalovch+MBW2bT6PV4CX3bZM H2XaVOMpxns/2xJutj0KUpkPidqMEzk0fuBM5Sp089Cj4iqb46ZMqnXWNq8OPQ8ypf/cjx9BJ wdXJq/r2iH5htAy5C19K6I7yXVQI1eW+kRljzK9qlV7XZkQ8dYM1Y0KFdm0RaUkOcQvj39WIq Je99YTzFbObeAclcEHs33gTEJU2PmFrogQyMZAuYpIXejT0r3iGMR9k35tNLb8nI7CeNeqyU3 WnE6CrTr5fWYJnuhwFwuxkCxtm6mzSCr826ikiGSE0/ungJRzvQ0WOozrP919o9ZOuta03pbI 9vYKznEQa2bkAi4SAatLz/ku5eYVgr0Lfe3Y3hi3zIWffKDAzInUeKmLjttsaDqmTzdrVzAyJ +uXYhDLS5++iMiBSv1+CXN+srYpdEWZlBFZ5wnUMzLL5uoVBSQ0tF+dscnIxBU72aw6y6V74I q9U4bGgr9JOkoQTt Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 18 April 2016 09:12:41 Josh Poimboeuf wrote: > On Mon, Apr 18, 2016 at 04:07:51PM +0200, Arnd Bergmann wrote: > > On Monday 18 April 2016 08:39:32 Josh Poimboeuf wrote: > > > > > > I agree. So how should we work around the bug in this case? There have > > > been several suggestions: > > > > > > - change wwn_to_u64() to __always_inline > > > > > > - change qla2x00_get_host_fabric_name() to skip the unnecessary call to > > > wwn_to_u64() > > > > > > - revert one of the two commits: > > > bc27fb68aaad ("include/uapi/linux/byteorder, swab: force inlining of some byteswap operations") > > > ef3fb2422ffe ("scsi: fc: use get/put_unaligned64 for wwn access") > > > > What about the patch to change get_unaligned_be64() that I posted? > > > > I think we want to merge that anyway, I just don't know if that helps > > with this particular problem as well. > > I replied to your other email about that -- it doesn't seem to help this > issue. > Ok, I see. I had problems with my mail server last week, your reply must have been a victim of that as I never saw it (found it on the web archive now). I'd vote for the wwn_to_u64 change then as it should prevent the same thing from happining in other drivers. I would prefer not to see ef3fb2422ffe reverted, as that works around another gcc-6 bug on ARM. Arnd