From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Robert Marko <robimarko@gmail.com>,
rafael@kernel.org, viresh.kumar@linaro.org, agross@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
ilia.lin@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [RESEND PATCH v2 2/2] cpufreq: qcom-nvmem: add support for IPQ8064
Date: Thu, 1 Jun 2023 18:07:17 +0300 [thread overview]
Message-ID: <517f8b82-1230-985a-811a-2100f0dd339e@linaro.org> (raw)
In-Reply-To: <647708e2.050a0220.514c7.feab@mx.google.com>
On 31/05/2023 04:36, Christian Marangi wrote:
> On Wed, May 31, 2023 at 05:03:01AM +0300, Dmitry Baryshkov wrote:
>> On 30/05/2023 19:58, Robert Marko wrote:
>>> From: Christian Marangi <ansuelsmth@gmail.com>
>>>
>>> IPQ8064 comes in 3 families:
>>> * IPQ8062 up to 1.0GHz
>>> * IPQ8064/IPQ8066/IPQ8068 up to 1.4GHz
>>> * IPQ8065/IPQ8069 up to 1.7Ghz
>>>
>>> So, in order to be able to share one OPP table, add support for
>>> IPQ8064 family based of SMEM SoC ID-s as speedbin fuse is always 0 on
>>> IPQ8064.
>>>
>>> Bit are set with the following logic:
>>> * IPQ8062 BIT 0
>>> * IPQ8064/IPQ8066/IPQ8068 BIT 1
>>> * IPQ8065/IPQ8069 BIT 2
>>>
>>> speed is never fused, only psv values are fused.
>>> Set speed to the versions to permit a unified opp table following
>>> this named opp:
>>>
>>> opp-microvolt-speed<SPEED_VALUE>-pvs<PSV_VALUE>-v0
>>>
>>> Example:
>>> - for ipq8062 psv2
>>> opp-microvolt-speed0-pvs2-v0 = < 925000 878750 971250>
>>> - for ipq8064 psv2
>>> opp-microvolt-speed2-pvs2-v0 = <925000 878750 971250>;
>>> - for ipq8065 psv2
>>> opp-microvolt-speed4-pvs2-v0 = <950000 902500 997500>;
>>>
>>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
>>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>>> ---
>>> drivers/cpufreq/qcom-cpufreq-nvmem.c | 73 +++++++++++++++++++++++++++-
>>> 1 file changed, 72 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
>>> index ce444b5962f2..c644138680ba 100644
>>> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
>>> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
>>> @@ -34,6 +34,10 @@
>>> #define IPQ8074_HAWKEYE_VERSION BIT(0)
>>> #define IPQ8074_ACORN_VERSION BIT(1)
>>> +#define IPQ8062_VERSION BIT(0)
>>> +#define IPQ8064_VERSION BIT(1)
>>> +#define IPQ8065_VERSION BIT(2)
>>
>> I think it would be more logical to change these defines to consecutive enum
>> instead of BIT(n) values. Another (and better in my opinion) option is to
>> drop versions completely (and remove speedN from the opp names) and to have
>> per-SoC tables in per-SoC dtsi files. There are already separate
>> ipq8064.dtsi, ipq8062.dtsi and ipq8065.dtsi files. It makes little sense to
>> overcomplicate the OPP tables.
>>
>
> That is what was used downstream but it was also wrong and against the
> normal implementation of this driver itself.
>
> OPP have opp-supported-hw just for the task with the principle of
> declaring a single table in dtsi and automatically select the right one.
>
> Using the implementation downstream (opp table in each dtsi) is actually
> worse as ipq8065 have 1.4ghz and not 1.2ghz and that can correctly be
> handled with opp-supported-hw (and this change) or using delete-property
> in dtsi (that I don't really like and it's ugly)
>
> Also this implementation would match what is currently secribed for the
> use of OPP in the documentation.
>
> Hope you can understand the reason of this change, the intention is to
> clear and trying to use standard OPP stuff instead of hacks in the DTS.
I'm fine with the opp-supported-hw part (I forgot that it is used by
default with the help of drv->versions). I do not like the idea of
encoding the same value into the -speedN part. If it is not needed, it's
better be dropped than using a semi-dummy value there.
So, I'd suggest to define an enum, use BIT(enum_value) for drv->versions
and drop the speed%d part.
Also, while we are at it, could you please define a schema for your opp
extensions? An example would make it easier to understand the bindings
(and will also provide a reference for possible other implementers).
>
>>> +
>>> struct qcom_cpufreq_drv;
>>> struct qcom_cpufreq_match_data {
>>> @@ -207,6 +211,69 @@ static int qcom_cpufreq_krait_name_version(struct device *cpu_dev,
>>> return ret;
>>> }
>>> +static int qcom_cpufreq_ipq8064_name_version(struct device *cpu_dev,
>>> + struct nvmem_cell *speedbin_nvmem,
>>> + char **pvs_name,
>>> + struct qcom_cpufreq_drv *drv)
>>> +{
>>> + int speed = 0, pvs = 0, pvs_ver = 0;
>>> + int msm_id, ret = 0;
>>> + u8 *speedbin;
>>> + size_t len;
>>> +
>>> + speedbin = nvmem_cell_read(speedbin_nvmem, &len);
>>> +
>>> + if (IS_ERR(speedbin))
>>> + return PTR_ERR(speedbin);
>>> +
>>> + switch (len) {
>>> + case 4:
>>> + get_krait_bin_format_a(cpu_dev, &speed, &pvs, &pvs_ver,
>>> + speedbin);
>>> + break;
>>> + default:
>>> + dev_err(cpu_dev, "Unable to read nvmem data. Defaulting to 0!\n");
>>> + ret = -ENODEV;
>>> + goto len_error;
>>> + }
>>> +
>>> + ret = qcom_smem_get_soc_id(&msm_id);
>>> + if (ret)
>>> + return ret;
>>> +
>>> + switch (msm_id) {
>>> + case QCOM_ID_IPQ8062:
>>> + drv->versions = IPQ8062_VERSION;
>>> + break;
>>> + case QCOM_ID_IPQ8064:
>>> + case QCOM_ID_IPQ8066:
>>> + case QCOM_ID_IPQ8068:
>>> + drv->versions = IPQ8064_VERSION;
>>> + break;
>>> + case QCOM_ID_IPQ8065:
>>> + case QCOM_ID_IPQ8069:
>>> + drv->versions = IPQ8065_VERSION;
>>> + break;
>>> + default:
>>> + dev_err(cpu_dev,
>>> + "SoC ID %u is not part of IPQ8064 family, limiting to 1.0GHz!\n",
>>> + msm_id);
>>> + drv->versions = IPQ8062_VERSION;
>>> + break;
>>> + }
>>> +
>>> + /*
>>> + * IPQ8064 speed is never fused. Only psv values are fused.
>>> + * Set speed to the versions to permit a unified opp table.
>>> + */
>>> + snprintf(*pvs_name, sizeof("speedXX-pvsXX-vXX"), "speed%d-pvs%d-v%d",
>>> + drv->versions, pvs, pvs_ver);
>>> +
>>> +len_error:
>>> + kfree(speedbin);
>>> + return ret;
>>> +}
>>> +
>>> static int qcom_cpufreq_ipq8074_name_version(struct device *cpu_dev,
>>> struct nvmem_cell *speedbin_nvmem,
>>> char **pvs_name,
>>> @@ -256,6 +323,10 @@ static const struct qcom_cpufreq_match_data match_data_qcs404 = {
>>> .genpd_names = qcs404_genpd_names,
>>> };
>>> +static const struct qcom_cpufreq_match_data match_data_ipq8064 = {
>>> + .get_version = qcom_cpufreq_ipq8064_name_version,
>>> +};
>>> +
>>> static const struct qcom_cpufreq_match_data match_data_ipq8074 = {
>>> .get_version = qcom_cpufreq_ipq8074_name_version,
>>> };
>>> @@ -404,7 +475,7 @@ static const struct of_device_id qcom_cpufreq_match_list[] __initconst = {
>>> { .compatible = "qcom,apq8096", .data = &match_data_kryo },
>>> { .compatible = "qcom,msm8996", .data = &match_data_kryo },
>>> { .compatible = "qcom,qcs404", .data = &match_data_qcs404 },
>>> - { .compatible = "qcom,ipq8064", .data = &match_data_krait },
>>> + { .compatible = "qcom,ipq8064", .data = &match_data_ipq8064 },
>>> { .compatible = "qcom,ipq8074", .data = &match_data_ipq8074 },
>>> { .compatible = "qcom,apq8064", .data = &match_data_krait },
>>> { .compatible = "qcom,msm8974", .data = &match_data_krait },
>>
>> --
>> With best wishes
>> Dmitry
>>
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-06-01 15:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 16:58 [RESEND PATCH v2 1/2] cpufreq: qcom-nvmem: add support for IPQ8074 Robert Marko
2023-05-30 16:58 ` [RESEND PATCH v2 2/2] cpufreq: qcom-nvmem: add support for IPQ8064 Robert Marko
2023-05-31 2:03 ` Dmitry Baryshkov
2023-05-31 1:36 ` Christian Marangi
2023-06-01 15:07 ` Dmitry Baryshkov [this message]
2023-06-09 14:20 ` Christian Marangi
2023-06-09 14:53 ` Dmitry Baryshkov
2023-06-09 15:02 ` Christian Marangi
2023-06-09 16:17 ` Dmitry Baryshkov
2023-05-31 8:40 ` Konrad Dybcio
2023-05-31 1:40 ` Christian Marangi
2023-05-31 2:08 ` [RESEND PATCH v2 1/2] cpufreq: qcom-nvmem: add support for IPQ8074 Dmitry Baryshkov
2023-06-01 12:55 ` Kathiravan T
2023-06-01 13:08 ` Konrad Dybcio
2023-06-01 13:10 ` Robert Marko
2023-06-01 13:24 ` Kathiravan T
2023-06-01 14:49 ` Kathiravan T
2023-06-01 14:55 ` Robert Marko
2023-06-02 8:57 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517f8b82-1230-985a-811a-2100f0dd339e@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=ilia.lin@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robimarko@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).