From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761660AbbBJEGU (ORCPT ); Mon, 9 Feb 2015 23:06:20 -0500 Received: from prod-mail-xrelay07.akamai.com ([72.246.2.115]:13367 "EHLO prod-mail-xrelay07.akamai.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbbBJEGS (ORCPT ); Mon, 9 Feb 2015 23:06:18 -0500 Message-ID: <54D983B9.800@akamai.com> Date: Mon, 09 Feb 2015 23:06:17 -0500 From: Jason Baron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Peter Zijlstra CC: mingo@redhat.com, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, normalperson@yhbt.net, davidel@xmailserver.org, mtk.manpages@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] sched/wait: add round robin wakeup mode References: <20150209215045.GU21418@twins.programming.kicks-ass.net> In-Reply-To: <20150209215045.GU21418@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2015 04:50 PM, Peter Zijlstra wrote: > On Mon, Feb 09, 2015 at 08:05:57PM +0000, Jason Baron wrote: >> diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c >> index 852143a..17d1039 100644 >> --- a/kernel/sched/wait.c >> +++ b/kernel/sched/wait.c >> @@ -71,8 +71,11 @@ static void __wake_up_common(wait_queue_head_t *q, unsigned int mode, >> unsigned flags = curr->flags; >> >> if (curr->func(curr, mode, wake_flags, key) && >> - (flags & WQ_FLAG_EXCLUSIVE) && !--nr_exclusive) >> + (flags & WQ_FLAG_EXCLUSIVE) && !--nr_exclusive) { >> + if (flags & WQ_FLAG_ROUND_ROBIN) >> + list_move_tail(&curr->task_list, &q->task_list); >> break; >> + } >> } >> } > I think you meant to write something like: > > if (curr->func(curr, mode, wake_flags, key) && > (flags & WQ_FLAG_EXCLUSIVE)) { > if (flag & WQ_FLAG_ROUND_ROBIN) > list_move_tail(&curr->task_list, &q->task_list); > if (!--nr_exclusive) > break; > } > > Otherwise can only work for nr_exclusive==1. Indeed. I'm also wondering if its worth avoiding the list_move_tail() for the case where nr_exclusive is initially 0. IE the wake all case, where we are just going to end up doing a bunch of list_move_tail() calls, but end up in the same state. Thanks, -Jason