From: Shobhit Kumar <shobhit.kumar@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>,
Shobhit Kumar <shobhit.kumar@intel.com>
Cc: linux-pwm <linux-pwm@vger.kernel.org>,
Jani Nikula <jani.nikula@intel.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Alexandre Courbot <gnurou@gmail.com>,
Povilas Staniulis <wdmonster@gmail.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal
Date: Thu, 30 Apr 2015 12:47:05 +0530 [thread overview]
Message-ID: <5541D6F1.8090002@linux.intel.com> (raw)
In-Reply-To: <20150429142743.GU9169@x1>
On 04/29/2015 07:57 PM, Lee Jones wrote:
> On Wed, 29 Apr 2015, Shobhit Kumar wrote:
>
>> On some Intel SoC platforms, the panel enable/disable signals are
>> controlled by CRC PMIC. Add those control as a new GPIO in a lookup
>> table for gpio-crystalcove chip during CRC driver load
>>
>> v2: Make the lookup table static (Thierry)
>> Remove the lookup table during driver remove (Thierry)
>>
>> CC: Samuel Ortiz <sameo@linux.intel.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Alexandre Courbot <gnurou@gmail.com>
>> Cc: Thierry Reding <thierry.reding@gmail.com>
>> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
>> ---
>> drivers/mfd/intel_soc_pmic_core.c | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>
> I have no idea what this stuff is, but it looks plausible.
The CRC PMIC controls the panel enable/disable signal using one of GPIO
like lines. It was agreed by Linus Walleij to go this way. The matching
crystalcove gpio changes are already merged in Linux next as -
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=e189ca56d91bbf1d3fe2f88ab6858bf919d42adf
This just adds a consumer lookup table for the gpio. Since we do not
have a DT or board files, and since this was part of CRC driver, just
added the lookup table during CRC driver load itself. Same is done for
PWM in a later patch.
Regards
Shobhit
>
> For my own reference:
> Acked-by: Lee Jones <lee.jones@linaro.org>
>
>> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
>> index 7b50b6b..f3d918e 100644
>> --- a/drivers/mfd/intel_soc_pmic_core.c
>> +++ b/drivers/mfd/intel_soc_pmic_core.c
>> @@ -24,8 +24,19 @@
>> #include <linux/acpi.h>
>> #include <linux/regmap.h>
>> #include <linux/mfd/intel_soc_pmic.h>
>> +#include <linux/gpio/machine.h>
>> #include "intel_soc_pmic_core.h"
>>
>> +/* Lookup table for the Panel Enable/Disable line as GPIO signals */
>> +static struct gpiod_lookup_table panel_gpio_table = {
>> + /* Intel GFX is consumer */
>> + .dev_id = "0000:00:02.0",
>> + .table = {
>> + /* Panel EN/DISABLE */
>> + GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
>> + },
>> +};
>> +
>> static int intel_soc_pmic_find_gpio_irq(struct device *dev)
>> {
>> struct gpio_desc *desc;
>> @@ -85,6 +96,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,
>> if (ret)
>> dev_warn(dev, "Can't enable IRQ as wake source: %d\n", ret);
>>
>> + /* Add lookup table binding for Panel Control to the GPIO Chip */
>> + gpiod_add_lookup_table(&panel_gpio_table);
>> +
>> ret = mfd_add_devices(dev, -1, config->cell_dev,
>> config->n_cell_devs, NULL, 0,
>> regmap_irq_get_domain(pmic->irq_chip_data));
>> @@ -104,6 +118,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)
>>
>> regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data);
>>
>> + /* Remove lookup table for Panel Control from the GPIO Chip */
>> + gpiod_remove_lookup_table(&panel_gpio_table);
>> +
>> mfd_remove_devices(&i2c->dev);
>>
>> return 0;
>
next prev parent reply other threads:[~2015-04-30 7:17 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 13:59 [PATCH 0/8] Crystalcove (CRC) PMIC based panel and pwm control Shobhit Kumar
2015-04-29 13:59 ` [PATCH 1/8] drivers/gpio/gpiolib: Add support for removing registered consumer lookup table Shobhit Kumar
2015-05-05 9:32 ` [PATCH 1/8] gpiolib: " Shobhit Kumar
2015-05-05 10:45 ` Lee Jones
2015-05-05 15:44 ` [Intel-gfx] " Daniel Vetter
2015-05-07 7:25 ` Lee Jones
2015-05-06 14:49 ` [PATCH 1/8] drivers/gpio/gpiolib: " Linus Walleij
2015-05-06 15:09 ` [Intel-gfx] " Daniel Vetter
2015-05-12 8:52 ` Linus Walleij
2015-04-29 13:59 ` [PATCH 2/8] drivers/pwm/core: Add support to remove registered consumer lookup tables Shobhit Kumar
2015-05-05 9:34 ` [PATCH 2/8] pwm: core: " Shobhit Kumar
2015-05-06 12:21 ` Thierry Reding
2015-04-29 14:00 ` [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal Shobhit Kumar
2015-04-29 14:27 ` Lee Jones
2015-04-30 7:17 ` Shobhit Kumar [this message]
2015-04-29 14:29 ` Lee Jones
2015-05-05 9:36 ` [PATCH 3/8] mfd: intel_soc_pmic_core: " Shobhit Kumar
2015-05-12 9:14 ` Linus Walleij
2015-05-06 14:51 ` [PATCH 3/8] drivers/mfd: " Linus Walleij
2015-04-29 14:00 ` [PATCH 4/8] drivers/mfd: Add PWM cell device for Crystalcove PMIC Shobhit Kumar
2015-04-29 14:25 ` Lee Jones
2015-05-05 9:36 ` [PATCH 4/8] mfd: intel_soc_pmic_crc: " Shobhit Kumar
2015-04-29 14:00 ` [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM Shobhit Kumar
2015-04-29 14:24 ` Lee Jones
2015-05-05 9:48 ` Shobhit Kumar
2015-05-05 10:42 ` Lee Jones
2015-05-05 9:38 ` [PATCH 5/8] mfd: intel_soc_pmic_core: " Shobhit Kumar
2015-04-29 14:00 ` [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver Shobhit Kumar
2015-04-30 21:12 ` Paul Bolle
2015-06-18 17:54 ` [Intel-gfx] " Shobhit Kumar
2015-06-18 18:41 ` Paul Bolle
2015-06-19 6:46 ` Shobhit Kumar
2015-06-20 11:23 ` Paul Bolle
2015-06-20 18:04 ` Paul Gortmaker
2015-06-22 7:55 ` Shobhit Kumar
2015-05-05 9:38 ` [PATCH 6/8] pwm: crc: " Shobhit Kumar
2015-05-06 7:40 ` Paul Bolle
2015-05-07 7:13 ` [Intel-gfx] " Shobhit Kumar
2015-05-06 12:14 ` Thierry Reding
2015-05-07 7:19 ` [Intel-gfx] " Shobhit Kumar
2015-05-20 15:09 ` Shobhit Kumar
2015-06-17 2:43 ` Shobhit Kumar
2015-04-29 14:00 ` [PATCH 7/8] drm/i915: Use the CRC gpio for panel enable/disable Shobhit Kumar
2015-05-06 13:11 ` Jani Nikula
2015-05-06 14:08 ` [Intel-gfx] " Daniel Vetter
2015-05-12 11:10 ` Linus Walleij
2015-04-29 14:00 ` [PATCH 8/8] drm/i915: Backlight control using CRC PMIC based PWM driver Shobhit Kumar
2015-05-06 13:39 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5541D6F1.8090002@linux.intel.com \
--to=shobhit.kumar@linux.intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=shobhit.kumar@intel.com \
--cc=wdmonster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).