LKML Archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/4] spi: davinci: change the lower limit of pre-scale divider to 1
@ 2015-06-10  7:18 Murali Karicheri
  2015-06-10  7:22 ` Murali Karicheri
  0 siblings, 1 reply; 2+ messages in thread
From: Murali Karicheri @ 2015-06-10  7:18 UTC (permalink / raw
  To: broonie, linux-spi, linux-kernel; +Cc: Murali Karicheri

SPI hardware spec for Keystone specifies a lower value of 0 for pre-scale
divider that is used for generating spi clock which translates to a
clock divider of 2. So fix the lower limit to allow using a higher SPI
clock.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Acked-by: Sekhar Nori <nsekhar@ti.com>
---
 drivers/spi/spi-davinci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
index 5e99106..987afeb 100644
--- a/drivers/spi/spi-davinci.c
+++ b/drivers/spi/spi-davinci.c
@@ -265,7 +265,7 @@ static inline int davinci_spi_get_prescale(struct davinci_spi *dspi,
 
 	ret = DIV_ROUND_UP(clk_get_rate(dspi->clk), max_speed_hz);
 
-	if (ret < 3 || ret > 256)
+	if (ret < 1 || ret > 256)
 		return -EINVAL;
 
 	return ret - 1;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/4] spi: davinci: change the lower limit of pre-scale divider to 1
  2015-06-10  7:18 [PATCH 3/4] spi: davinci: change the lower limit of pre-scale divider to 1 Murali Karicheri
@ 2015-06-10  7:22 ` Murali Karicheri
  0 siblings, 0 replies; 2+ messages in thread
From: Murali Karicheri @ 2015-06-10  7:22 UTC (permalink / raw
  To: broonie, linux-spi, linux-kernel

On 06/10/2015 03:18 AM, Murali Karicheri wrote:
> SPI hardware spec for Keystone specifies a lower value of 0 for pre-scale
> divider that is used for generating spi clock which translates to a
> clock divider of 2. So fix the lower limit to allow using a higher SPI
> clock.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Acked-by: Sekhar Nori <nsekhar@ti.com>
> ---
>   drivers/spi/spi-davinci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
> index 5e99106..987afeb 100644
> --- a/drivers/spi/spi-davinci.c
> +++ b/drivers/spi/spi-davinci.c
> @@ -265,7 +265,7 @@ static inline int davinci_spi_get_prescale(struct davinci_spi *dspi,
>
>   	ret = DIV_ROUND_UP(clk_get_rate(dspi->clk), max_speed_hz);
>
> -	if (ret < 3 || ret > 256)
> +	if (ret < 1 || ret > 256)
>   		return -EINVAL;
>
>   	return ret - 1;
>
Please ignore this as I messed up the PATCH prefix. I will re-send it 
with v1 and some updates to the commit log.

-- 
Murali Karicheri
Linux Kernel, Keystone

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-10  7:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-10  7:18 [PATCH 3/4] spi: davinci: change the lower limit of pre-scale divider to 1 Murali Karicheri
2015-06-10  7:22 ` Murali Karicheri

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).