* [next:master 11893/11947] drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static?
@ 2015-06-17 6:56 kbuild test robot
2015-06-17 6:56 ` [PATCH next] Merge remote-tracking branch 'leds/for-next':: aat1290_intensity_to_brightness() can be static kbuild test robot
2015-06-17 15:21 ` [next:master 11893/11947] drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static? Jacek Anaszewski
0 siblings, 2 replies; 3+ messages in thread
From: kbuild test robot @ 2015-06-17 6:56 UTC (permalink / raw
To: Bryan Wu
Cc: kbuild-all, Michael Ellerman, Richard Purdie, Jacek Anaszewski,
linux-leds, linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: ca3cfaa9e7db530b14e4a2d98a9310130152fdb8
commit: 1da60a5e7198c716990ac6fa508e45e27e7067c0 [11893/11947] Merge remote-tracking branch 'leds/for-next'
reproduce:
# apt-get install sparse
git checkout 1da60a5e7198c716990ac6fa508e45e27e7067c0
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
drivers/leds/leds-aat1290.c:334:5: sparse: symbol 'init_mm_current_scale' was not declared. Should it be static?
>> drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static?
>> drivers/leds/leds-aat1290.c:412:5: sparse: symbol 'aat1290_brightness_to_intensity' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH next] Merge remote-tracking branch 'leds/for-next':: aat1290_intensity_to_brightness() can be static
2015-06-17 6:56 [next:master 11893/11947] drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static? kbuild test robot
@ 2015-06-17 6:56 ` kbuild test robot
2015-06-17 15:21 ` [next:master 11893/11947] drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static? Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2015-06-17 6:56 UTC (permalink / raw
To: Bryan Wu
Cc: kbuild-all, Michael Ellerman, Richard Purdie, Jacek Anaszewski,
linux-leds, linux-kernel
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
leds-aat1290.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c
index 1ac525b4..fd7c25f 100644
--- a/drivers/leds/leds-aat1290.c
+++ b/drivers/leds/leds-aat1290.c
@@ -394,7 +394,7 @@ static void aat1290_init_flash_timeout(struct aat1290_led *led,
}
#if IS_ENABLED(CONFIG_V4L2_FLASH_LED_CLASS)
-enum led_brightness aat1290_intensity_to_brightness(
+static enum led_brightness aat1290_intensity_to_brightness(
struct v4l2_flash *v4l2_flash,
s32 intensity)
{
@@ -409,7 +409,7 @@ enum led_brightness aat1290_intensity_to_brightness(
return 1;
}
-s32 aat1290_brightness_to_intensity(struct v4l2_flash *v4l2_flash,
+static s32 aat1290_brightness_to_intensity(struct v4l2_flash *v4l2_flash,
enum led_brightness brightness)
{
struct led_classdev_flash *fled_cdev = v4l2_flash->fled_cdev;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [next:master 11893/11947] drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static?
2015-06-17 6:56 [next:master 11893/11947] drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static? kbuild test robot
2015-06-17 6:56 ` [PATCH next] Merge remote-tracking branch 'leds/for-next':: aat1290_intensity_to_brightness() can be static kbuild test robot
@ 2015-06-17 15:21 ` Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Jacek Anaszewski @ 2015-06-17 15:21 UTC (permalink / raw
To: Bryan Wu; +Cc: Michael Ellerman, Richard Purdie, linux-leds, linux-kernel
On 06/17/2015 08:56 AM, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: ca3cfaa9e7db530b14e4a2d98a9310130152fdb8
> commit: 1da60a5e7198c716990ac6fa508e45e27e7067c0 [11893/11947] Merge remote-tracking branch 'leds/for-next'
> reproduce:
> # apt-get install sparse
> git checkout 1da60a5e7198c716990ac6fa508e45e27e7067c0
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
> drivers/leds/leds-aat1290.c:334:5: sparse: symbol 'init_mm_current_scale' was not declared. Should it be static?
>>> drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static?
>>> drivers/leds/leds-aat1290.c:412:5: sparse: symbol 'aat1290_brightness_to_intensity' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.
These should be statics. I'll send fixed patches tomorrow.
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-17 15:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-17 6:56 [next:master 11893/11947] drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static? kbuild test robot
2015-06-17 6:56 ` [PATCH next] Merge remote-tracking branch 'leds/for-next':: aat1290_intensity_to_brightness() can be static kbuild test robot
2015-06-17 15:21 ` [next:master 11893/11947] drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static? Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).