From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756439AbcAMKKW (ORCPT ); Wed, 13 Jan 2016 05:10:22 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:9410 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756222AbcAMKJ0 (ORCPT ); Wed, 13 Jan 2016 05:09:26 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 13 Jan 2016 01:52:10 -0800 Subject: Re: [PATCH v4 11/11] serial: 8250_omap: Add omap8250 earlycon To: Peter Hurley , Greg Kroah-Hartman References: <1428515119-25248-1-git-send-email-peter@hurleysoftware.com> <1452627672-9482-1-git-send-email-peter@hurleysoftware.com> <1452627672-9482-12-git-send-email-peter@hurleysoftware.com> <56955941.1080701@hurleysoftware.com> <569616B9.1090504@nvidia.com> CC: Masahiro Yamada , Rob Herring , Grant Likely , , , "Kevin Cernekee" , Sebastian Frias , "Paul Burton" , Arnd Bergmann From: Jon Hunter Message-ID: <5696224F.7050907@nvidia.com> Date: Wed, 13 Jan 2016 10:09:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <569616B9.1090504@nvidia.com> X-Originating-IP: [10.21.132.159] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/01/16 09:19, Jon Hunter wrote: > > On 12/01/16 19:51, Peter Hurley wrote: >> Wasn't planning on sending this patch just yet, but oh well. >> >> On 01/12/2016 11:41 AM, Peter Hurley wrote: >>> Add DT earlycon for 8250_omap driver. This boot console is included >>> for kernels built with CONFIG_SERIAL_EARLYCON=y, CONFIG_OF=y, >>> CONFIG_SERIAL_8250_OMAP=y, and CONFIG_OF_EARLY_FLATTREE=y. >>> >>> This boot console is enabled with the command line option "earlycon" >>> (without "=...") when the DT 'stdout-path' property matches a >>> compatible uart. For example, >>> >>> / { >>> chosen { >>> stdout-path = "serial0:115200"; >>> }; >>> >>> .... >>> >>> aliases { >>> serial0 = &uart0; >>> }; >>> >>> .... >>> >>> ocp : ocp { >>> uart0 : serial@44e09000 { >>> compatible = "ti,omap3-uart"; >>> } >>> }; >>> }; >>> >>> Signed-off-by: Peter Hurley >>> --- >>> drivers/tty/serial/8250/8250_early.c | 20 ++++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>> >>> diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c >>> index e7cdc0c..d1f6310 100644 >>> --- a/drivers/tty/serial/8250/8250_early.c >>> +++ b/drivers/tty/serial/8250/8250_early.c >>> @@ -201,3 +201,23 @@ EARLYCON_DECLARE(rt288x, early_rt288x_setup); >>> OF_EARLYCON_DECLARE(rt288x, "ralink,rt2880-uart", early_rt288x_setup); >>> >>> #endif /* CONFIG_SERIAL_8250_RT288X */ >> >> This patch may not apply because the context is sitting on top of >> unsubmitted code. Sorry. >> >> Regards, >> Peter Hurley >> >>> + >>> +#ifdef CONFIG_SERIAL_8250_OMAP >>> + >>> +static int __init early_omap8250_setup(struct earlycon_device *device, >>> + const char *options) >>> +{ >>> + struct uart_port *port = &device->port; >>> + >>> + if (!(device->port.membase || device->port.iobase)) >>> + return -ENODEV; >>> + >>> + port->regshift = 2; >>> + device->con->write = early_serial8250_write; >>> + return 0; >>> +} > > I see you did not mean to send this out, but would the above still be > necessary with my patch [0]? I am wondering if with my patch you can > just add the below OF_EARLYCON_DECLARE() for OMAP? Sorry, I see that you have also already made the changes I have in patch [0]. However, still curious why you need the above for OMAP? Jon [0] http://marc.info/?l=linux-serial&m=145259482325332&w=2