From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754190AbcAMQfp (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jan 2016 11:35:45 -0500
Received: from mail-pf0-f175.google.com ([209.85.192.175]:33715 "EHLO
	mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753571AbcAMQfn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jan 2016 11:35:43 -0500
Subject: Re: [PATCH v4 05/11] of: earlycon: Initialize port fields from DT
 properties
To: Rob Herring <robh+dt@kernel.org>
References: <1428515119-25248-1-git-send-email-peter@hurleysoftware.com>
 <1452627672-9482-1-git-send-email-peter@hurleysoftware.com>
 <1452627672-9482-6-git-send-email-peter@hurleysoftware.com>
 <CAL_JsqJiKfT5nu6vatU4U3kv7dfs5vx8QEW6mS0=Qj4iX4CE8w@mail.gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Grant Likely <grant.likely@linaro.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kevin Cernekee <cernekee@gmail.com>, Jon Hunter <jonathanh@nvidia.com>,
        Sebastian Frias <sf84@laposte.net>,
        Paul Burton <paul.burton@imgtec.com>
From: Peter Hurley <peter@hurleysoftware.com>
Message-ID: <56967CDC.6040706@hurleysoftware.com>
Date: Wed, 13 Jan 2016 08:35:40 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CAL_JsqJiKfT5nu6vatU4U3kv7dfs5vx8QEW6mS0=Qj4iX4CE8w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/12/2016 03:49 PM, Rob Herring wrote:
> On Tue, Jan 12, 2016 at 1:41 PM, Peter Hurley <peter@hurleysoftware.com> wrote:
>> Read the optional "reg-offset", "reg-shift", "reg-io-width" and endianness
>> properties and initialize the respective struct uart_port field if found.
>>
>> NB: These bindings are common to several drivers and the values merely
>> indicate the default value; the registering earlycon setup() method can
>> simply override the values if required.
>>
>> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
>> ---
> 
>> diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c
>> index 7509ee34d..03eac4a 100644
>> --- a/drivers/tty/serial/earlycon.c
>> +++ b/drivers/tty/serial/earlycon.c
>> @@ -20,6 +20,10 @@
>>  #include <linux/serial_core.h>
>>  #include <linux/sizes.h>
>>
>> +#ifdef CONFIG_OF_EARLY_FLATTREE
>> +#include <linux/of_fdt.h>
>> +#endif
> 
> I think you don't need the ifdef around this.
> 
>> +
>>  #ifdef CONFIG_FIX_EARLYCON_MEM
>>  #include <asm/fixmap.h>
>>  #endif

Ok, will take care of that.